Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (frontend) Create team #43

Merged
merged 3 commits into from
Feb 19, 2024
Merged

✨ (frontend) Create team #43

merged 3 commits into from
Feb 19, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Feb 7, 2024

Purpose

Integrate the design to create a team.

Proposal

  • Change router next.js from app to page
  • Integrate the design to create a team

Demo

scrnli_2_13_2024_11-06-18.AM.webm

@AntoLC AntoLC self-assigned this Feb 7, 2024
@AntoLC AntoLC added frontend Relative to the frontend noChangeLog labels Feb 7, 2024
@AntoLC AntoLC changed the base branch from main to feature/frontend/search-groupe February 7, 2024 16:13
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from 5e25ddc to 618d538 Compare February 8, 2024 10:43
@AntoLC AntoLC changed the base branch from feature/frontend/search-groupe to main February 8, 2024 10:50
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch 7 times, most recently from f8b2654 to f5a9de1 Compare February 8, 2024 16:09
@AntoLC AntoLC marked this pull request as ready for review February 8, 2024 16:15
@AntoLC AntoLC changed the base branch from main to feature/frontend/search-groupe February 8, 2024 16:16
@AntoLC AntoLC force-pushed the feature/frontend/search-groupe branch from 0fb2d4f to aec47f8 Compare February 8, 2024 16:16
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from f5a9de1 to 513ef49 Compare February 8, 2024 16:22
@AntoLC AntoLC removed the request for review from lebaudantoine February 8, 2024 16:50
@AntoLC AntoLC force-pushed the feature/frontend/search-groupe branch 4 times, most recently from 64e1b1d to 2ce7c2a Compare February 9, 2024 11:22
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from 513ef49 to 8dd9182 Compare February 9, 2024 15:29
@AntoLC AntoLC changed the base branch from feature/frontend/search-groupe to main February 9, 2024 15:30
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch 4 times, most recently from 4ddaa68 to 3a2534f Compare February 9, 2024 16:14
@AntoLC AntoLC changed the base branch from main to feature/frontend/search-groupe February 9, 2024 16:21
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from 3a2534f to 732de89 Compare February 9, 2024 16:22
@AntoLC AntoLC removed the request for review from lebaudantoine February 13, 2024 09:40
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from 732de89 to 27d7eb1 Compare February 13, 2024 09:56
@AntoLC AntoLC changed the base branch from feature/frontend/search-groupe to main February 13, 2024 09:58
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch 2 times, most recently from 3acfbdc to 8c34edf Compare February 13, 2024 10:04
@AntoLC AntoLC changed the base branch from main to feature/frontend/search-groupe February 13, 2024 10:12
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch 2 times, most recently from 01d409c to 45083d1 Compare February 13, 2024 10:24
@AntoLC AntoLC removed the request for review from lebaudantoine February 13, 2024 11:41
@AntoLC AntoLC force-pushed the feature/frontend/search-groupe branch 3 times, most recently from 8401b83 to 6d11ca3 Compare February 15, 2024 08:48
Base automatically changed from feature/frontend/search-groupe to main February 15, 2024 08:56
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from 45083d1 to c41dc68 Compare February 15, 2024 09:41
Copy link
Collaborator

@lebaudantoine lebaudantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/frontend/apps/desk/next.config.js Show resolved Hide resolved
src/frontend/apps/desk/src/pages/help/index.tsx Outdated Show resolved Hide resolved
src/frontend/apps/desk/src/pages/index.tsx Show resolved Hide resolved
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from eabcd9b to b34eda4 Compare February 19, 2024 13:58
2 routers exists in Next.js, "app" router and "page" router.
The "app" router has a bug introduced in Next.js 13.4.14, which is
not fixed yet. For the moment we cannot use dynamic routes with
"app" router with an SPA. As advised by the Next.js team, we
migrated to the "pages" router.
- Integrate the create team design based from the
mockup
- Manage the different states of the create team
In every team, the owner is always included in it,
so we shouldn't count the owner when we display the icon
to say if a team has members.
@AntoLC AntoLC force-pushed the feature/frontend/create-team branch from b34eda4 to f80743a Compare February 19, 2024 13:59
@AntoLC AntoLC merged commit 77efb1a into main Feb 19, 2024
12 checks passed
@AntoLC AntoLC deleted the feature/frontend/create-team branch February 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Relative to the frontend noChangeLog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants