-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (frontend) Create team #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 8, 2024 10:43
5e25ddc
to
618d538
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
7 times, most recently
from
February 8, 2024 16:09
f8b2654
to
f5a9de1
Compare
AntoLC
force-pushed
the
feature/frontend/search-groupe
branch
from
February 8, 2024 16:16
0fb2d4f
to
aec47f8
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 8, 2024 16:22
f5a9de1
to
513ef49
Compare
AntoLC
force-pushed
the
feature/frontend/search-groupe
branch
4 times, most recently
from
February 9, 2024 11:22
64e1b1d
to
2ce7c2a
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 9, 2024 15:29
513ef49
to
8dd9182
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
4 times, most recently
from
February 9, 2024 16:14
4ddaa68
to
3a2534f
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 9, 2024 16:22
3a2534f
to
732de89
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 13, 2024 09:56
732de89
to
27d7eb1
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
2 times, most recently
from
February 13, 2024 10:04
3acfbdc
to
8c34edf
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
2 times, most recently
from
February 13, 2024 10:24
01d409c
to
45083d1
Compare
AntoLC
force-pushed
the
feature/frontend/search-groupe
branch
3 times, most recently
from
February 15, 2024 08:48
8401b83
to
6d11ca3
Compare
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 15, 2024 09:41
45083d1
to
c41dc68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/frontend/apps/desk/src/features/teams/__tests__/PanelTeams.test.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/__tests__/PanelTeams.test.tsx
Outdated
Show resolved
Hide resolved
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 19, 2024 08:46
c41dc68
to
9aea661
Compare
lebaudantoine
approved these changes
Feb 19, 2024
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 19, 2024 13:58
eabcd9b
to
b34eda4
Compare
2 routers exists in Next.js, "app" router and "page" router. The "app" router has a bug introduced in Next.js 13.4.14, which is not fixed yet. For the moment we cannot use dynamic routes with "app" router with an SPA. As advised by the Next.js team, we migrated to the "pages" router.
- Integrate the create team design based from the mockup - Manage the different states of the create team
In every team, the owner is always included in it, so we shouldn't count the owner when we display the icon to say if a team has members.
AntoLC
force-pushed
the
feature/frontend/create-team
branch
from
February 19, 2024 13:59
b34eda4
to
f80743a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Integrate the design to create a team.
Proposal
app
topage
Demo
scrnli_2_13_2024_11-06-18.AM.webm