⬆️(dependencies) remove unneeded dependencies #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morendil
force-pushed
the
remove-extra-deps
branch
2 times, most recently
from
b0426b3
to
64c3688
Compare
|
boto3 is used by |
|
To recap our quick in-person chat: for django-storages and whitenoise respectively, boto3 and Brotli are transitive dependencies but marked as optional, so we're leaving them in to ensure they're both picked up. |
Morendil
force-pushed
the
remove-extra-deps
branch
from
64c3688
to
7ce7b31
Compare
mjeammet
approved these changes
Nov 5, 2024
Remove url-normalize as it is not referenced anywhere
Morendil
force-pushed
the
remove-extra-deps
branch
from
7ce7b31
to
839b8b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To reduce attack surface and dependency updates, remove listed dependencies that are not actually in use.
Proposal
Remove url-normalize which is not referenced anywhere