Updating Quaddtype #102
Updating Quaddtype #102
Conversation
There was a problem hiding this comment.
I did not carefully review all the reference counting or go over everything with a fine-toothed comb but I did go over the whole thing and followed along with the structure.
Overall this looks really nice. I think there are some clear paths to improve it, but that's always going to be the case and this is already far enough along that once we have some basic docs written we can try inviting people to test it and start thinking about a NEP to do something about np.128.
There was a problem hiding this comment.
Not needed for this PR, but it would be nice to get proper docstrings for all the types and functions that are visible to python. Also a small module-level docstring showing basic usage.
| else { | ||
| result.longdouble_value = x; | ||
| } | ||
| return result; |
There was a problem hiding this comment.
not needed for this PR, but the repeated boilerplate above is a good place to use a template function IMO
| } | ||
| else { | ||
| return x.longdouble_value; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think it would be simpler to template over backend and output type, then you wouldn't need the runtime branching.
This PR updates the following to quaddtype
longdoublebackendnumpy_quaddtypeand more small refactors