Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize assignments inside try/finally statements. #583

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Recognize assignments inside try/finally statements. #583

merged 2 commits into from
Sep 6, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #582

mikkelbu
mikkelbu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, but I'm also happy to merge it as it is

...zers.tests/DiagnosticSuppressors/NonNullableFieldOrPropertyIsUninitializedSuppressorTests.cs Show resolved Hide resolved
@manfred-brands
Simplified TryFinally test.
3c31397 
Have assignments in both the try and the finally part.
@manfred-brands manfred-brands merged commit fde37e8 into nunit:master Sep 6, 2023
3 checks passed
@manfred-brands manfred-brands deleted the Issue582_AssignmentInTryFinally branch September 6, 2023 00:54
@mikkelbu mikkelbu added this to the Release 3.7 / 2.7 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.7 / 2.7
Development

Successfully merging this pull request may close these issues.

NonNullableFieldOrPropertyIsUninitializedSuppressor does not detect assignments in try/finally blocks
2 participants
@manfred-brands @mikkelbu