Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IndexOutOfRangeException threw by WithinUsageAnalyzer #597

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: IndexOutOfRangeException threw by WithinUsageAnalyzer #597

merged 1 commit into from
Sep 22, 2023

Conversation

HenryZhang-ZHY
Copy link
Contributor

fix #596

@HenryZhang-ZHY
Copy link
Contributor Author

@dotnet-policy-service agree

@HenryZhang-ZHY
Copy link
Contributor Author

PTAL @manfred-brands

manfred-brands
manfred-brands approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HenryZhang-ZHY for not only reporting this, but also supplying the simple fix

@manfred-brands manfred-brands merged commit 9b7f547 into nunit:master Sep 22, 2023
3 checks passed
@HenryZhang-ZHY
Copy link
Contributor Author

HenryZhang-ZHY commented Sep 23, 2023 •
edited
Loading

Which version number will include this fix? When will it be released? @manfred-brands

@mikkelbu
Copy link
Member

Which version number will include this fix? When will it be released? @manfred-brands

@HenryZhang-ZHY I think I'll create a version 3.7.1 and release it today or tomorrow (I just want to get one change

@mikkelbu mikkelbu added this to the Release 3.8 / 2.8 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manfred-brands manfred-brands manfred-brands approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.8 / 2.8
Development

Successfully merging this pull request may close these issues.

WithinUsageAnalyzer threw an exception of type 'System.IndexOutOfRangeException'
3 participants
@HenryZhang-ZHY @mikkelbu @manfred-brands