Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suppress CA1001 if Fixture uses LifeCycle.InstancePerTestCase #599

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #595

When a TestFixture uses LifeCycle.InstancePerTestCase it can use an IDispose implementation.

Fields can be initialized in the constructor and disposed in the Dispose method.

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @manfred-brands

@mikkelbu mikkelbu merged commit f6e3687 into nunit:master Sep 25, 2023
3 checks passed
@mikkelbu mikkelbu added this to the Release 3.8 / 2.8 milestone Sep 25, 2023
@manfred-brands manfred-brands deleted the issue595_InstancePer branch September 27, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NUnit1032 false positive in LifeCycle.InstancePerTestCase test fixture using constructor
2 participants