Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NUnit version 4. #612

Merged
merged 11 commits into from
Oct 29, 2023
Merged

Conversation

manfred-brands
Copy link
Member

@manfred-brands manfred-brands commented Oct 16, 2023

Detect ClassicAssert

Fixes #610
Fixes #606
Fixes #562
Fixes #617
Fixes #618
Fixes #620

@manfred-brands manfred-brands force-pushed the NUnit4 branch 8 times, most recently from 06d112f to e90ff7e Compare October 26, 2023 03:49
@manfred-brands manfred-brands marked this pull request as ready for review October 26, 2023 03:58
@manfred-brands
Copy link
Member Author

@mikkelbu I have tested this extensively with my work projects and converted about 50,000 classic asserts, including StringAssert and CollectionAssert. In addition it converted string format-specification+params into formattable strings.

I didn't make separate PRs as some build on others (params -> interpolatable).

We can release this as 3.90.
For 4.0 we then drop the netstandard1.6 build.

@mikkelbu mikkelbu added this to the Release 3.10 / 2.10 milestone Oct 27, 2023
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @manfred-brands 👍 . I've reviewed the majority of the changes, but I still need to review 21 files (mostly the new analyzers and code-fixes). I should have time for this tomorrow.

So far I've only some minor comments and questions.

@manfred-brands
Copy link
Member Author

I have added the two mentioned changes and rebased on latest master.

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous work @manfred-brands 👍. I found CodeFixHelper.cs a little hard to follow, so perhaps we need some more tests of this (we can also postpone this - just so we can release all the improvements as quickly as possible).

I'm happy to get this in (and release it) when you are

@manfred-brands manfred-brands merged commit 3266452 into nunit:master Oct 29, 2023
3 checks passed
@manfred-brands
Copy link
Member Author

@mikkelbu There are some discussions about renaming the ClassicAsserts which would mean changing this.
If you want to release it now, it probably should be a beta package.

@manfred-brands manfred-brands deleted the NUnit4 branch October 29, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants