Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Values against generic type constraints #638

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Check Values against generic type constraints #638

merged 1 commit into from
Nov 16, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #632

@manfred-brands manfred-brands mentioned this pull request Nov 14, 2023
Closed
mikkelbu
mikkelbu approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Only a couple of comments

src/nunit.analyzers.tests/ValuesUsage/ValuesUsageAnalyzerTests.cs Outdated Show resolved Hide resolved
src/nunit.analyzers.tests/ValuesUsage/ValuesUsageAnalyzerTests.cs Outdated Show resolved Hide resolved
@manfred-brands manfred-brands merged commit 8fe0d46 into nunit:master Nov 16, 2023
4 checks passed
@manfred-brands manfred-brands deleted the issue632_Values branch November 16, 2023 00:00
@mikkelbu mikkelbu added this to the Release 3.10 / 2.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.10 / 2.10
Development

Successfully merging this pull request may close these issues.

NUnit1031 doesn't seem to work with Generic parameters
2 participants
@manfred-brands @mikkelbu