Make best attempt at fixing trivia

[Bartleby2718]

I think this is now ready for review. I had to delete some tests from #160, so I'd appreciate it if anyone could give me specific suggestions on where to improve. I agree that there are some inconsistencies in terms of where I've touched, but I believe I did need all of these to pass all tests.

Thanks in advance!

This fixes #713.

[Bartleby2718]

By the way, can anyone assign the ticket and the PR to me?

[manfred-brands]

By the way, can anyone assign the ticket and the PR to me?

Done.

[Bartleby2718]

All tests are passing now.

[manfred-brands]

Thanks @Bartleby2718 for your contribution.
Your changes and new tests are comprehensive.

There is, as expected, a lot of repeated:

return (actualArgument, constraintArgument.WithTriviaFrom(actualArgument));

I wonder if you can drop all those and only move this to the ClassicModelAssertUsageCodeFix, where you already deal with the Trivia from the first and last argument.

[Bartleby2718]

@manfred-brands I've:

• added some test cases (CodeFixMaintainsReasonableTriviaWithAllArgumentsOnSameLine) to cover Make best attempt at fixing trivia #754 (comment). (For assertions like ClassicAssert.IsEmpty where only one argument is enough, I've added a message argument so that there are more than one arguments, all on the same line.)
• centralized the trivia-handling logic, allowing me to revert some unnecessary changes

I feel much better about the changes now. Thanks for the suggestions!

[manfred-brands]

@Bartleby2718 I think we are almost there.
The changes to actual CodeFix are far less than before.
Some small comments.

[manfred-brands]

Thanks @Bartleby2718. This looks good now.

[Bartleby2718]

@mikkelbu Could you review this one when you get a chance?

[mikkelbu]

Sorry for the slow answer, but I've had very little spare time the last couple of weeks. I should have time to look at it tonight (in 8-9 hours time)

[mikkelbu]

Looks great @Bartleby2718. I've only added a handful of some minor nit-pick comments, but the overall PR is great. Thanks for the contribution 👍.

[Bartleby2718]

@mikkelbu This should now be ready for another review!

[mikkelbu]

Sorry about leaving this hanging. I'll take a look at this next weekend.

[mikkelbu]

Looks great. Thanks for this huge effort @Bartleby2718. I'll merge this now