Skip to content

Commit

Permalink
Merge pull request #571 from jnm2/fix_acceptance_tests_for_15.9
Browse files Browse the repository at this point in the history
Fix acceptance tests for 15.9
  • Loading branch information
OsirisTerje authored Nov 22, 2018
2 parents af8f97b + de7b8ee commit e343ac4
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions acceptance.cake
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ Task("Acceptance")

using (var tempDirectory = new TempDirectory())
{
BuildAndVerifySinglePassingTest("Simple", "net35", "netcoreapp1.0");
BuildAndVerifySinglePassingTest("Referencing Mono.Cecil", "net35", "netcoreapp1.0");
BuildAndVerifySinglePassingTest("Referencing Mono.Cecil 0.10.0", "net35", "netcoreapp1.0");
BuildAndVerifySinglePassingTest("Simple", "net45", "netcoreapp1.0");
BuildAndVerifySinglePassingTest("Referencing Mono.Cecil", "net45", "netcoreapp1.0");
BuildAndVerifySinglePassingTest("Referencing Mono.Cecil 0.10.0", "net45", "netcoreapp1.0");

void BuildAndVerifySinglePassingTest(string projectName, params string[] targetFrameworks)
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net35;netcoreapp1.0</TargetFrameworks>
<TargetFrameworks>net45;netcoreapp1.0</TargetFrameworks>
<RootNamespace>Referencing_Mono_Cecil_0_10_0</RootNamespace>
</PropertyGroup>

Expand All @@ -12,11 +12,11 @@
<PackageReference Include="NUnit3TestAdapter" Version="3.11.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net35'">
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<PackageReference Include="nunit.engine.api" Version="3.7.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp1.0'">
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<PackageReference Include="System.Diagnostics.FileVersionInfo" Version="*" />
<PackageReference Include="nunit.engine.netstandard" Version="3.7.0" />
</ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions tests/Referencing Mono.Cecil/Referencing Mono.Cecil.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net35;netcoreapp1.0</TargetFrameworks>
<TargetFrameworks>net45;netcoreapp1.0</TargetFrameworks>
<RootNamespace>Referencing_Mono_Cecil</RootNamespace>
</PropertyGroup>

Expand All @@ -12,7 +12,7 @@
<PackageReference Include="NUnit3TestAdapter" Version="3.11.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp1.0'">
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<PackageReference Include="System.Diagnostics.FileVersionInfo" Version="*" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion tests/Simple/Simple.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net35;netcoreapp1.0</TargetFrameworks>
<TargetFrameworks>net45;netcoreapp1.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit e343ac4

Please sign in to comment.