feat: exclude external pages from Sitemap #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fuse314
commented
Oct 24, 2023
fuse314
commented
- Include pages with relative externalUrl with correct URL in Sitemap
- Exclude pages with absolute externalUrl from Sitemap
- Include pages with relative externalUrl with correct URL in Sitemap
- Improve output XML (no more linebreaks and spaces)
…e externalUrl with correct URL in Sitemap - Exclude pages with absolute externalUrl from Sitemap - Include pages with relative externalUrl with correct URL in Sitemap - Improve output XML (no more linebreaks and spaces)
|
The isset check for externalUrl did not work correctly before, pages with relativeUrl were still included in the Sitemap XML. |
|
Thanks for this @fuse314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.