set correct permissions and remove unnecessary changes #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanoWoerner
force-pushed
the
enh/add-twofactor-email-at-login
branch
from
646e30c to
9a41174
Compare
Signed-off-by: Stefano Woerner <[email protected]>
StefanoWoerner
force-pushed
the
enh/add-twofactor-email-at-login
branch
from
9a41174 to
5893602
Compare
|
After such a long break it took me a while to realize that this PR is against the enh branch, not v2 itself. I committed since I verified that nothing that must remain is deleted by the PR, and the mode change shouldn't change anything for me since it partly already was that way in my local GIT working directory. Thanks anyway and sorry it took me so long to approve your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes #357 cleaner. No new functionality is added through this PR.