New message view #116
New message view #116
Conversation
still a bug with the gradient on too long sender names and timestamps
(not that important, maybe later...)
and start moving message styling to MessageModelItem
fix scene width
|
Bug fixed. |
Not sure what you mean. I was talking about the four checkboxes Quassel has on its search widget.
The current default window size is quite minimal, we could increased it, or we could remove the text like "Regular messages only" from the buttons and use icons instead, though that's a bit cryptic, I like to know what a button does without a need to hover over it...
But there will be groupchats. |
| enum CutoffMode { | ||
| CutoffLeft, | ||
| CutoffRight | ||
| }; |
There was a problem hiding this comment.
ChatScene::CutoffMode doesn't seem to be used anywhere, should we keep it or remove it? What was it originally used for anyway?
|
Are those |
| mSearchLineEdit = new QLineEdit(this); | ||
| mSearchLineEdit->setClearButtonEnabled(true); | ||
| mSearchLineEdit->setPlaceholderText(tr("Search")); | ||
| connect(mSearchLineEdit, &QLineEdit::textChanged, this, &ChatViewSearchWidget::setSearchString); |
There was a problem hiding this comment.
Quassel does something interesting here: instead of executing the search every time text changes, it waits 300 milliseconds for the text to be changed and only then executes the search.
|
Also, some of files miss the license notice. |
Conflicts: src/messagedisplaywidget.cpp
I'll remove that. It described, how Quassel cuts long nick names. Maybe the mockup guy from #12 could make a proposal how to do in Tox.
Yes ;) |
Will ask him how would he cut off too long nicknames. It makes more sense to me to do CutoffRight, though there are some languages that are written in right to left direction, maybe that would make more sense to their users (though it would make even more sense to mirror the whole message display in that case, and i don't think we are going that far as implementing that, heh). |
- Add missing licence headers - Remove unused code in ChatScene - Add search delay timer for better performance - Prevent searching if searchbar is not visible
and comment out some currently unused message handling functions
and fix sending typing notification if input widget focus lost
|
I see you also used a timer for typing notifications, nice. It's kind of an obvious thing, but apparently some people miss that, considering one conversation on an irc channel. Btw, I saw you pinging me on the irc the other day, feel free to email me if I'm afk in irc. |
|
I selected a smiley
If I select the |
|
I didn't really read all the code, though I don't see why I shouldn't merge it and read&fix afterwards as I go, not to mention that it works well and I didn't notice any outstanding bugs. Thanks for the work, hopefully that smiley bug would get fixed : ) |
|
Wohoo this got merged =) Good job @Schlumpf |
|
Great work. |
|
Yep, smileys seem to be a bit buggy, will make a separate issue. |
Here comes the new message view.
Features:
Fixes:
PS: This replaces the old push request #110 .