-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified added and find functions #31
base: master
Are you sure you want to change the base?
Conversation
normaliseName takes in a String as input and outputs a string with 1st letter capitalised and the rest lowercase
Added capability to normalise multi-word names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Great job on making your first enhancement to AB! Just one small note:
- Try to use present tense/imperative verb when writing commit message. For instance: Instead of "Added ... function", use "Add ..." or "Modify ..."
Hi @DanielDSSim, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
Modified add and find functions to normalise names of addressees with capitalised first letter for every word of name.
@Happytreat