[W5][W13-4]Chua Eng Soon #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work overall! The coding style is very consistent and follows the guideline. The update command would definitely prove useful, since it's obviously a chore to remove and add the user entirely. |
|
Good call in adding functionality of updating a contact - a thing that a user often does because people often change their personal details, like phone number and address |
ewaldhew
reviewed
Feb 14, 2019
| String phone, boolean isPhonePrivate, | ||
| String email, boolean isEmailPrivate, | ||
| String address, boolean isAddressPrivate, | ||
| Set<String> tags) throws IllegalValueException { |
There was a problem hiding this comment.
Indentation is a bit strange here - either align the parameters vertically or keep everything to the left one indent in from the start of the declaration, maybe.
| new Phone(phone, isPhonePrivate), | ||
| new Email(email, isEmailPrivate), | ||
| new Address(address, isAddressPrivate), | ||
| tagSet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.