[W5][W15-4]Cho Ming En #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice functionality in the case where the user is lazier and does not wish to view the list before deleting. |
|
Good addition since it is easier to remember or get a person's name than to remember what tag you added to them |
|
Good idea to improve the delete command to make it easier for the user. |
|
Cool improvement to existing features! |
Happytreat
reviewed
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new syntax to use 'delete', which is by name. Easier to delete a particular person in just one step.
Updated the DeleteCommand class to have the extra functionality and Parser to parse just the name.
User Guide also updated to reflect new usage of 'delete'