[W5][W09-3] Sivakumar Bavadharini #156
Conversation
There was a problem hiding this comment.
@bava98 Nice job on implementing the sort command (: Remember to update the help command as well. Also, try to create a new branch for your feature (:
Please close this PR after reading review comments.
| /** | ||
| * Sorts all persons in the address book by their name and lists them to the user. | ||
| */ | ||
| public class SortCommand extends Command{ |
There was a problem hiding this comment.
Remember to add a whitespace before the curly brace (:
| public UniquePersonList sortListByName() { | ||
| try { | ||
| UniquePersonList sortedList = new UniquePersonList(this.internalList); | ||
| sortedList.internalList.sort(new SortByName()); |
There was a problem hiding this comment.
Good job on modifying a copy of the data instead of the original data (:
| case HelpCommand.COMMAND_WORD: // Fallthrough | ||
| default: | ||
| return new HelpCommand(); | ||
| case AddCommand.COMMAND_WORD: |
There was a problem hiding this comment.
Try to follow the indentation in the coding standard for switch statements (:
| @@ -15,6 +13,8 @@ | |||
| import seedu.addressbook.data.person.ReadOnlyPerson; | |||
| import seedu.addressbook.util.TypicalPersons; | |||
|
|
|||
| import static org.testng.AssertJUnit.assertEquals; | |||
There was a problem hiding this comment.
Try not to commit unrelated changes in this PR
| import java.util.Collections; | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.*; |
There was a problem hiding this comment.
Wildcard imports violate the coding standard. Please use single imports and change your settings in Intellij: Settings > Editor > Code Style > Java > Imports and set both class count and names count to 99 (or any large number)
Add a sort command which sorts the list alphabetically and shows the sorted list, or no names if the list is empty.