Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W5][W15-3]Teng Yun #158

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[W5][W15-3]Teng Yun #158

wants to merge 4 commits into from

Conversation

CaesarTY
Copy link

Add new field Major

@CaesarTY
Copy link
Author

@WeeSooJun @chiuyuhua @COGnitiveAspian @DanielDSSim

@DanielDSSim
Copy link

Good edit. I see you edited the user guide as well

Happytreat
Happytreat reviewed Feb 16, 2019
View reviewed changes
Copy link

@Happytreat Happytreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First for commit messages: Encouraged to use imperative (root word) to start. E.g. Instead of Updated UI Test, use "Update UI Test"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Happytreat Happytreat Happytreat left review comments

Assignees

@Happytreat Happytreat

Labels
Reviewed W15-3 W15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaesarTY @DanielDSSim @Happytreat @nus-se-pr-bot