[W5][W13-3]Ruhani Suri

[suriruhani]

Add a 'history' command that lists all past user entered commands in reverse chronological order.
Format: history

[case141]

Nice feature. You may want to add some I/O tests as well as update the user guide too.

[ToonDragon]

Excellent usage of the stack to store all the commands since they follow a first in last out concept. A possible future improvement could be to allow users to select and repeat past commands like that found in the console commands when you press the up arrow key.

Other than that, the code is well written, functions are well defined and variables are properly named.

[case141]

A possible future improvement could be to allow users to select and repeat past commands like that found in the console commands when you press the up arrow key.

@DarrenDragonLee Nice suggestion, that would fall under the undo command.

[ewaldhew]

Good enhancement. Nice use of Java library functions. :)

Close the PR after reading @suriruhani

[ewaldhew]

Does this need to be public?

[suriruhani]

I have changed it to private in Main.java now, however it is public in Parser.java and HistoryCommand.java. I think that is needed because I will be passing the CommandHistory Stack from main to parser to the the command handling class. Please let me know if this can be done in a better way and why this approach is not preferred.

[ewaldhew]

It isn't that its not preferred, as long as you have a reason to make things publicly accessible then that's fine :)

Remember to close this PR!

[suriruhani]

A possible future improvement could be to allow users to select and repeat past commands like that found in the console commands when you press the up arrow key.

@DarrenDragonLee Nice suggestion, that would fall under the undo command.

I think @DarrenDragonLee meant being able to choose a particular past command and repeat it. This is different from redo-ing the last executed command. This seems like a tricky yet interesting feature to implement. We can think about including it in V2.0. Thanks Darren!