[W5][T12-1]Tejas Bhuwania #173
Conversation
added a new function which counts total number of people in AddressBook updated parser test file and parser updated other classes to maintain with the two new functions added updated Message Display to show the two new functions added
|
@sreycodes can you help me review? |
updated I/O tests
|
The new command is very handy. It is much easier to get the size of the address book now. Maybe it is better if there are more small commits instead of a single big one. |
|
Really useful PR once the address book starts becoming big. Great work! |
| import seedu.addressbook.data.person.Email; | ||
| import seedu.addressbook.data.person.Phone; | ||
| import seedu.addressbook.data.person.Name; | ||
| import seedu.addressbook.data.person.Address; |
There was a problem hiding this comment.
There should be a line break after the imports
|
|
||
| Shows a list of the top ten persons, along with their non-private details, in the address book. | ||
| Format: 'topTen' | ||
|
|
| int size = allPersons.size(); | ||
| if (size < 10) { | ||
| return new CommandResult(getMessageForPersonListShownSummary(allPersons), allPersons); | ||
| } else { |
There was a problem hiding this comment.
Perhaps you don't need else here since you already have a guard clause
| + ": Displays the total number of people in the Address Book.\n" | ||
| + "Example: " + COMMAND_WORD; | ||
|
|
||
| public static final String MESSAGE_SUCCESS = " Contacts found "; |
There was a problem hiding this comment.
There is a trailing white space in this string
| /** | ||
| *Lists top 10 people in the addressBook | ||
| */ | ||
|
|
| /** | ||
| * Gets total count of contants | ||
| */ | ||
|
|
| import seedu.addressbook.commands.ViewAllCommand; | ||
| import seedu.addressbook.commands.ViewCommand; | ||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
|
|
||
| import seedu.addressbook.commands.*; |
There was a problem hiding this comment.
Some IDEs automatically change imports into wildcard like this, which is against our coding standards. Please configure your IDE so that it stops doing this :)
| || =================================================== | ||
| || Enter command: || [Command entered:topTen] | ||
| || | ||
| || 0 persons listed! |
There was a problem hiding this comment.
I don't get it, why 0 instead of 1?
| @@ -15,6 +15,7 @@ | |||
| import seedu.addressbook.commands.AddCommand; | |||
| import seedu.addressbook.commands.ClearCommand; | |||
| import seedu.addressbook.commands.Command; | |||
| import seedu.addressbook.commands.TopTenCommand; | |||
There was a problem hiding this comment.
Hmm I don't think this import should be here as imports are sorted alphabetically
| public void parse_topTenCommand_parsedCorrectly() { | ||
| final String input = "topTen"; | ||
| parseAndAssertCommandType(input, TopTenCommand.class); | ||
| } |
There was a problem hiding this comment.
Did you forget to test TotalCountCommand ? :)
added a new function which counts total number of people in AddressBook
updated parser test file and parser
updated other classes to maintain with the two new functions added
updated Message Display to show the two new functions added