Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5][W11-1]Tiffany Chong #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sciffany
Copy link

Currently find can only look for persons based on names

With this feature, we are find persons based on tags.

For example, find friends can filter out people with the tag called friends.

@nus-se-pr-bot
Copy link

Hi @sciffany, your pull request title is invalid.

For PR sent as submission of learning a topic/graded exercise, the PR name should be in the format of [Week ID][Team ID] Your Name, where [Week ID] has no dashes or spaces (e.g. [W5]) and [Team ID] has one dash only and no spaces (e.g. [W14-2] means Wednesday 2pm (14 hrs), Team 2).
E.g. If you are in tutorial W09 (i.e. Wednesday 9am), team 1, the PR title would be [W5][W09-1] James Yong. Note that your tutorial IDs are different from those shown in CORS/IVLE.

For team PR, the PR name should be in the format of [Team ID] Product Name (e.g. [T09-2] Contact List Pro).

Please follow the above format strictly and edit your title for reprocessing.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR.

@sciffany sciffany changed the title Enable finding based on tags [W5][W11-4]Tiffany Chong Feb 27, 2019
@sciffany sciffany changed the title [W5][W11-4]Tiffany Chong [W5][W11-1]Tiffany Chong Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants