[W17-4] ePiggy #24
Open
[W17-4] ePiggy #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonggqiii
pushed a commit
to yonggqiii/main
that referenced
this pull request
Mar 5, 2019
update find command and coresponding test file
cchj1995
pushed a commit
to cchj1995/addressbook-level4
that referenced
this pull request
Mar 11, 2019
* Updated README, testing travis CI * Documentation (nus-cs2103-AY1819S2#1) * Changed name, role and responsibilities * Updated responsibilities and layout * Updated format * Updated format * Updated format * Updated link to GitHub * Added Kyler's photo * Updated format * Updated responsibilities * Moved name down * Shifted role to below name * Removed old role data * Shifted various elements * Increase readability * Increase readability * Improve readability * Improve readability * Improve readability * Increase readability * Updated UI mockup * Updated project docs
adamwth
approved these changes
Mar 12, 2019
There was a problem hiding this comment.
Feedback for v1.1
Well done! Most v1.1 milestone objectives achieved, although there are still some things that need to be fixed (see below). I have also left comments with recommended changes in your UG and DG PDFs, which will be given to you shortly.
Github repository description
- Description updated
- Link to Github pages updated
README
- Project name updated
- UI Mockup updated
- Description updated
- Badges updated to your own fork (Travis, etc.)
- AB4 ackhowledgement
About Us
- Photos updated
- Roles updated
UG and DG
Comments are in their respective PDFs.
updated UG
Reformat DG
Fix typo in PPP
shortened ppp
updated UG for clear command and updated MainApp to v1.4
Modify repoSense
merge from main
final PPP change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teammates: Yunjun, Minh, Rahul, Kevin, Wenyi