Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W11-4] Book Squirrel #27

Open
wants to merge 596 commits into
base: master
Choose a base branch
from
Open

[W11-4] Book Squirrel #27

wants to merge 596 commits into from

Conversation

0blivious
Copy link

No description provided.

@kylase-learning
Copy link

kylase-learning commented Mar 11, 2019 •
edited
Loading

Feedback (Week 7; v1.1)

Github Project Page

  • Update Project description
  • Update Link to Project Page

README

  • UI Mockup updated in project website
  • Make the project website look like a product home page (aka remove the top nav bar)
  • AB4 acknowledgement
  • Travis badge updated to own fork's
  • Coveralls badge updated to own fork's (the link has extra https:// as prefix)

Project Page

  • Update to remove AB4 reference
  • Travis badge updated to own fork's
  • Coveralls badge updated to own fork's (the link has extra https:// as prefix)

About Us Page

  • Updated with photos
  • Roles and components assigned (Could describe your individual roles more precisely)

Additional Stuffs

  • Try to give descriptive messages for your commits instead of leaving in empty or "no message". If you think it is very time consuming and not productive, then you should batch your changes and commit as a collective set of cohesive changes.

UG/DG feedback will be provided to you in the documents.

cchj1995 pushed a commit to cchj1995/addressbook-level4 that referenced this pull request Mar 11, 2019
@kthSim
Merge pull request nus-cs2103-AY1819S2#27 from cs2103-ay1819s2-w17-2/…
ad82c5f 
…documentation

Documentation
@kylase-learning
Copy link

kylase-learning commented Mar 22, 2019 •
edited
Loading

Please do fix your git setup as you can see from the commit history, it can't identify correct the author of the commit as one of you.

This will affect the ability of RepoSense to detect your contribution.

0blivious and others added 21 commits March 29, 2019 10:13
@0blivious
Merge pull request #89 from Miaaaaa97/pr/12
73f15d3 
Pr/12
update to show review of a certain book when click
4294547
style fix
f85e09b
@0blivious
Merge pull request #90 from 0blivious/master
8d8af68 
update to show review of a certain book when click
@EleenYang
update sample data
6e443a5
@EleenYang
Merge branch 'master' into master
b7d2e1a
@0blivious
Merge pull request #91 from EleenYang/master
b4d3920 
update sample data
update systemtest to reflect selectbook
23e7a5a
EOF
48617c3
style fix
e6cdb5a
style fix
c3bb9c7
@0blivious
Merge pull request #92 from 0blivious/master
cc7d299 
update systemtest to reflect selectbook
@0blivious
Update README.adoc
e32891e
@0blivious
Update README.adoc
3368932
@0blivious
Update README.adoc
6be42a8
@0blivious
Update README.adoc
9342bb9
@r4venz
Merge pull request #13 from cs2103-ay1819s2-w11-4/master
710168c 
190330
@r4venz
Model Tests:
f26b06e 
1. ReviewTest
2. UniqueReviewListTest
3. ReviewBookNameContainsExactKeywordsPredicateTest
@r4venz
Parser Tests:
379bce7 
4. AddReviewCommandParserTest
5. DeleteReviewCommandParserTest
6. ListReviewCommandParserTest
@r4venz
SelectReviewCommand, parser, and relevant tests
acce21b
@r4venz
Fixed config.json missing line feed at EOF problem
89ad3b5
0blivious and others added 30 commits April 15, 2019 17:44
crop image
7e935d7
updage DG
0aaa17e
style fix
ec782fe
@0blivious
Merge pull request #160 from 0blivious/master
f6c2f56 
update DG
@LearnToRunFast
update docs
b1e7731
@LearnToRunFast
Merge pull request #161 from jiangqinhua/master
faf821b 
update docs
@LearnToRunFast
Update DeveloperGuide.adoc
7675233
@LearnToRunFast
Update DeveloperGuide.adoc
7bd0266
@LearnToRunFast
Merge pull request #162 from jiangqinhua/master
f99f70d 
update docs
@LearnToRunFast
Update jiangqinhua.adoc
3e736aa
@LearnToRunFast
Merge pull request #163 from jiangqinhua/master
a0bf43d 
Update jiangqinhua.adoc
@LearnToRunFast
Revert "Update jiangqinhua.adoc"
aeecb08
update UG
12b5331
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w11-4/main
9ee4d56
@LearnToRunFast
add demo pic
11e6926
@LearnToRunFast
Merge pull request #165 from jiangqinhua/master
9090708 
add demo pic
@LearnToRunFast
Merge pull request #164 from cs2103-ay1819s2-w11-4/revert-163-master
86340bc 
Revert "Update jiangqinhua.adoc"
@EleenYang
update diagrams
d88f4de
@EleenYang
Merge pull request #166 from EleenYang/master
e4c0a13 
update diagrams
update UG and minor bug fix
5b213bb
fix
fb9b124
@0blivious
Merge pull request #167 from 0blivious/master
578d239 
update UG
fix
dcf80f4
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w11-4/main
eb454f1
fix
7d740da
@r4venz
Merge pull request #21 from cs2103-ay1819s2-w11-4/master
ee63866 
merge
@r4venz
Update DG
006c961
change tag
5b90a89
@r4venz
Update UG
01dc81d
@r4venz
Merge pull request #168 from Miaaaaa97/master
f287c33 
Update DG Diagram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylase-learning kylase-learning Awaiting requested review from kylase-learning

Assignees

@kylase-learning kylase-learning

Labels
V1.1-Reviewed V1.2-Reviewed W11-4 W11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0blivious @kylase-learning @nus-se-pr-bot @EleenYang @r4venz @LearnToRunFast