[W17-1] The Food Diary #38

rbth7e5 · 2019-02-19T13:52:58Z

No description provided.

sharan8

Hi team, some comments:

Do standardise the name of your application.
Do fill in the responsibilities of each member in the 'About Us' page as well.
Remember to update the comments as well when reusing/adapting existing code.
Do make the stated update to your README.adoc with regards to the build status badge(s).

Comments on your User and Developer Guides will be provided separately (likely as annotated PDFs on Luminus).

Looks like the groundwork for the project has been laid (renaming AB to FD, adding in some commands, classes and updating the parsers). Do keep up the work and remember to update your guides/UI image as you go along. 👍

sharan8 · 2019-03-09T13:09:19Z

docs/AboutUs.adoc

-_{The dummy content given below serves as a placeholder to be used by future forks of the project.}_ +
-{empty} +
-We are a team based in the http://www.comp.nus.edu.sg[School of Computing, National University of Singapore].
+EatVago is a desktop food diary application. This is adapted and modified from Address Book Level 4


Do try to standardise the name of the application across the docs.

sharan8 · 2019-03-09T13:10:16Z

docs/AboutUs.adoc

-Role: Team Lead +
-Responsibilities: UI
+Role: Developer, Team Carry +
+Responsibilities:


Do fill in the responsibilities assigned to each member as well.

sharan8 · 2019-03-09T13:21:23Z

src/main/java/seedu/address/logic/commands/AddNameCommand.java

+
+    public static final String COMMAND_WORD = "addName";
+
+    public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a names to your profile "


name* might be more appropriate here

sharan8 · 2019-03-09T13:29:23Z

src/main/java/seedu/address/logic/commands/AddReviewCommand.java

+            + "diary.\n"
+            + "Parameters: "
+            + "INDEX (Must be a positive integer) "
+            + PREFIX_REVIEWENTRY + "REVIEW "


Could be more consistent with the case here

sharan8 · 2019-03-10T09:47:55Z

src/main/java/seedu/address/logic/parser/AddNameCommandParser.java

+import seedu.address.logic.parser.exceptions.ParseException;
+
+/**
+ * Parses input arguments and creates a new AddCommand object


Is an AddName or AddNameCommand object the intended creation here?

sharan8 · 2019-03-10T09:51:01Z

src/main/java/seedu/address/logic/commands/AddReviewCommand.java

+     * Creates a new Restaurant with the newly added specified {@code Review}
+     */
+    private static Restaurant createRestaurantWithNewReview(Restaurant restaurantReviewed, Review reviewToAdd) {
+        assert restaurantReviewed != null;


Good that you made use of an assert here

sharan8 · 2019-03-10T09:53:05Z

src/main/java/seedu/address/logic/parser/FoodDiaryParser.java

+        case AddReviewCommand.COMMAND_WORD:
+            return new AddReviewCommandParser().parse(arguments);
+
+


Take note of the extra line here

sharan8 · 2019-03-10T09:53:46Z

src/main/java/seedu/address/model/FoodDiary.java

+import seedu.address.model.restaurant.UniqueRestaurantList;
+
+/**
+ * Wraps all data at the address-book level


Remember to update this comment

sharan8 · 2019-03-10T10:06:05Z

src/main/java/seedu/address/model/UserPrefs.java

-    public void setAddressBookFilePath(Path addressBookFilePath) {
-        requireNonNull(addressBookFilePath);
-        this.addressBookFilePath = addressBookFilePath;
+    public void setName(String name) {


Just a gentle reminder that the application should be for a single user

This is just to allow the single user to change his name as he likes.

sharan8 · 2019-03-10T10:27:40Z

README.adoc

-https://ci.appveyor.com/project/damithc/addressbook-level4[image:https://ci.appveyor.com/api/projects/status/3boko2x2vr5cc3w2?svg=true[Build status]]
-https://coveralls.io/github/se-edu/addressbook-level4?branch=master[image:https://coveralls.io/repos/github/se-edu/addressbook-level4/badge.svg?branch=master[Coverage Status]]
-https://www.codacy.com/app/damith/addressbook-level4?utm_source=github.com&utm_medium=referral&utm_content=se-edu/addressbook-level4&utm_campaign=Badge_Grade[image:https://api.codacy.com/project/badge/Grade/fc0b7775cf7f4fdeaf08776f3d8e364a[Codacy Badge]]
+https://travis-ci.org/cs2103-ay1819s2-w17-1/main[image:https://travis-ci.org/cs2103-ay1819s2-w17-1/main.svg?branch=master["Build Status", link="https://travis-ci.org/cs2103-ay1819s2-w17-1/main"]]


Please update your badge(s) accordingly to ensure they point to the build status of your repo. Issue here is that your 'cs2103-ay1819s2-w17-1' has to be in uppercase.

sharan8

Hi team, some comments:

Good that you have updated the implementation details of your features in the Developer Guide. However, in addition to how the feature is implemented, do include details on why it is implemented that way, and what other alternatives you considered in the process.
You could try to make use of diagrams learnt in tutorials, code snippets etc. to elaborate on your implementation in the Developer Guide as well.
For the webpage feature, do carefully consider graceful handling of exceptions such as an unreachable weblink. You could brainstorm for ideas on managing such an event by going back to your intended target audience and value proposition.
Good that the User Guide has been updated with some features yet to come in future releases as well. Do remember to update them for all features as you go along.
Do furnish your User Guide with further details of your features (E.g. are duplicates allowed?).
Do note the recommended order of variables declared within your classes, based on the style guide (Depending on visibility).
Do try to be more consistent about the naming of your commits (E.g. all to make use of the imperative mood?).
For the upcoming milestone, do ensure your code is RepoSense compatible.

sharan8 · 2019-03-24T13:31:27Z

src/main/java/seedu/address/model/restaurant/Weblink.java

+    private static final String DOMAIN_FIRST_CHARACTER_REGEX = "[^\\W_]"; // alphanumeric characters except underscore
+    private static final String DOMAIN_MIDDLE_REGEX = "[a-zA-Z0-9.-]*"; // alphanumeric, period and hyphen
+    private static final String DOMAIN_LAST_CHARACTER_REGEX = "[^\\W_]$";
+    public static final String VALIDATION_REGEX = "^(http:\\/\\/|https:\\/\\/)" + LOCAL_PART_REGEX + "."


Do take note of the order for variables in the class, as suggested in the style guide.

Hi @sharan8, what if the public variable requires the private variables above it?

sharan8 · 2019-03-24T13:32:54Z

src/main/java/seedu/address/model/restaurant/Weblink.java

+    /**
+     * Constructs an {@code Weblink}.
+     *
+     * @param weblink A valid email address.


Are you expecting an email address or a web link here?

sharan8 · 2019-03-24T15:19:23Z

docs/DeveloperGuide.adoc

@@ -149,19 +149,19 @@ image::LogicClassDiagram.png[width="800"]
 The _Sequence Diagram_ below shows how the components interact with each other for the scenario where the user issues the command `delete 1`.

 .Component interactions for `delete 1` command
-image::SDforDeletePerson.png[width="800"]
+image::SDforDeleteRestaurant.png[width="800"]


Do update the sequence diagrams for your morphed product where relevant

sharan8 · 2019-03-27T14:37:45Z

src/main/resources/view/DarkTheme.css

@@ -121,7 +121,7 @@
 }

 .cell_big_label {
-    -fx-font-family: "Segoe UI Semibold";
+    -fx-font-family: "Segoe UI";


Hi @weixin-koh, just wanted to check which of these fields you're having problems manipulating. Changing the font family for .cell_big_label appears to work on my Mac. You might want to zero in on the font issue by checking if changing the font-size works as well.

Here's an external reference that I found with regards to integrating custom fonts - http://www.guigarage.com/2014/10/integrate-custom-fonts-javafx-application-using-css/

Hi @sharan8, the one that I was having problems manipulating is actually the CSS font-family field for the HTML files, more specifically for .cell_placeholder_web as the font would appear to be Times New Roman when I specified it as "Segoe UI Semibold". However, I followed the external reference you gave and it works now! Thank you :)

Just curious though, it seems that the CSS for HTML files require an import of the font, but how is JavaFX able to access all my local fonts without importing? (I changed the -fx-font-family in .cell_big_label to a custom font I downloaded and it worked without having to import the font in the CSS file)

Great that it works! @weixin-koh

I'm not entirely sure how it may be able to access or interpret local fonts, and it could be a font that's present in JavaFX itself as well (you can check this by running javafx.scene.text.Font.getFamilies();). Regardless, do confirm if the font works as expected on your team members' workstations too. I'm guessing embedding the font files directly under resources would be best.

Using web fonts is another alternative that introduces a dependency, but works - http://fxexperience.com/2012/12/use-webgoogle-fonts-in-javafx/

Yup I added the font file into the resources folder! I ran the line of code and it showed all of the fonts in my computer, so I think JavaFX just has a way to read in all your local fonts? Thanks so much for your help @sharan8!

…tReviewUtil which stores the constant strings for the default review entries

…cks for the command parser

…1 and 5 inclusive.

…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: fix typo in note callout shift user and dev guide logo down to welcome section add logos to intro page and PPP updated docs and sample data reviews commented qz tests ug, dg ppp of skpai27 edits removed phone and email to check if restaurant is equal since items are removed from the card if absent edited aboutUS page updated tests updated visitWeb error messages updated dg on manual testing updated weblink validation check added sample data w/o reviews # Conflicts: # docs/UserGuide.adoc

fix display error

…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: fix display error # Conflicts: # docs/UserGuide.adoc

Update docs

Edited documentation for ug, ppp of skpai27

…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: documentation ug, ppp changes updated UG added image to ppp update docs updated docs # Conflicts: # docs/UserGuide.adoc

updated test case and docs

…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: final updated doucments Update UserGuide.adoc updated docs updated grammar updated documents updated test case and docs # Conflicts: # docs/UserGuide.adoc

Minor edits to UG, DG and PPP

Edit DG

nus-se-pr-bot requested a review from sharan8 February 19, 2019 13:56

nus-se-pr-bot added the W17-1 label Feb 19, 2019

nus-se-pr-bot assigned sharan8 Feb 19, 2019

nus-se-pr-bot added the W17 label Feb 19, 2019

sharan8 reviewed Mar 10, 2019

View reviewed changes

sharan8 added the V1.1-Reviewed label Mar 10, 2019

rbth7e5 mentioned this pull request Mar 12, 2019

Fix issues mentioned by Tutor for v1.1 release CS2103-AY1819S2-W17-1/main#60

Closed

sharan8 reviewed Mar 24, 2019

View reviewed changes

sharan8 reviewed Mar 27, 2019

View reviewed changes

rbth7e5 and others added 21 commits April 6, 2019 22:39

add break to switch statement

7404513

implement filtering on autocomplete context menu

04c5fde

add defensive coding stuff

c7b0307

fix spaces triggering autocomplete

85634a6

update docs

8d509a1

fix activity diagram error

54880f5

Fix display of added/edited/deleted review

4936f91

update developer guide with autocomplete

8bd2bdc

Add SortCommand to sort Restaurants by avgRatings

a1e210c

fixed some minor comment errors in AddReviewCommand

2c57a22

created and implemented AddDefaultReviewCommand class, also AddDefaul…

419cf8a

…tReviewUtil which stores the constant strings for the default review entries

implementation of the AddDefaultReviewUtil class

fa594fa

implemented AddDefaultReviewCommandParser class

9b2d958

Added the addDefaultReview into FoodDiaryParser, also implemented che…

a3df8a5

…cks for the command parser

added a check to ensure that defaultReview index provided is between …

971f06d

…1 and 5 inclusive.

Added unit tests for AddDefaultReviewCommandParser

76bf7b9

allow edit of only openinghours field

1c28fcf

Merge branch 'editBug' into browserWindow

a49667a

modified FoodDiaryParserTest to account for AddDefaultReviewCommand

810b758

added javadocs on browser panel

3538904

edited variable order

4c0f711

chanqingzhou and others added 30 commits April 15, 2019 21:19

updated documents

5c67d39

update docs

6fe9bda

updated grammar

e9df3e2

added image to ppp

89bece4

merge

9c9cac8

Make changes to UG/DG and shorten PPP

9894ceb

fix display error

646559a

updated UG

b1423e6

Grammar fix to UG and add undo/redo commands

f5b9d29

Merge pull request #169 from rbth7e5/docs

bde8ead

fix display error

Merge branch 'master' of https://github.com/cs2103-ay1819s2-w17-1/main …

8110f3d

…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: fix display error # Conflicts: # docs/UserGuide.adoc

Merge pull request #168 from Wklee96/sampledata

23a34d4

Update docs

updated docs

19f9555

documentation ug, ppp changes

a332dee

Update UserGuide.adoc

9af440f

Merge pull request #170 from skpai27/docEdits

73b7d2f

Edited documentation for ug, ppp of skpai27

final updated doucments

00abb38

Merge branch 'master' into v1.4

11c05a4

Minor tweaks to DG and PPP

a1f4463

Merge branch 'master' of https://github.com/cs2103-ay1819s2-w17-1/main …

038b7b8

…into sortByRatings * 'master' of https://github.com/cs2103-ay1819s2-w17-1/main: documentation ug, ppp changes updated UG added image to ppp update docs updated docs # Conflicts: # docs/UserGuide.adoc

updated style

26bae57

update style

352af5b

Merge pull request #167 from chanqingzhou/v1.4

47d46c1

updated test case and docs

Merge pull request #171 from weixin-koh/sortByRatings

54ae957

Minor edits to UG, DG and PPP

Edit DG

c378933

Fix checkstyle

439458f

Fix checkstyle

4c57ee1

Merge pull request #173 from weixin-koh/sortByRatings

d10eb97

Edit DG

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[W17-1] The Food Diary #38

[W17-1] The Food Diary #38

rbth7e5 commented Feb 19, 2019

sharan8 left a comment

sharan8 Mar 9, 2019

sharan8 Mar 9, 2019

sharan8 Mar 9, 2019

sharan8 Mar 9, 2019

sharan8 Mar 10, 2019

sharan8 Mar 10, 2019

sharan8 Mar 10, 2019

sharan8 Mar 10, 2019

sharan8 Mar 10, 2019

rbth7e5 Mar 19, 2019

sharan8 Mar 10, 2019

sharan8 left a comment

sharan8 Mar 24, 2019

Wklee96 Apr 1, 2019

sharan8 Mar 24, 2019

sharan8 Mar 24, 2019

sharan8 Mar 27, 2019

weixin-koh Mar 28, 2019

sharan8 Mar 28, 2019

weixin-koh Mar 28, 2019


		public static final String COMMAND_WORD = "addName";

		public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a names to your profile "

		case AddReviewCommand.COMMAND_WORD:
		return new AddReviewCommandParser().parse(arguments);

[W17-1] The Food Diary #38

Are you sure you want to change the base?

[W17-1] The Food Diary #38

Conversation

rbth7e5 commented Feb 19, 2019

sharan8 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sharan8 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment