Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W13-2] ClubManager #45

Open
wants to merge 679 commits into
base: master
Choose a base branch
from

Conversation

joel0111
Copy link

Copy link

@tristonpang tristonpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for v1.1. Good job everyone! I do not see any outstanding issues, but do take note of the following:

README Landing Page
You need to acknowledge that the source code is from AB4 in your acknowledgements section in the README landing page.

Developer Guide
Perhaps try to make your target user profile more specific in your product scope (to the club management context, e.g. What contacts/events is the user going to want to manage through the app? What responsibilities does your user hope to fulfill by using your app?), as the current target user profile looks a bit too generic.

Copy link

@tristonpang tristonpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort everyone. Make sure your jar file is ready for an informal demo during tutorial. Also note that there may be some issue with the image formatting, as seen below:
image

Also consider leaving the subpoints in your user guide content page e.g. 3.2.1, 3.2.2, etc, for easier reference for the user
image

joel0111 and others added 30 commits April 15, 2019 22:49
Updated User Guide and Developer Guide
Add manual testing instructions
Updated Developer for Appendix Manual Testing
# Conflicts:
#	docs/DeveloperGuide.adoc
Adding DG contribution to PPP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants