-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W13-2] ClubManager #45
base: master
Are you sure you want to change the base?
[W13-2] ClubManager #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for v1.1. Good job everyone! I do not see any outstanding issues, but do take note of the following:
README Landing Page
You need to acknowledge that the source code is from AB4 in your acknowledgements section in the README landing page.
Developer Guide
Perhaps try to make your target user profile more specific in your product scope (to the club management context, e.g. What contacts/events is the user going to want to manage through the app? What responsibilities does your user hope to fulfill by using your app?), as the current target user profile looks a bit too generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member mid v1.4
Added some tests and update document for activityAdd
fix merge conflict
fix activity conflict with master
Activity mid 1.4
Fix merge conflict
Remove redundant functions
updated userguide
Update UI and Sample Data with attending list
Updated User Guide and Developer Guide
…into manual_test_mel
Fixed bugs
manual testing mel's part
Add manual testing instructions
Updated Developer for Appendix Manual Testing
# Conflicts: # docs/DeveloperGuide.adoc
Adding DG contribution to PPP
edit tags on dg
All the best
@A0143487X-Kevin @minernchan @ivyyangyq @melkwx @joel0111