Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T12-2] Acquizition #48

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

[T12-2] Acquizition #48

wants to merge 47 commits into from

Conversation

sergiovieri
Copy link

@lucatriglia
Update AboutUs and ContactUs info (#1)
d1532b7 
* docs: update AboutUs info

* docs: update ContactUs info

* docs/AboutUs: fix image name

* docs: add project portfolio page for each member
Update Readme badges (#3)
2ca9393 
* readme: update travis and codacy badges

* readme: update coveralls badge
bqnguyen94
bqnguyen94 reviewed Feb 25, 2019
View reviewed changes
Copy link

@bqnguyen94 bqnguyen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you have set up the repository and started working on your project 👍

README.adoc Outdated Show resolved Hide resolved
README.adoc Show resolved Hide resolved
lucatriglia and others added 23 commits February 28, 2019 15:43
@lucatriglia
Update About us (#10)
134bc2d 
* docs: update AboutUs info

* docs: update ContactUs info

* docs/AboutUs: fix image name

* docs: add project portfolio page for each member

* AboutUs: fix portfolio links
@sergiovieri @lucatriglia
Update Readme (#4)
771d103 
* readme: add appveyor badge

* README.adoc: Change app name to Acquizition

* Update README.adoc

* Update UI image

* Update README.adoc to include reference to se-edu
@lungsin
Update user guide (#6)
463b165 
* add Introduction and description for add command

* change docs for list command

* docs/UserGuide.adoc: edit command

* docs/UserGuide.adoc: fix format + docs for find command

* docs/UserGuide.adoc: add docs for delete command

* docs/UserGuide.adoc: add coming in future work for undo, redo, select, history

* docs/UserGuide.adoc: add docs for quiz mode

* docs/UserGuide.adoc: add docs for stats

* docs/UserGuide.adoc: make 'coming soon' tag shorter

* docs/UserGuide.adoc: remove select command, restructure the order of undo and redo

* docs/UserGuide.adoc: refactor  to

* docs/UserGuide.adoc: fix typos and edit quick start

* docs/UserGuide.adoc: fix typos and change  section

* docs/UserGuide.adoc: change features section to be more consistent with other commands

* docs/UserGuide.adoc: change command summary
@lucatriglia
[WIP] Add Upload Functionality (#12)
7597747 
* Add upload command

* docs/UserGuide.adoc: update user guide to include upload command

* docs/ContactUs.adoc: fix link for issue tracker

* docs/UserGuide: include information about the user guide

* commands/UploadCommand: add newline for message usage
@sergiovieri
Add simple quiz mode (#8)
32dac15 
* Add Quiz command class

* Fix checkstyle errors

* Change browser panel to card view panel

* Random quiz card view

* test: remove broswer from test

* Fix styles

* test: Comment out close help test

* Remove browserPanel test
@lungsin @sergiovieri
Add use cases for developer guide (#16)
dcef26b 
* Docs: add use cases for edit, add, delete

* docs: add use cases for quiz mode

* docs: add use cases for find

* docs: add use cases for import and export cards

* change asciidoc attribute

* change team name from SE-EDU to T12-2
@lucatriglia @lungsin
docs/DeveloperGuide: update user stories (#17)
2f90625
@sergiovieri @lungsin
readme: Update travis repository name (#18)
be0a03f
@robincyu @sergiovieri
Refactor AddressBook to CardCollection, Person to Flashcard (#14)
9210de6 
* Refactor AddressBook to CardCollection

* Fix code style

* Refactor Person to Flashcard

* Continue refactoring

* Fix code style

* Fix minor codestyle errors

* LICENSE: Revert flashcard -> person
@sergiovieri
README: Update badge repository name (#23)
0cd7e4c
@sergiovieri @lungsin
Refactor Flashcard Fields (#22)
7f8053b 
* Add Face class

* Fix fxml imports

* Remove browser panel code and tests

* Change flash card fields to front face and back face

* Complete EditCommandTest

* Complete EditCommandSystemTest

* Complete CardCollectionTest

* Complete JsonAdapted tests

* Complete ModelManagerTest

* Complete VersionedCardCollectionTest

* Finish all tests

* Fix imports

* Remove all unused Flashcard field classes
@lungsin @sergiovieri
Add statistics functionality (#13)
149d68c 
* Logic: teach the app to accept 'stats' command which does nothing

* Refactor: getTypicalAddressBook -> getTypicalCardCollection

* Add Statistics class and test

* StatisticsTest: add test on merge method

* Model: add json validation in Person, add field Statistics in Person

* Logic: Statistics functionality

Currently, command `stats` will display the success rate of quiz mode of
all flashcards.

* Test: change the placeholder test for StatsCommand

* Storage: add a field in JSON + adapt the test accordingly
@sergiovieri @lungsin
Modify Flashcard Card View (#27)
58dcc18 
* Refactor FlashcardCard to FlashcardListCard to avoid ambiguity

* Add FlashcardCardView and change the CardViewPanel to use it

* Add FlashcardCardView tests

* Modify card view and remove primary stage decoration

* Modify card view to use separate panes
@lucatriglia @sergiovieri
Enhance Find Command (#29)
ebfb89a 
* Enhance Find Command

* model/flashcard: Add KeywordsPredicate

* logic/parser: Update Find Command Parsing

* logic/commands: Update Commands for Find

* docs/UserGuide: Update UG to include enhanced find

* Update tests for enhanced find command

* Update Developer Guide to include find command implementation
@sergiovieri
Add quiz command to developer guide (#30)
d5d266b 
* Add quiz command to developer guide

* DeveloperGuide: Add quiz mode design considerations
@lungsin
Add Statistics section in developer guide (#36)
55a9d00 
* Add Statistics section in developer guide
@robincyu @lungsin
Add Image Support to DeveloperGuide.adoc (#38)
c0d1085
@sergiovieri @lungsin
Reposense: Add config.json (#39)
95a4ef4
@lungsin @sergiovieri
Implement Filtered statistics (#40)
710df51 
* Logic: add filter functionality to statsCommand

* Test: add test for StatsCommandParser

* FindCommand.java: Fix MESSAGE_USAGE

* Tests: add test for stats command with predicate

* Bug Fix: fix equals method of FlashcardContainsKeywordsPredicate

* Test: add more tests

* Tests: add stats command parser test and TODO
@lungsin @sergiovieri
Rename _reponense -> _reposense (#42)
12b77ff
@sergiovieri
Advanced Quiz Mode (#46)
f1658af 
- Quiz mode that sorts cards by statistics

- Quiz panel that contains cards remaining, number of good and bad feedback

- User feedback through GoodCommand, BadCommand

- ShowCommand to show the back face of a card during quiz mode

- SmartCommand that executes ShowCommand if back face is not yet shown, or GoodCommand if back face is already shown

* Add quiz mode property to relevant places

* ExitCommand: If now is quiz mode, exit from quiz mode.
Otherwise, exit as normal.

* Hide flashcard list view on quiz mode

* Add user feedback on quiz mode, and quiz mode now shuffles cards

* Add quiz mode panel

* Add show command and modify some quiz behaviours

* Add smart command

* QuizPanel: Add good/bad button

* Quiz: Add current quiz statistics

* Add all new class tests

* QuizMode: Update statistics on user feedback

* Quiz: Commit model on user feedback

* Bump version to 1.3

* Fix selection bugs and inconsistencies

* Quiz: Refactor magic constants to QuizState
@lucatriglia @lungsin
Share command Implementation (#43)
6f3cf95 
* Add share command implementation

* FlashcardContainsKeywordsPredicate: Fix equals method bug

* tests: Test find command Implementation and parser

* docs/UserGuide.adoc: update UG to include share command

* Update Share Command
@sergiovieri @robincyu
Add Toolbar (#49)
8f721e3 
* Add toolbar

* Fix style

* Add acquizition label to toolbar and adjust various sizes

* Add acquizition icon

* Change cards remaining label when 1 remaining card

* Add toolbar tests

* QuizPanel: Add JavaDoc

* Disallow non-quiz commands in quiz mode

* AddCommandTest: Support quiz mode

* Add UploadCommandTest and ShareCommandTest

* ShareCommand: Fix path resolution
robincyu and others added 7 commits April 3, 2019 20:14
@robincyu @sergiovieri
Image support (#50)
dad40cf 
* Add placeholder image support

* Add proper image support

* Allow image removal by specifying empty i/ tag

* Add image command which allows importing of images into Acquizition

* Add tests for ImageCommand

* Add required space in Messages.java

* FlashcardCardView: Restore shade
@lucatriglia @sergiovieri
Import Command (#53)
b85685c 
* Update upload command to import command
@sergiovieri @robincyu
UserGuide: Update quiz mode (#52)
7f05ba0 
* UserGuide: Update quiz mode

* UserGuide: Add good and bad command

* UserGuide: Add show command

* UserGuide: Add smart command

* Add quiz ui image

* Add ui quiz screenshot and fix card view color

* UserGuide: Add quiz ui

* UserGuide: Fix unclosed tag
@robincyu
Update User Guide to v1.3 (#54)
74d0015 
* UserGuide: Update quiz mode

* UserGuide: Add good and bad command

* UserGuide: Add show command

* UserGuide: Add smart command

* Add quiz ui image

* Add ui quiz screenshot and fix card view color

* UserGuide: Add quiz ui

* UserGuide: Fix unclosed tag

* Update User Guide

* Add newline to UG
@sergiovieri @robincyu
ImageCommand Fix (#56)
8bc9f9c 
* ImageCommand: Fix image directory creation

* FlashcardCardView: Fix overflow ellipsis to wrap text
@sergiovieri @lungsin
UserGuide: Add missing commands and command summary (#57)
38a0271 
* UserGuide: Add select command

* UserGuide: Add list command

* UserGuide: Add history command

* UserGuide: Add undo and redo commands

* UserGuide: Add command summary

* UserGuide: Add redo command

* UserGuide: Add quiz and command summary tags
@lungsin @sergiovieri
Refactor filter (#81)
9745691 
* Refactor: move filter part of FindCommandParser and StatsCommandParser to ParserUtil::filterByKeyword

* Logic: filter backface or frontface by substring instead of word matching

* Logic: list on empty flashcards will display other message

* Tests: modify test, command is not case sensitive
radhika-lakhtakia pushed a commit to radhika-lakhtakia/addressbook-level4 that referenced this pull request Apr 12, 2019
@chuaes
Merge pull request nus-cs2103-AY1819S2#48 from chuaes/master
a47ac42 
Update aboutUs page with our team info
sergiovieri and others added 15 commits April 14, 2019 12:22
@sergiovieri @lungsin
Change app icon (#87)
979f02f
@sergiovieri
Developer Guide: Refactor existing commands and diagrams (#89)
0986ba0 
* Modify architecture diagram

* Modify some class diagrams

* Remove encryption and add quiz sequence diagram pptx

* Modify undo redo diagrams

* Remove forking notes
@lungsin @sergiovieri
Spaced Repetition System and Review mode (#86)
75d9240 
* Model: add proficiency

* Storage: integrate with flashcard

* Model: Proficiency now has inactive period field

* Model: Review mode in quiz

* UI: add is review mode in the UI

* Logic: add SRS mode to quiz

* Logic: Review mode will still update the statistics

* Test: add unit test for QuizCommand and its parser

* Test: add system tests for QuizCommand

* Epic: History does not accept empty string, Undo Redo provide command description

* Storage: After quiz is done, commit the result

* Make statistics and proficiency final

* Bug: click on flashcard list will print directly to resultBox

* Tests: Proficiency and statistics tests

* UI: Select with clicking

* Fix comand history bug and change theme
@robincyu @sergiovieri
Image support fixes (#92)
89a0ee8 
* Fix issues related to image support and other minor grammar issues with other commands

* Fix Image Command showing full path instead of file name

* Fix black background color of list view when filtered
@lucatriglia @lungsin
Update FindCommand to filter by success rate (#85)
f3ad645 
* Logic: Update FindCommand to filter by success rate

* Tests: Add tests for find, import, share command

* Docs: Update UG and DG

* Docs: Add PPP

* Docs: Update lucatriglia.adoc
@sergiovieri @lungsin
DeveloperGuide: Quiz Mode (#93)
9d98080 
* Remove hand cursor from good in quiz panel

* Add quiz, show, good/bad, exit diagrams and explanations

* Change design considerations to use bullet points
@lungsin @sergiovieri
Selecting flashcard display date until its use in quiz (#91)
99fb17f 
* Epic: now selecting card can see the time left until activation

* Test: add one more case

* Logic: change message to 'in quiz status'
@robincyu @sergiovieri
Complete Rewrite of User Guide: Robin's and Neutral Features (#95)
431ca94 
* Comprehensive User Guide edits

* More changes to User Guide
@sergiovieri
Docs: Add PPP - Sergio Vieri (#59)
3505e52 
* Docs: Add sergio vieri PPP

* Fix exit quiz sequence diagram arrow color

* Fix user guide typo, add link to reposense in PPP, and replace old screenshots

* Add image and intro to PPP
@robincyu @sergiovieri
Developer Guide: Robin's Features (#97)
a0bdb50 
* Developer guide changes

* Add tags to User Guide

* Fix quiz User Guide
@sergiovieri
Remove use cases from PPP (#98)
91560f1
@lungsin @sergiovieri
Docs srs stats (#94)
671fa0b 
* Docs: developer guide undo redo

* add Proficiency in model class diagram

* docs: dev guide for SRS and Stats

* Docs: add diagram for StatsCommand
@sergiovieri
Quiz Fix (#100)
0512f3c 
Quiz Fix
@robincyu @sergiovieri
Add Robin's PPP (#99)
a1062f4
@lucatriglia
Update AboutUs.adoc (#101)
391b693 
* Update AboutUs.adoc

* Delete lucatriglia.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bqnguyen94 bqnguyen94 bqnguyen94 left review comments

Assignees

@bqnguyen94 bqnguyen94

Labels
T12-2 T12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergiovieri @bqnguyen94 @nus-se-pr-bot @lucatriglia @lungsin @robincyu