forked from se-edu/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W16-3] Marketing Morph #68
Open
roanurquhart
wants to merge
447
commits into
nus-cs2103-AY1819S2:master
Choose a base branch
from
CS2103-AY1819S2-W16-3:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[W16-3] Marketing Morph #68
roanurquhart
wants to merge
447
commits into
nus-cs2103-AY1819S2:master
from
CS2103-AY1819S2-W16-3:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lestertj
reviewed
Mar 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub project page
- Please update the link at the top of your GitHub page
Readme Page
- The site doesn't seem to be linked correctly; can you make your repo name uppercase? Comments from this point forth will be based on your .adoc files.
- Please update your UI mockup to a computer-drawn version.
- Point your Travis CI build badge to your repo, not S-EDU addressbook
About Us
- Fill in your development responsibilities (components/roles)
- Check that all your photos are showing up correctly (no 404)
You will be receiving your UG and DG comments separately.
cchj1995
pushed a commit
to cchj1995/addressbook-level4
that referenced
this pull request
Mar 25, 2019
…entation Updated UserGuide.adoc
Can view total contacts in status bar
Fixed checkstyle
Updated UG, Ui.png
Finished Implementing Company
Fixed Checkstyle
Fixed Style Again
Added boilerplate for CompanyListPanel
checkstyle
Update DG
add documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkhiani
@FanDongzhe
@ZhangJiayu0303