[CS2103T-T12-1] +Work #110

seahlynn · 2019-10-01T06:13:12Z

@ArunBeCoding
@elsakoh
@gabrielseow
@ambhinav

SimNee · 2019-10-03T05:36:07Z

docs/DeveloperGuide.adoc


-|`* * *` |user |delete a person |remove entries that I no longer need
+|`* * *` |project leader |change task status | ger reminder of the progress of each task


Small spelling error here

SimNee · 2019-10-03T05:38:20Z

docs/DeveloperGuide.adoc


-|`* * *` |user |find a person by name |locate details of persons without having to go through the entire list
+|`* * *` |project leader |sync team members schedules |Find a time slot where the maximum number of people, if not all, can attend


The capitalisation should be consistent. "find" is capitalise but before that is not

SimNee · 2019-10-03T05:41:47Z

docs/DeveloperGuide.adoc


-|`* *` |user |hide <<private-contact-detail,private contact details>> by default |minimize chance of someone else seeing them by accident
+|`* *`|Project leader with frequent meetings|Create a new meeting with recommended time and desired location|View my next meeting in the home page


Probably can split the function and benefit into 2 user stories since it does not seems to match.
As a project leader, I want to create meeting so that I can secure the meeting slot at my desired time and place.
As a project leader, I want to view my next meeting in the homepage so that I know my schedule at a glance.

SimNee · 2019-10-03T05:43:38Z

docs/DeveloperGuide.adoc

+
+|`*`|Project leader with a long-term project with ad-hoc members|Change members working on a task|Reassign tasks to incoming members
+
+|`*`|Project leader operating keeping track of purchases|Tag the inventory purchase to the member who bought it|Produce an accurate claims report at the end of the project


"Project leader operating keeping track of purchases" I don't seem to understand this. Could you rephrase it in a better way?

SimNee · 2019-10-03T05:45:00Z

docs/DeveloperGuide.adoc

 * prefers typing over mouse input
 * is reasonably comfortable using CLI apps

-*Value proposition*: manage contacts faster than a typical mouse/GUI driven app
+*Value proposition*: manage tasks assigned to project mates, finding common time slots and keep track of inventory faster than GUI apps.

 [appendix]
 == User Stories


Generally well structured and have all 3 parts present

SimNee · 2019-10-03T05:47:36Z

docs/DeveloperGuide.adoc


-|`*` |user with many persons in the address book |sort persons by name |locate a person easily
 |=======================================================================


Did not really talk about the other type of users for this project. For example, project leader can assign tasks but did not talk about if the teammates can see the tasks

SimNee · 2019-10-03T05:56:33Z

docs/DeveloperGuide.adoc

+3. The given index is invalid.
+4. +work shoes an error message
+
+Use case resumes at step 2

 [appendix]
 == Non Functional Requirements


Are the NFRs are really Non-Functional?

Yes because it is not related to any function. They are function requirements related to performance, user-friendliness.

Is each NFR well-defined (i.e., possible to decide when it has been met)?

NFR 1 is a well-defined NFR, but very generic

NFR 2: it is ambiguous as to what ‘noticeable sluggishness’ means. How many seconds/milliseconds of lag would it be before we notice the sluggishness?

NFR 3: it is a measurable NFR. Since the wording is ‘accomplish most of the tasks faster using commands’, are there any specific tasks where it would take longer to accomplish?

Other feedback: the NFRs are quite generic, and not specific to the application.

Is each NFR reasonably achievable?

NFRs are reasonably achievable

Are more relevant NFRs have been left out?

Left out NFRs related to security. A possible NFR would be: only team leader can change the allocation of tasks to team members.

iskandarzulkarnaien

Good work in general! However there are formatting issues with use cases. Please refer to this

iskandarzulkarnaien · 2019-10-03T05:36:47Z

docs/DeveloperGuide.adoc

+2. The user does not specify name
+3. +work shows an error message


Numbering format is wrong. Should start from the step number where the extension occurs. Refer to this.

iskandarzulkarnaien · 2019-10-03T05:37:49Z

docs/DeveloperGuide.adoc

+2. The list is empty
 +
-Use case resumes at step 2.
+Use case ends


I think it would be better to have the system feedback to the user that the list is empty instead of simply terminating

iskandarzulkarnaien · 2019-10-03T05:40:54Z

docs/DeveloperGuide.adoc

+*Main Success Scenario*

-1.  User requests to list persons
-2.  AddressBook shows a list of persons
-3.  User requests to delete a specific person in the list
-4.  AddressBook deletes the person
+1. User requests to add a team member
+2. User specifies the name of the team member


This seems to be that at step 1, the user types in the command, then +Work waits for the user to type in the name of the team member. May I suggest adding a step in between where +Work notifies user to key in the name of team member

This applies for your other use cases too

Also, before use case ends, it may be good to notify the user that their action was successful.

iskandarzulkarnaien · 2019-10-03T05:41:51Z

docs/DeveloperGuide.adoc

+*Main Success Scenario*
+
+1. User requests to list team members
+2. +work displays list of team members


Seems like your app name is inconsistent in its capitalization. Some places have +work and others have +Work. Best to make it consistent.

iskandarzulkarnaien · 2019-10-03T05:44:41Z

docs/DeveloperGuide.adoc

+
+*Main Success Scenario*
+
+1. User requests to mark a task as ‘doing


Missing close inverted comma

iskandarzulkarnaien · 2019-10-03T05:47:02Z

docs/DeveloperGuide.adoc

+=== Use case:  Remove a task from the dashboard
+
+*Main Success Scenario*
+
+1. User requests to remove a task from the dashboard
+2. User specifies the task ID
+3. +work updates the dashboard
+
+Use case ends
+
+*Extensions*
+
+2. User specifies an invalid task ID
+3.  +work shows an error message
+
+Use case ends
+
+
+[discrete]
+=== Use case:  Remove a task from the dashboard
+
+*Main Success Scenario*
+
+1. User requests to remove a task from the dashboard
+2. User specifies the task ID
+3. +work updates the dashboard
+
+Use case ends


Seems to be duplicated by mistake

iskandarzulkarnaien · 2019-10-03T05:48:31Z

docs/DeveloperGuide.adoc

+1. User adds timetable of team mates
+2. User requests to generate availability timings of team members
+3. +work displays list of timings where the most number of team members are available


Same formatting issue here with extensions

weikiat97 · 2019-10-24T06:28:36Z

docs/DeveloperGuide.adoc

@@ -64,9 +63,9 @@ image::LogicClassDiagram.png[]
 [discrete]


Diagrams do not have updated class name (it is still named as AddressBookParser). I think the ProjectDashBoardParser should be connected to the XYZCommandParser in this case.

weikiat97 · 2019-10-24T06:34:03Z

docs/DeveloperGuide.adoc

@@ -98,9 +115,9 @@ image::LogicClassDiagram.png[]
 *API* :


The UI Component diagram is a bit difficult to understand. What are the functionalities of the UserView classes (Navigator / Controller / Main / Update)? Why is the UserViewMain connected to the Logic?

While the implementation may be unclear to us, the puml diagram is actually quite well done.

weikiat97 · 2019-10-24T06:46:16Z

docs/DeveloperGuide.adoc


 [[Design-Model]]
 === Model component

 .Structure of the Model Component
-image::ModelClassDiagram.png[]
+image::ModelClassDiagramNew.png[]


Could consider putting the name/price/taskStatus under the attributes of the main classes.
Tag is an association, not a composition. Might want to change the notation for the tag.

weikiat97 · 2019-10-24T06:46:56Z

docs/DeveloperGuide.adoc

 * does not depend on any of the other three components.

 [NOTE]
-As a more OOP model, we can store a `Tag` list in `Address Book`, which `Person` can reference. This would allow `Address Book` to only require one `Tag` object per unique `Tag`, instead of each `Person` needing their own `Tag` object. An example of how such a model may look like is given below. +
+As a more OOP model, we can store a `Tag` list in `Address Book`, which `Member` or 'Task' can reference. This would allow `Address Book` to only require one `Tag` object per unique `Tag`, instead of each `Member` or 'Task' needing their own `Tag` object. An example of how such a model may look like is given below. +


Don't forget to change the address books to your application! :)

weikiat97 · 2019-10-24T06:48:08Z

docs/DeveloperGuide.adoc

+Step 1. The user launches the application. The `ProjectCalendar` will be initialised based on the
+saved `ProjectCalendar`.
+
+Step 2. The user imports members' calendars by executing `impport-calendar`.


import (spelling error)

Fixed find command bug

# Conflicts: # src/main/java/seedu/address/ui/UserViewNavigator.java

Fixed find task UI

into abhinav-settings-feature

Fixed application exit bug

UG-Inventory

removed references to addressbook

Updated UG and DG

# Conflicts: # docs/DeveloperGuide.adoc

Added more sample memebrs

fix paste to command box not working

Giving credit

elsakoh-ppp-pdf

Finalise for v1.4

# Conflicts: # docs/team/elsakoh.pdf

Final UG and DG

added ppp

nus-se-pr-bot added tutor.junrong09 tutorial.CS2103T-T12 team.1 labels Oct 1, 2019

SimNee reviewed Oct 3, 2019

View reviewed changes

iskandarzulkarnaien reviewed Oct 3, 2019

View reviewed changes

weikiat97 reviewed Oct 24, 2019

View reviewed changes

ambhinav and others added 24 commits November 6, 2019 22:19

Merge pull request #157 from ambhinav/abhinav-settings-feature

19af92f

Fixed find command bug

update some command example usage

3001a46

Updated to fix find member

255df4b

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

4aba3e9

# Conflicts: # src/main/java/seedu/address/ui/UserViewNavigator.java

Fixed find task UI

a74ab88

Merge pull request #158 from seahlynn/master

a41cee0

Fixed find task UI

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

f4f553b

into abhinav-settings-feature

fix app shutdown bug

59f3ad4

Merge pull request #159 from ambhinav/abhinav-settings-feature

10e3f68

Fixed application exit bug

UG1

039bc09

Merge branch 'UG'

fa05e03

Merge pull request #161 from ArunBeCoding/master

915b83f

UG-Inventory

added unit tests for settings commands

a9f5bb8

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

064e150

Updated UG

7ed4046

removed instances of addressbook in packages

6afe134

Merge pull request #162 from elsakoh/master

710104c

removed references to addressbook

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

4e255f2

fix conflicts and merge

1d80597

fix package name change

f260dc6

fixed failing tests caused by package rename

1647d9e

optimise imports for project

bfd8242

rename-refactor some task commands

04eef26

added unit tests for settings in model

b22b24d

gabrielseow and others added 30 commits November 11, 2019 22:19

updated DG

e6d4af3

merged from team master

d734b53

Merge pull request #196 from gabrielseow/master

d278406

Updated UG and DG

Added more sample members

d43fb97

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

1ed4ec7

# Conflicts: # docs/DeveloperGuide.adoc

Merge pull request #197 from seahlynn/master

ce07828

Added more sample memebrs

change control to right arrow and ppp updates

821ba86

giving credit

224c3d7

removed a line

712e58d

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

cbafac5

ppp update

e810507

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

3135587

travis eof fix

1147785

Merge pull request #198 from elsakoh/master

07d42af

fix paste to command box not working

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

a44c4f7

Cleaning up ug and dg

9d35e47

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

8970a27

Merge pull request #199 from ambhinav/master

ec81291

Giving credit

ppp pdf

7cd0821

Merge pull request #200 from elsakoh/master

e99ae8d

elsakoh-ppp-pdf

fix tests

022c204

Updated UG and DG

8a44277

Merge pull request #201 from ambhinav/master

fc2c481

Finalise for v1.4

Merge branch 'master' of https://github.com/AY1920S1-CS2103T-T12-1/main

20c20ea

# Conflicts: # docs/team/elsakoh.pdf

Merge pull request #202 from seahlynn/master

68a76e9

Final UG and DG

added ppp

bbcc508

Merge pull request #203 from gabrielseow/master

dc5ac06

added ppp

Rename arunkumarr.adoc to ArunBeCoding.adoc

491f533

Delete arunkumarr.pdf

eeae5c9

Add files via upload

0a416a9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CS2103T-T12-1] +Work #110

[CS2103T-T12-1] +Work #110

seahlynn commented Oct 1, 2019

SimNee Oct 3, 2019

SimNee Oct 3, 2019

SimNee Oct 3, 2019

SimNee Oct 3, 2019

SimNee Oct 3, 2019

SimNee Oct 3, 2019

SimNee Oct 3, 2019

iskandarzulkarnaien left a comment

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

iskandarzulkarnaien Oct 3, 2019

weikiat97 Oct 24, 2019

weikiat97 Oct 24, 2019

weikiat97 Oct 24, 2019

weikiat97 Oct 24, 2019

weikiat97 Oct 24, 2019

weikiat97 Oct 24, 2019


		\|`* * *` \|user \|delete a person \|remove entries that I no longer need
		\|`* * *` \|project leader \|change task status \| ger reminder of the progress of each task


		\|`* * *` \|user \|find a person by name \|locate details of persons without having to go through the entire list
		\|`* * *` \|project leader \|sync team members schedules \|Find a time slot where the maximum number of people, if not all, can attend


		\|`* *` \|user \|hide <<private-contact-detail,private contact details>> by default \|minimize chance of someone else seeing them by accident
		\|`* *`\|Project leader with frequent meetings\|Create a new meeting with recommended time and desired location\|View my next meeting in the home page


		\|`*`\|Project leader with a long-term project with ad-hoc members\|Change members working on a task\|Reassign tasks to incoming members

		\|`*`\|Project leader operating keeping track of purchases\|Tag the inventory purchase to the member who bought it\|Produce an accurate claims report at the end of the project


		\|`*` \|user with many persons in the address book \|sort persons by name \|locate a person easily
		\|=======================================================================

		2. The user does not specify name
		3. +work shows an error message


		Main Success Scenario

		1. User requests to mark a task as ‘doing

[CS2103T-T12-1] +Work #110

Are you sure you want to change the base?

[CS2103T-T12-1] +Work #110

Conversation

seahlynn commented Oct 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iskandarzulkarnaien left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment