[CS2103T-W12-1] FinSec #142
Conversation
| FinSec *--> "1" UniqueClaimList | ||
| UniqueClaimList o--> "*" Claim | ||
| Claim *-left-> Id | ||
| Claim *-down-> Hidden |
There was a problem hiding this comment.
There are 3 pointers pointing to nothing :( Seems like a WIP but just take note
| @@ -0,0 +1,69 @@ | |||
| @startuml | |||
There was a problem hiding this comment.
There is an additional box appearing at the right side of the diagram
| !include style.puml | ||
|
|
||
| box Model MODEL_COLOR_T1 | ||
| participant ":ModelManager" as ModelManager MODEL_COLOR |
There was a problem hiding this comment.
This can be broken into smaller sequence diagrams as there are multiple actions within this diagram
| @@ -0,0 +1,87 @@ | |||
| @startuml | |||
There was a problem hiding this comment.
This can be broken into smaller sequence diagrams as there are multiple actions within this diagram
|
|
||
| Step 2. The user executes `delete 5` command to delete the 5th person in the address book. The `delete` command calls `Model#commitAddressBook()`, causing the modified state of the address book after the `delete 5` command executes to be saved in the `addressBookStateList`, and the `currentStatePointer` is shifted to the newly inserted address book state. | ||
| .Add Claim Command Sequence Diagram | ||
| image::AddClaimSequenceDiagram.png[] |
There was a problem hiding this comment.
The activation bar for AddClaimCommandParser exceeds the return for cmd arrow.
| *Step 6:* `AddIncomeCommand` would return a `CommandResult` to the `LogicManager` which would then be returned back to the user. | ||
|
|
||
| .Add Income Command Sequence Diagram | ||
| image::AddIncomeSequenceDiagram.png[] |
There was a problem hiding this comment.
This sequence is very similar to that of addClaim sequence diagram. Can consider removing it.
| 3) FinSecParser calls the CheckCommandParser::parse method. This instance of CheckCommandParser then takes in the rest of the string, | ||
| in this case: `1` + | ||
|
|
||
| * An `Index` instance is then created when the ParserUtil:parseIndex method is called. This method takes in the argument from the CheckCommandParser::parse method parameter |
There was a problem hiding this comment.
CheckCommandParser::parse should be highlighted
docs/DeveloperGuide.adoc
Outdated
|
|
||
| [source, java] | ||
|
|
||
| public CommandResult execute(Model model) throws CommandException { |
docs/DeveloperGuide.adoc
Outdated
|
|
||
| [source, java] | ||
|
|
||
| public CommandResult execute(Model model) throws CommandException { |
There was a problem hiding this comment.
Quite long. Is there a way to simplify it?
There was a problem hiding this comment.
- For section 1.4 Model Component, model class diagram has overlapping arrows and the number 1 and * above both claim and contact classes are too close to each other.
- The rest is very detailed and well done. Do remember to remove the remaining old address book stuff.
Check for travis
Update UG and DG
# Conflicts: # docs/UserGuide.adoc
Update UG and DG
Update UG and DG
Update UG and DG
Bug fixes
Checkstyle fixes
Updated DG
Update UG and acknowledge JFreeChart library
Doc update.
Updated link to PPP in AboutUs
PPP fixes
Finalise PPP
update names
Updated PPP and DG
No description provided.