[CS2103-F10-2] iFridge #90

kelvinnharris · 2019-09-26T18:11:47Z

@teika97 @zhangxuan97 @evelynejuliet @ManasVegi

hooncp · 2019-10-04T03:49:04Z

docs/DeveloperGuide.adoc

+
+|`* * *` |careless user |edit and delete items in shopping list |change details of or remove grocery items
+
+|`* * *` |user |add <<template,templates>> of grocery items |to keep track of what I want to have in my fridge


Good! Very reader friendly for developers to understand the terms.

hooncp · 2019-10-04T03:50:22Z

docs/DeveloperGuide.adoc

@@ -295,35 +297,127 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un
 [width="59%",cols="22%,<23%,<25%,<30%",options="header",]
 |=======================================================================
 |Priority |As a ... |I want to ... |So that I can...
-|`* * *` |new user |see usage instructions |refer to instructions when I forget how to use the App
+|`* * *` |organized user |add items to shopping list |decide the grocery items that I need to purchase later


You could consider scoping the users to be more specific.

hooncp · 2019-10-04T03:53:35Z

docs/DeveloperGuide.adoc

+
+|`* * *` |environmentally-conscious user |get feedback on how I am performing on my food waste management |improve my food waste management
+
+|`* *` |environmentally-conscious user |see which kinds of food I most commonly waste |cut down on unnecessary food waste


Can consider listing from most important requirements before moving to less important requirements

hooncp · 2019-10-04T03:55:32Z

docs/DeveloperGuide.adoc

+
+|`* * *` |user |view all groceries |know what to buy more of
+
+|`* * *` |user |remove a grocery |maintain only usable items in the fridge

 |`*` |user with many persons in the address book |sort persons by name |locate a person easily


Is this target user correct?

niqiukun · 2019-10-04T03:49:48Z

docs/DeveloperGuide.adoc


 [discrete]
-=== Use case: Delete person
+=== Use case: Add food item


It is recommended to label the use case as UCXX.

niqiukun · 2019-10-04T03:52:22Z

docs/DeveloperGuide.adoc

+[none]
+* 2a. The list is empty.
+
+Use case ends.


Should iFridge show that the list is empty and continue the use case at step 3?

niqiukun · 2019-10-04T03:54:10Z

docs/DeveloperGuide.adoc

-2.  AddressBook shows a list of persons
-3.  User requests to delete a specific person in the list
-4.  AddressBook deletes the person
+1.  User requests to list all food items


It might not be necessary to list all food items to add a new food item.

niqiukun · 2019-10-04T03:56:26Z

docs/DeveloperGuide.adoc

+1.  User requests to list grocery items
+2.  GroceryList shows a list of grocery items
+3.  User requests to delete a specific grocery item in the list
+4.  GroceryList deletes the person


niqiukun · 2019-10-04T03:56:55Z

docs/DeveloperGuide.adoc

+
+Use case ends.
+[none]
+** 3a1. iFridge shows an error message.


Extra line here

niqiukun · 2019-10-25T03:37:31Z

docs/DeveloperGuide.adoc

+
+The following sequence diagram shows how the edit template item operation works for the logic component:
+
+image::EditTemplateItemSequenceDiagram2.png[]


The diagram is similar to the previous diagrams. May be consider omitting some details and do a generalised one?

niqiukun · 2019-10-25T03:41:31Z

docs/DeveloperGuide.adoc

+=== Edit Template Item feature
+The edit template item mechanism is facilitated by `UniqueTemplateItems`, `TemplateList` and `TemplateToBeShown`.
+
+The `TemplateList` is an observable list of `UniqueTemplateItems` while the UniqueTemplateItems contains an observable list


It might be better to quote UniqueTemplateItems as UniqueTemplateItems.

niqiukun · 2019-10-25T03:43:54Z

docs/DeveloperGuide.adoc

+
+To edit the individual templates stored in the `TemplateList`, the command retrieves the template as well as the item to be edited.
+Retrieving the existing item allows for retrieval of unchanged data field. The template item at the specified index will then be
+overwritten with a new edited TemplateItem.


It might be better to quote TemplateItem as TemplateItem.

niqiukun · 2019-10-25T03:45:26Z

docs/DeveloperGuide.adoc

+
+image::WasteReportSequenceDiagram.png[]
+
+image::WasteReportSequenceDiagramRef.png[]


"Generating waste report" should be inside the sd tag.

niqiukun · 2019-10-25T03:49:58Z

docs/DeveloperGuide.adoc

+Aspect: How edit command is parsed
+
+* Alternative 1 (current choice): Create a separate parser just for template item management
+    * Pros: Easy to implement. Parser structure follows the same structure as the model. More OOP.


The bullet points can be better aligned.

Alternative 1

Pros

Cons

niqiukun · 2019-10-25T03:52:08Z

docs/DeveloperGuide.adoc

+    * Cons: Not as obvious to the user that both commands involve the same template list.
+
+
+The following sequence diagram shows how the edit template item operation works for the logic component:


Extra line here?

niqiukun · 2019-10-25T03:57:59Z

docs/DeveloperGuide.adoc

+
+The following sequence diagram shows how the edit template item operation works for the logic component:
+
+image::EditTemplateItemSequenceDiagram2.png[]


Should use result:CommandResult instead because result is passed back to LogicManager.

…ynejuliet/main into branch-add-undoshoppingtest

Add Test

… fix-bugs

Handle precision error

Edit UI

Fix UG

Fix Shopping Items in SampleDataUtil

…have same name

Add updateMapWithBoughtItems method

Fix minor bug

Update About Us

update command summary in UG

Correct the name of portfolio page for ManasVegi

Fix the link of PPP for ManasVegi

Fix PPP issue

nus-se-pr-bot added tutorial.CS2103-F10 team.2 tutor.cchj1995 labels Sep 26, 2019

kelvinnharris changed the title ~~[CS2103-F10-2] Food Orchestra~~ [CS2103-F10-2] iFridge Oct 3, 2019

hooncp reviewed Oct 4, 2019

View reviewed changes

niqiukun reviewed Oct 4, 2019

View reviewed changes

niqiukun reviewed Oct 25, 2019

View reviewed changes

ManasVegi and others added 20 commits November 8, 2019 01:44

Make MergeBoughtSequenceDiagram using plantUML

aa6f8a3

Merge branch 'master' into wk12-Documentation

1ae3e7d

Add Shopping Undo Command Test

d98c26f

Merge branch 'master' into branch-add-undoshoppingtest

70ce8fa

Add Reminder Command and Reminder Command Parser Test

9f3cc2e

Merge branch 'branch-add-undoshoppingtest' of https://github.com/evel…

7f68bbd

…ynejuliet/main into branch-add-undoshoppingtest

fix checkstyle

61acbb1

Add Shopping Redo Command Test

7ccbc35

Merge pull request #233 from evelynejuliet/branch-add-undoshoppingtest

9ea61d4

Add Test

Handle parsing of float with exponent

315a3dd

Resolve checkstyle violations

5bd05c7

Merge branch 'master' into fix-bugs

17e91d3

Merge branch 'fix-bugs' of https://github.com/kelvinnharris/main into…

0f223d4

… fix-bugs

Edit UI

fa17a77

Add tests for list waste command

6acd056

Add test for feedback waste command

d638f9f

Merge pull request #235 from kelvinnharris/fix-bugs

3d0ca85

Handle precision error

Merge branch 'master' into branch-edit-ui-2

b904594

Merge pull request #236 from evelynejuliet/branch-edit-ui-2

ec69720

Edit UI

Finish AddGroceryCommandTest

0c006af

ManasVegi and others added 30 commits November 11, 2019 22:45

Merge branch 'master' into wk12-FinalChanges

97df77a

Merge pull request #265 from evelynejuliet/branch-minor-edit-ug

23d20a8

Fix UG

Merge branch 'master' into wk12-FinalChanges

f53d151

Merge pull request #264 from ManasVegi/wk12-FinalChanges

615503d

Fix Shopping Items in SampleDataUtil

Update About Us

5327567

Add updateMapWithBoughtItems method

ca180df

Minor update to DG

52749b1

Fix bug: addition of bought amount displayed in UI when bought items …

7f45f40

…have same name

Add comment

288ae21

Resolve checkStyle violations - imports

0a38675

Merge pull request #268 from teika97/bug_fix

94ad510

Add updateMapWithBoughtItems method

Merge branch 'master' into wk12-FinalChanges

e385b31

update command summary in UG

14963a7

Merge branch 'master' into ug-changes

7fb9e14

Merge pull request #269 from ManasVegi/wk12-FinalChanges

a22f74a

Fix minor bug

Merge branch 'master' into branch-update-aboutus

c8f4d90

Merge branch 'master' into ug-changes

a72c304

Merge pull request #267 from evelynejuliet/branch-update-aboutus

069a257

Update About Us

Merge branch 'master' into ug-changes

f22bbc9

update DG

e36f19d

Merge pull request #270 from zhangxuan97/ug-changes

af8576a

update command summary in UG

Correct the name of portfolio page for ManasVegi

1e0c442

Merge branch 'master' into AmendPPPName

48a9fcf

Merge pull request #271 from ManasVegi/AmendPPPName

4fbef93

Correct the name of portfolio page for ManasVegi

Fix the link of PPP for ManasVegi

84afc46

Merge branch 'master' into AmendPPPName

50ed491

Merge pull request #273 from ManasVegi/AmendPPPName

e07b490

Fix the link of PPP for ManasVegi

Amend AboutUs

395eefe

Merge branch 'master' into AmendPPPName

9efef2b

Merge pull request #274 from ManasVegi/AmendPPPName

53f8cd8

Fix PPP issue

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CS2103-F10-2] iFridge #90

[CS2103-F10-2] iFridge #90

kelvinnharris commented Sep 26, 2019

hooncp Oct 4, 2019

hooncp Oct 4, 2019

hooncp Oct 4, 2019

hooncp Oct 4, 2019

niqiukun Oct 4, 2019

niqiukun Oct 4, 2019

niqiukun Oct 4, 2019

niqiukun Oct 4, 2019

niqiukun Oct 4, 2019

niqiukun Oct 25, 2019

niqiukun Oct 25, 2019

niqiukun Oct 25, 2019

niqiukun Oct 25, 2019

niqiukun Oct 25, 2019

niqiukun Oct 25, 2019

niqiukun Oct 25, 2019


		\|`* * *` \|careless user \|edit and delete items in shopping list \|change details of or remove grocery items

		\|`* * *` \|user \|add <<template,templates>> of grocery items \|to keep track of what I want to have in my fridge


		\|`* * *` \|environmentally-conscious user \|get feedback on how I am performing on my food waste management \|improve my food waste management

		\|`* *` \|environmentally-conscious user \|see which kinds of food I most commonly waste \|cut down on unnecessary food waste


		The following sequence diagram shows how the edit template item operation works for the logic component:

		image::EditTemplateItemSequenceDiagram2.png[]


		image::WasteReportSequenceDiagram.png[]

		image::WasteReportSequenceDiagramRef.png[]

		* Cons: Not as obvious to the user that both commands involve the same template list.


		The following sequence diagram shows how the edit template item operation works for the logic component:

[CS2103-F10-2] iFridge #90

Are you sure you want to change the base?

[CS2103-F10-2] iFridge #90

Conversation

kelvinnharris commented Sep 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment