[Tan Wei, Adam] Duke Increments #361

MistyRainforest · 2019-09-03T14:07:14Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

1nefootstep

Hello! I think you can break up Duke.java into several different classes to help make future modifications smoother.

mannggoo · 2019-09-04T14:38:00Z

src/main/java/Duke.java

+                    break;
+                case "todo":
+                case "event":
+                case "deadline":


ohhhh, this seems interesting, how does switch case work in this scenario? ^-^

mannggoo · 2019-09-04T14:40:01Z

src/test/java/DukeTest.java

+import static org.junit.jupiter.api.Assertions.*;
+
+class DukeTest {
+


Did you forget to include the body?

mannggoo · 2019-09-04T14:43:31Z

src/main/java/ListItem.java

+    public ListItem(String description, String command) {
+        try {
+            switch (command) {
+                case "todo":


Clear logic flow, but perhaps you can consider separating the different task types using different classes?

SebastianLie · 2019-09-05T07:34:03Z

src/main/java/Duke.java

+                    }
+                    //try to catch more exceptions
+                    catch (Exception e) {
+                        dukePrint("☹ OOPS!!! The description of a " + userCommand + " cannot be empty.");


You might want to create a seperate DukeException class for this later on!

ang-zeyu · 2019-09-12T03:13:56Z

src/main/java/Date.java

+    boolean exists = false;
+    String precursor = "";
+    SimpleDateFormat formatter = new SimpleDateFormat("dd/MM/yy HHss");
+    java.util.Date data;


Putting the date import at the start of the file as per convention would be better practice!

ang-zeyu · 2019-09-12T03:17:05Z

src/main/java/Date.java

+    String precursor = "";
+    SimpleDateFormat formatter = new SimpleDateFormat("dd/MM/yy HHss");
+    java.util.Date data;
+    public Date(String dateString) {


Could write javadocs for the methods!

ang-zeyu · 2019-09-12T03:19:22Z

src/main/java/Date.java

+    public String toString() {
+        if (exists) {
+            return "(" + precursor + " " + formatter.format(data) + ")";
+        }


Try to conform to the 2103 coding style!
the else { should be on the same line as '}'

ang-zeyu · 2019-09-12T03:19:56Z

src/main/java/Date.java

+ * Date representation of date string that's given
+ */
+public class Date {
+    boolean exists = false;


Naming of boolean could be more semantic

ang-zeyu · 2019-09-12T03:23:33Z

src/main/java/Duke.java

+     * Prints what Duke says in correct format.
+     * @param texts any number of String arguments
+     *              each prints on a new line.
+     */


Unused javadoc could be removed.

ang-zeyu · 2019-09-12T03:29:09Z

src/main/java/Duke.java

+    /**
+     * Main driver class for Duke.
+     *
+     */
    public static void main(String[] args) {


Remove unused main method

ang-zeyu · 2019-09-12T03:30:42Z

src/main/java/ListItem.java

+    ListItem(String description, String command, String date) {
+        try {
+            switch (command) {
+                case "todo":


Try to conform to the coding style! ( "case ..." should be on the same indent level as the switch statement )

ArunBeCoding · 2019-09-12T04:15:28Z

src/main/java/Date.java

@@ -0,0 +1,42 @@
+import java.text.SimpleDateFormat;


Good choice to create a Date class, because it is easier to edit when you change the Date format.

ArunBeCoding · 2019-09-12T04:22:26Z

src/main/java/Date.java

+    java.util.Date data;
+    public Date(String dateString) {
+        precursor = dateString.split(" ", 2)[0];
+        if (!dateString.equals("  ")) {


Instead of this, use SLAP to abstract out the checking method.

ArunBeCoding · 2019-09-12T04:25:37Z

src/main/java/Duke.java

+    private Button sendButton;
+    private Scene scene;
+
+    private Image user = new Image(this.getClass().getResourceAsStream("/images/User.jpg"));


You can consider storing the image path as a private static string to make it neater.

ArunBeCoding · 2019-09-12T04:28:40Z

src/main/java/Duke.java

+    private static void echo(String echoedString) {
+        dukePrint(echoedString);
+    }
+


This should be in UI.

ArunBeCoding · 2019-09-12T04:34:48Z

src/main/java/Storage.java

+            while(reader.hasNext()) {
+                String commandIn = reader.nextLine();
+                String[] commandArray = commandIn.split("@");
+                tempArray.add(new ListItem(commandArray[2], commandArray[1], commandArray[3]));


After you split the command, you can consider declaring each array item as a String for better understanding later, rather than commandArray[x]

ArunBeCoding · 2019-09-12T04:37:52Z

src/main/java/Storage.java

+     */
+    void save(ArrayList<ListItem> toSave) {
+        try {
+            BufferedWriter writer = new BufferedWriter(new FileWriter(filepath));


Rmb to close BufferedWriter!

ArunBeCoding

Overall very creative code! We had a pleasant time reading your code! cheeers yeeeeeeeeeeeeeeeeet

A-Assertions

A-CodeQuality

christabelteo · 2019-09-12T02:34:04Z

src/main/java/UserInterface.java

+        else {
+            date = " ";
+        }
+        switch(userCommand) {


Your switch case formatting does not comply with the java coding standard. Try to change it like this (the case is not indented):

switch(something) { case "x": return x; case "y": return y; }

j-lum and others added 17 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

Add configuration for console applications

a3ca5a4

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Merge pull request nus-cs2103-AY1920S1#13 from j-lum/javaexec

7b60e81

Add configuration for console applications

Merge branch 'gradle'

8e5e15d

Added gradle wrapper

15654b5

Added gradle wrapper

c43b882

Added Text UI Testing

16deb25

Level-1: Greet, Echo, Exit

c148f6a

Level-1: Greet, Echo, Exit

e0b0d09

Level-2: Add, List

66efa3d

Level-3: Mark as Done

a647319

Level-4: ToDo, Event, Deadline

ec66bbe

Level-5: Handle Errors

a75f012

Level-6: Delete

9e21525

1nefootstep reviewed Sep 4, 2019

View reviewed changes

mannggoo reviewed Sep 4, 2019

View reviewed changes

SebastianLie reviewed Sep 5, 2019

View reviewed changes

nus-se-pr-bot added FormatCheckRequested team.2 tutorial.CS2103-T11 tutor.damithc and removed FormatCheckRequested labels Sep 6, 2019

MistyRainforest added 5 commits September 8, 2019 12:31

Refactor TaskList

62a1d2f

Level-7: Save

a5b3502

Level-8

734a1f4

Merge branch 'branch-Level-8'

2032001

Merged level 7 & 8

73dad66

MistyRainforest added 6 commits September 8, 2019 18:08

A-MoreOOP: More OOP

731770a

A-JUnit: JUnit Testing

5488653

A-JavaDoc: JavaDoc

ed036f1

Level-9: Find

516f36b

Merge branch 'branch-Level-9'

9ddac4d

Level-10: GUI (With bugs)

c87132c

ang-zeyu reviewed Sep 12, 2019

View reviewed changes

ArunBeCoding reviewed Sep 12, 2019

View reviewed changes

src/main/java/Duke.java

private static void echo(String echoedString) {

dukePrint(echoedString);

}

Copy link

ArunBeCoding Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in UI.

ArunBeCoding reviewed Sep 12, 2019

View reviewed changes

MistyRainforest added 5 commits September 16, 2019 20:04

A-Assertions

13aa4bf

Merge pull request #3 from MistyRainforest/A-Assertions

fde803d

A-Assertions

A-CodeQuality

1e564ba

Merge pull request #4 from MistyRainforest/A-CodeQuality

46d70ed

A-CodeQuality

C-Sort

fe6c22c

christabelteo reviewed Sep 17, 2019

View reviewed changes

MistyRainforest added 5 commits September 22, 2019 22:24

C-Sort

e3f43a7

Set theme jekyll-theme-merlot

b2f3c1b

C-Sort

1356860

Fixed bugs and added product page

6c80632

Merge branch 'master' of https://github.com/MistyRainforest/duke

242f2e1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tan Wei, Adam] Duke Increments #361

[Tan Wei, Adam] Duke Increments #361

MistyRainforest commented Sep 3, 2019

1nefootstep left a comment

mannggoo Sep 4, 2019

mannggoo Sep 4, 2019

mannggoo Sep 4, 2019

SebastianLie Sep 5, 2019

ang-zeyu Sep 12, 2019

ang-zeyu Sep 12, 2019

ang-zeyu Sep 12, 2019

ang-zeyu Sep 12, 2019

ang-zeyu Sep 12, 2019

ang-zeyu Sep 12, 2019

ang-zeyu Sep 12, 2019

ArunBeCoding Sep 12, 2019 •

edited

Loading

ArunBeCoding Sep 12, 2019

ArunBeCoding Sep 12, 2019

ArunBeCoding Sep 12, 2019

ArunBeCoding Sep 12, 2019

ArunBeCoding Sep 12, 2019

ArunBeCoding left a comment

christabelteo Sep 12, 2019

		import static org.junit.jupiter.api.Assertions.*;

		class DukeTest {

[Tan Wei, Adam] Duke Increments #361

Are you sure you want to change the base?

[Tan Wei, Adam] Duke Increments #361

Conversation

MistyRainforest commented Sep 3, 2019

1nefootstep left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArunBeCoding Sep 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArunBeCoding left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArunBeCoding Sep 12, 2019 •

edited

Loading