Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alvin Ng] Duke Increments #363

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

[Alvin Ng] Duke Increments #363

wants to merge 69 commits into from

Conversation

Alvinnyk
Copy link

@Alvinnyk Alvinnyk commented Sep 3, 2019

No description provided.

j-lum and others added 23 commits August 6, 2019 15:25
@j-lum
Add support for Gradle workflow
65f72a8
@j-lum
Add sample checkstyle configuration
0112efe 
Add toolVersion block in to Gradle code sample to prevent errors.
@j-lum
Change file mode on gradle to be executable
cfd6da7
@j-lum
Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x
6e6ace1 
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)
@j-lum
Add configuration for console applications
a3ca5a4 
Gradle defaults to an empty stdin which results in runtime exceptions
when attempting to read from `System.in`. Let's add some sensible
defaults for students who may still need to work with the standard
input stream.
@j-lum
Merge pull request nus-cs2103-AY1920S1#13 from j-lum/javaexec
7b60e81 
Add configuration for console applications
@Alvinnyk
Level-1
e38aecc
@Alvinnyk
Level-2
f99d923
@Alvinnyk
Level-3
85c82a4
@Alvinnyk
Level-4
feff96e
@Alvinnyk
Level-5
475f96d
@Alvinnyk
Level-6
2e4c8bf
@Alvinnyk
Level-7
a98782a
@Alvinnyk
Level-8
1f8a4f2
@Alvinnyk
Merge branch 'branch-Level-8'
298a787
@Alvinnyk
Level-9
35c016a
@Alvinnyk
abstracted UI
0a34bae
@Alvinnyk
restructured tasks model
9f42090
@Alvinnyk
improved storage structure
8dfb952
@Alvinnyk
Fixed storage issues
1bc03c1
@Alvinnyk
Merge branch 'gradle'
33da963
@Alvinnyk
Added Gradle support
952048b
@Alvinnyk
Implemented javaFX
51eef48
@YiJiee
Copy link

YiJiee commented Sep 4, 2019 •
edited
Loading

Packages are well organised into 3 components - Storage, Ui and Model.
Naming conventions for class file is a little bit inconsistent (some classes start with smaller case and others start with capital case).
Code is written clearly and easy to understand.
Specific exceptions were not implemented and exceptions were caught at the highest level (Exception).
Other than that, the app compiles and works great until Level-9.
Reviewed on 4 Sep 2019

@R-D-D-D
Copy link

R-D-D-D commented Sep 4, 2019

The TaskList extends ArrayList which saves so much trouble I should learn from you.
I think generally the run is too bulky, you might consider abstracting out the command and maybe a parser to parse user inputs.
Instead of representing a deadline task as a whole string, maybe can have a Date object to represent the date.
The rest looks good!

Alvinnyk and others added 29 commits September 16, 2019 12:57
@Alvinnyk
Updated GUI to look better
d14e315
@Alvinnyk
Added new resources
9c5bfe0
@Alvinnyk
Updated GUI font
6bf493b
@Alvinnyk
fixed small GUI bugs
6fb180c
@Alvinnyk
Fixed error handling and small bugs
c3ee6cf
@Alvinnyk
Added assertions
fa1a97d
@Alvinnyk
Added more Assertions
cf24b12
@Alvinnyk
Merge pull request #4 from Alvinnyk/A-Assertions
a8af2ce 
Added more Assertions
@Alvinnyk
A-CodeQuality
cd925c9
@Alvinnyk
Merge pull request #5 from Alvinnyk/A-CodeQuality
c46fe88 
A-CodeQuality
@Alvinnyk
Added cross platform dependencies
9e8bf1e
@Alvinnyk
Removed logout delay
48c7fbf
@Alvinnyk
Update README.md
7bd511c
@Alvinnyk
Updated error messages
a4be141
@Alvinnyk
Added ui screenshot
8b5e690
@Alvinnyk
changed ui screenshot format
04bb4f0
@Alvinnyk
removed ui screenshot
fe0d1cc
@Alvinnyk
reupload screenshot with correct file format
2472f99
@Alvinnyk
Update README.md
54a3052
@Alvinnyk
Set theme jekyll-theme-cayman
961693e
@Alvinnyk
Set theme jekyll-theme-cayman
10db0c4
@Alvinnyk
Set theme jekyll-theme-cayman
247c9de
@Alvinnyk
Set theme jekyll-theme-cayman
1f0bf3c
@Alvinnyk
Set theme jekyll-theme-cayman
9ad7288
@Alvinnyk
Completed User Guide
ee9fe11
@Alvinnyk
Fixed small indentation errors in README
05a43b9
@Alvinnyk
Added Travis
4fb7301
@Alvinnyk
Added Travis
7e1af2c
@Alvinnyk
Fix Checkstyle
8e7f265
@iskandarzulkarnaien
Copy link

Code looks good! Some parts have heavily nested if-else blocks which might be worth refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreesubbash sreesubbash sreesubbash left review comments

Assignees
No one assigned
Labels
team.4 tutor.Tejas2805 tutorial.CS2103T-T10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Alvinnyk @YiJiee @R-D-D-D @iskandarzulkarnaien @sreesubbash @nus-se-pr-bot @j-lum