[Justine Koh] iP #291

justinekoh · 2022-01-28T16:45:44Z

BoB

"Your mind is for having ideas, not holding them." - David Allen source

BoB frees your mind of having to remember things you need to do. It's

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

Added Mark and Unmark functionalities.

Edited Add functionality of chatbot to support the above 3 task types.

…bugs when trying to add an event with invalid arguments.

zhengtaoJ · 2022-02-04T13:35:11Z

src/main/java/Deadline.java

@@ -0,0 +1,13 @@
+public class Deadline extends Task {


Consider adding header comments for the class and its public methods?

zhengtaoJ · 2022-02-04T13:35:41Z

src/main/java/Deadline.java

@@ -0,0 +1,13 @@
+public class Deadline extends Task {
+    protected String by;


Perhaps using a noun here will be more meaningful?

zhengtaoJ · 2022-02-04T13:36:32Z

src/main/java/Duke.java

-                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+        String line = "    ______________________________\n";


Consider making this a class-level constant?

zhengtaoJ · 2022-02-04T13:37:56Z

src/main/java/Duke.java

+        Scanner sc = new Scanner(System.in);
+        List<Task> list = new ArrayList<>();
+
+        String cmd = sc.nextLine().strip();


Consider using a full English word as a variable name here?

ghost

Overall, I found your code easy to read.

ghost · 2022-02-06T12:20:19Z

text-ui-test/EXPECTED.TXT

-Hello from
- ____        _        
-|  _ \ _   _| | _____ 
-| | | | | | | |/ / _ \
-| |_| | |_| |   <  __/
-|____/ \__,_|_|\_\___|


Maybe you can add a similar visual here.

ghost · 2022-02-06T12:21:26Z

src/main/java/bob/Triplet.java

@@ -0,0 +1,29 @@
+package bob;
+
+public class Triplet<T, U, V> {


Cool to see you using generics here and making a triplet class. However, it could be more useful to name this class more purposefully, "Task"?

ghost · 2022-02-06T12:21:59Z

src/main/java/bob/Task.java

+    public void toggleStatus() {
+        this.isDone = !this.isDone;
+    }


hmm, seems like this method is not used anywhere, perhaps you'll want to remove it?

Suggested change

public void toggleStatus() {

this.isDone = !this.isDone;

}

imrajsinghsandhu

Overall, I found your code easy to read for the most part, and see that you have written it well! LGTM, and keep up the good work.

imrajsinghsandhu · 2022-02-06T15:25:53Z

src/main/java/bob/TaskList.java

+    }
+
+    /**
+     * Returns the size of the TaskList.


Nicely indented code, and following coding standards well. Like to see it! Keep it up!

imrajsinghsandhu · 2022-02-06T15:27:05Z

src/main/java/bob/Parser.java

+    public static void parse(String userInput, TaskList tasks, Storage storage) {
+        try {
+            String cmd = userInput.split(" ")[0].strip();
+            boolean tasksIsDiff = false;


perhaps renaming tasksIsDiff to isTaskDiff would be better as a boolean name?

imrajsinghsandhu · 2022-02-06T15:28:32Z

src/main/java/bob/Storage.java

+    }
+
+    /**
+     * Converts a given list of tasks into a String and writes it to the file associated with this Storage instance.
+     *
+     * @param tasks List of tasks to be written to file.
+     */
+    public void writeTaskListToFile(TaskList tasks) {
+        StringBuilder tasksString = new StringBuilder();
+        for (int i = 0; i < tasks.size(); i++) {
+            tasksString.append(tasks.get(i).generateSavedEntry());
+            tasksString.append("\n");
+        }
+        try {
+            FileWriter fileWriter = new FileWriter(file);
+            fileWriter.write(tasksString.toString());
+            fileWriter.close();
+        } catch (IOException e) {
+            System.out.println("Error writing to file!:( : " + e.getMessage());
+        }
+    }
+}


I like that you have well-written javadocs, it makes code easier to read and understand!

There are multiple conditions that must hold true at every point of the program flow. If any of these conditions do not hold true when they should, it will cause unexpected behaviour in the program. Having assertions in the code to guarantee such conditions gives us confidence that the program is running smoothly with all necessary conditions met at all assertion checkpoints if no assertions fail.

Code quality is important for readability and to facilitate maintenance of code. Long methods have been shortened, by abstracting out suitable functional blocks of code, and in accordance to SLAP. Nested indentations have been removed and cleaned up. Updated most JavaDocs.

* master: Add .yml file for Continuous Integration

branch-A-Assertions

* 'master' of https://github.com/justinekoh/ip: Add assertions to check for necessary conditions in program flow

* master: Add assertions to check for necessary conditions in program flow

Improve code quality

…-A-CodeQuality * 'master' of https://github.com/justinekoh/ip:

* 'master' of https://github.com/justinekoh/ip: Improve code quality

* branch-A-CodeQuality:

Add command and archive functionalities

Changed Bob and user photos, made Bob and user photos round, added title to application

Increased size of window, disabled window resizing and fixed bugs with displayed text.

damithc and others added 9 commits July 29, 2021 20:30

Add Gradle support

d839859

Added greet, echo and exit functions. Changed chatbot name to Bob.

4fce0f6

Change scanner.next to scanner.nextLine

9ac9e68

Added list and add functionality.

a1045ae

Added Task class and updated chatbot to utilize Tasks.

0ae915c

Added Mark and Unmark functionalities.

Added subclasses of Task, including Deadline, Event and ToDo classes.

fc535fc

Edited Add functionality of chatbot to support the above 3 task types.

Setup automatic testing of chatbot.

f2f2c56

Added some exception handling for incompatible user inputs.

ae22568

Added Delete functionality and associated error handling. Fixed some …

7884565

…bugs when trying to add an event with invalid arguments.

zhengtaoJ reviewed Feb 4, 2022

View reviewed changes

Justine Koh Yong Tai added 5 commits February 6, 2022 13:27

Add persistent storage functionality and change name of program to Bob

830007a

Change date and time from string to LocalDateTime type

1508ced

Merge branch 'branch-Level-8'

f193772

Add Ui and TaskList classes to improve abstraction

c785250

Add JUnit tests and additional abstractions

2b6426c

ghost reviewed Feb 6, 2022

View reviewed changes

imrajsinghsandhu reviewed Feb 6, 2022

View reviewed changes

Justine Koh Yong Tai added 13 commits February 7, 2022 03:44

Add JavaDoc comments on all public classes and most public methods

5b3df2b

Improve coding standard to improve readability

8e72357

Merge branch 'branch-A-CodingStandard'

94dd18c

Add Find functionality

59928f7

Merge branch 'branch-Level-9'

a307011

Correct Find functionality

a280316

Merge commit 'd8398594b7bc43da5eb865321c5a50cec4b3923d'

3d9da02

Configure Gradle for project

cda7b30

Add checkstyle to project

f3232b5

Add GUI to Bob

3c01c28

Add .yml file for Continuous Integration

66d6df2

Justine Koh Yong Tai and others added 30 commits February 18, 2022 05:57

Merge branch 'master' into branch-A-CodeQuality

c6c0a5f

* master: Add .yml file for Continuous Integration

Merge pull request #3 from justinekoh/branch-A-Assertions

825500d

branch-A-Assertions

Merge branch 'master' of https://github.com/justinekoh/ip

23862e0

* 'master' of https://github.com/justinekoh/ip: Add assertions to check for necessary conditions in program flow

Merge branch 'master' into branch-A-CodeQuality

84f5765

* master: Add assertions to check for necessary conditions in program flow

Merge pull request #4 from justinekoh/branch-A-CodeQuality

5c141fd

Improve code quality

Merge branch 'master' of https://github.com/justinekoh/ip into branch…

bda11a1

…-A-CodeQuality * 'master' of https://github.com/justinekoh/ip:

Merge branch 'master' of https://github.com/justinekoh/ip

808ee04

* 'master' of https://github.com/justinekoh/ip: Improve code quality

Merge branch 'branch-A-CodeQuality'

bf11233

* branch-A-CodeQuality:

Add command and archive functionalities

7203541

Merge pull request #5 from justinekoh/branch-C-Archive

854b075

Add command and archive functionalities

Improve GUI

37a5bd0

Changed Bob and user photos, made Bob and user photos round, added title to application

Improve GUI

2f560e7

Increased size of window, disabled window resizing and fixed bugs with displayed text.

Change JavaFX version in DialogBox and MainWindow fxml files

3e1c658

Add Ui.png and edit JavaDocs

0f23d43

Set theme jekyll-theme-minimal

67644d2

Update README.md

d985f21

Update README.md

c8a0b41

Set theme jekyll-theme-cayman

b593ff4

Set theme jekyll-theme-minimal

7054c66

Update README.md

cb9dd5e

Update README.md

08ff0b4

Add sample run to README

eaabf01

Correct typo

ec21da8

Add startup UI photo

3a8e7da

Edit startup UI photo

30281e7

Update README.md

f4a46ee

Fix bugs and JavaDocs

4cdacd9

Add testcases for ToDo, Event, Deadline classes

264edab

Update Ui.png and User Guide

a0fb4aa

Fix bugs, update Ui.png and improve naming convention

7842892

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Justine Koh] iP #291

[Justine Koh] iP #291

justinekoh commented Jan 28, 2022 •

edited

Loading

zhengtaoJ Feb 4, 2022

zhengtaoJ Feb 4, 2022

zhengtaoJ Feb 4, 2022

zhengtaoJ Feb 4, 2022

ghost left a comment

ghost Feb 6, 2022

ghost Feb 6, 2022

ghost Feb 6, 2022

imrajsinghsandhu left a comment

imrajsinghsandhu Feb 6, 2022

imrajsinghsandhu Feb 6, 2022

imrajsinghsandhu Feb 6, 2022

		@@ -0,0 +1,13 @@
		public class Deadline extends Task {
		protected String by;

[Justine Koh] iP #291

Are you sure you want to change the base?

[Justine Koh] iP #291

Conversation

justinekoh commented Jan 28, 2022 • edited Loading

BoB

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imrajsinghsandhu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinekoh commented Jan 28, 2022 •

edited

Loading