Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-T12-4] NUS Classes #42

Open
wants to merge 764 commits into
base: master
Choose a base branch
from

Conversation

snss231
Copy link

@snss231 snss231 commented Feb 14, 2022

An app for NUS professors to better manage their groups and manage their tasks.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #42 (1f45c91) into master (4f7660a) will increase coverage by 2.25%.
The diff coverage is 76.17%.

@@             Coverage Diff              @@
##             master      #42      +/-   ##
============================================
+ Coverage     72.15%   74.41%   +2.25%     
- Complexity      399      772     +373     
============================================
  Files            70      111      +41     
  Lines          1232     2486    +1254     
  Branches        125      309     +184     
============================================
+ Hits            889     1850     +961     
- Misses          311      519     +208     
- Partials         32      117      +85     
Impacted Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <ø> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <ø> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <ø> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <ø> (ø)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/person/Email.java 72.72% <0.00%> (-7.28%) ⬇️
src/main/java/seedu/address/model/person/Name.java 80.00% <ø> (ø)
...rc/main/java/seedu/address/model/person/Phone.java 80.00% <ø> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7660a...1f45c91. Read the comment docs.

@snss231 snss231 changed the title [CS2103-T06-04] NUS Classes [CS2103-T12-4] NUS Classes Feb 28, 2022
junjunjieOng and others added 28 commits April 5, 2022 14:57
Change validation regex for names
Allow same name + Multiple test case fixes
Limit phone number, email, and task name length
1. Update AddTaskCommandTest.java
2. Update AddCommandTest.java
3. Update AddTaskCommandParserTest.java
4. Update AddCommandParserTest.java
5. Update datetime to be 2050 for test cases and 2023 for examples so they are valid
6. Issue #235 Duplicate tasks explanation fixed in UG
7. Issue #217 Wrong index explanation added in UG
8. General bug fixes
Fix issue causing null invocation
AdrianOngJJ and others added 30 commits April 11, 2022 17:47
# Conflicts:
#	src/main/java/seedu/address/model/task/TaskBetweenDatesPredicate.java
Fix minor capitalization error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants