-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103-W11-1] NUSocials #71
Open
fredtwt
wants to merge
356
commits into
nus-cs2103-AY2122S2:master
Choose a base branch
from
AY2122S2-CS2103T-W11-1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103-W11-1] NUSocials #71
fredtwt
wants to merge
356
commits into
nus-cs2103-AY2122S2:master
from
AY2122S2-CS2103T-W11-1:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=============================================
- Coverage 72.15% 61.80% -10.36%
- Complexity 399 620 +221
=============================================
Files 70 124 +54
Lines 1232 2477 +1245
Branches 125 324 +199
=============================================
+ Hits 889 1531 +642
- Misses 311 830 +519
- Partials 32 116 +84
Continue to review full report at Codecov.
|
aditi2313
added a commit
to aditi2313/tp
that referenced
this pull request
Feb 24, 2022
…-cs2103-AY2122S2#78) The email validation regex does not detect certain incorrect email formats and wrongly rejects correct ones. Let's * improve the regex to better account for email formats encountered in real life. * modify unit tests to test the new regex. * refine the messages shown to users to better describe the correct format for emails.
Update UI
Person.java now implements Comparable<Person>, overrides compareTo with compareToIgnoreCase(). Updates user guide url in help message popup to NUSocial's user guide.
Remove all "coming in v1.2" Correct minor typos and errors
Sorting person
Change all remaining hyperlinks directed to AB3 to NUSocials. Added use cases to removetag, delete multiple persons, and find/find -s.
…-EventCommand # Conflicts: # docs/UserGuide.md
Current implementation only adds events into the address book.
Updated sequence diagrams for Delete and added sequence diagram for delete multiple contacts.
Update dg
Add documentation
Update fredtwt.md
Update DG UG and PPP
Add page breaks to UG and DG
- Cleaned up test code for FindCommand and FindCommandParser - Edited an error message in EditCommand for more clarity
* master: Fix codecov CI error Add page breaks to UG and DG Fix formatting for DG Update DG UG and PPP Update fredtwt.md
Add Test code + Update PPP
Add more page breaks for DG formatting
Update PPP and add DG page breaks
Add PRs hyperlinks to fredtwt.md
Update DG
Update fredtwt.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUSocials is for university students who like to maintain a professional contact list. The value of the app is to facilitate a convenient way for university students to manage their professional networks with fellow acquaintances.