Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-W11-1] NUSocials #71

Open
wants to merge 356 commits into
base: master
Choose a base branch
from

Conversation

fredtwt
Copy link

@fredtwt fredtwt commented Feb 18, 2022

NUSocials is for university students who like to maintain a professional contact list. The value of the app is to facilitate a convenient way for university students to manage their professional networks with fellow acquaintances.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #71 (307902f) into master (4f7660a) will decrease coverage by 10.35%.
The diff coverage is 54.33%.

@@              Coverage Diff              @@
##             master      #71       +/-   ##
=============================================
- Coverage     72.15%   61.80%   -10.36%     
- Complexity      399      620      +221     
=============================================
  Files            70      124       +54     
  Lines          1232     2477     +1245     
  Branches        125      324      +199     
=============================================
+ Hits            889     1531      +642     
- Misses          311      830      +519     
- Partials         32      116       +84     
Impacted Files Coverage Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 71.42% <0.00%> (-3.58%) ⬇️
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <ø> (ø)
...seedu/address/logic/commands/FindEventCommand.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 72.72% <0.00%> (-27.28%) ⬇️
...u/address/logic/parser/FindAndPredicateParser.java 0.00% <0.00%> (ø)
...address/logic/parser/FindEventPredicateParser.java 0.00% <0.00%> (ø)
...a/seedu/address/model/event/DateTimePredicate.java 0.00% <0.00%> (ø)
...odel/event/EventInfoContainsKeywordsPredicate.java 0.00% <0.00%> (ø)
...nt/EventParticipantsContainsKeywordsPredicate.java 0.00% <0.00%> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7660a...307902f. Read the comment docs.

aditi2313 added a commit to aditi2313/tp that referenced this pull request Feb 24, 2022
…-cs2103-AY2122S2#78)

The email validation regex does not detect certain incorrect email
formats and wrongly rejects correct ones.

Let's
* improve the regex to better account for email formats  encountered in
  real life.
* modify unit tests to test the new regex.
* refine the messages shown to users to better describe the correct format
  for emails.
fredtwt and others added 27 commits March 22, 2022 14:45
Person.java now implements Comparable<Person>, overrides compareTo with
compareToIgnoreCase().
Updates user guide url in help message popup to NUSocial's user guide.
Remove all "coming in v1.2"
Correct minor typos and errors
Change all remaining hyperlinks directed to AB3 to NUSocials.
Added use cases to removetag, delete multiple persons, and find/find -s.
…-EventCommand

# Conflicts:
#	docs/UserGuide.md
Current implementation only adds events into the address book.
Updated sequence diagrams for Delete and added sequence diagram for
delete multiple contacts.
manu2002g and others added 30 commits April 10, 2022 21:09
- Cleaned up test code for FindCommand and FindCommandParser
- Edited an error message in EditCommand for more clarity
* master:
  Fix codecov CI error
  Add page breaks to UG and DG
  Fix formatting for DG
  Update DG UG and PPP
  Update fredtwt.md
Add more page breaks for DG formatting
Update PPP and add DG page breaks
Add PRs hyperlinks to fredtwt.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants