[CS2103T-W11-4] NUSearch #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
============================================
+ Coverage 72.15% 77.37% +5.21%
- Complexity 399 623 +224
============================================
Files 70 92 +22
Lines 1232 1746 +514
Branches 125 200 +75
============================================
+ Hits 889 1351 +462
- Misses 311 340 +29
- Partials 32 55 +23
Continue to review full report at Codecov.
|
ghost
closed this
ghost
reopened this
# Conflicts: # src/test/java/seedu/address/testutil/TypicalPersons.java
Implement undo redo
* branch-Favourites: Fix bugs in test cases Add Junit test Add Junit test Add Junit test Fix checkstyle in main Modify person equals and command equals method to ignore favourites Fix bugs in test case Add test cases for AddressBookParser Add unfavourite command Add list favourites command Add favourite command # Conflicts: # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/logic/parser/AddressBookParser.java # src/main/java/seedu/address/model/person/Person.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/JsonAdaptedPerson.java # src/main/resources/view/PersonListCard.fxml # src/test/java/seedu/address/logic/commands/CommandTestUtil.java # src/test/java/seedu/address/logic/parser/AddressBookParserTest.java # src/test/java/seedu/address/model/person/PersonTest.java # src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java # src/test/java/seedu/address/testutil/EditPersonDescriptorBuilder.java # src/test/java/seedu/address/testutil/PersonBuilder.java # src/test/java/seedu/address/testutil/TypicalPersons.java
Role field is case insensitive. A case insensitive find is more user-friendly because users cannot be expected to type the exact case of the keywords every time. Let's, * create a Class called Role and include it in the Person model * implement automated testing Role class * include role field in existing automated tests
* 'master' of https://github.com/tanweien/tp: Edit checkstyle Added test for Person and Faculty. Edited typo errors. Edit checkstyle Edit checkstyle Edit checkstyle Edit checkstyle Add Faculty Tag Amend checkstyle errors Added a short guide on User Commands in help function Implement unit testing in TagCommandTest, AddressBookParserTest, TagCommandParserTest, TagContainsKeywordsPredicateTest Add TagCommand feature to filter staff contacts based on tag # Conflicts: # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/logic/parser/AddressBookParser.java # src/main/java/seedu/address/model/person/Person.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/JsonAdaptedPerson.java # src/main/resources/view/PersonListCard.fxml # src/test/java/seedu/address/logic/commands/CommandTestUtil.java # src/test/java/seedu/address/logic/parser/AddressBookParserTest.java # src/test/java/seedu/address/model/person/PersonTest.java # src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java # src/test/java/seedu/address/testutil/EditPersonDescriptorBuilder.java # src/test/java/seedu/address/testutil/PersonBuilder.java # src/test/java/seedu/address/testutil/TypicalPersons.java
Issue#9, #10 - Add favourite feature and list favourite feature
Find command can now filter out contacts based on faculty and role, in addition to name. A case insensitive find is more user-friendly because users cannot be expected to type the exact case of the keywords every time. Let's, * modify the NameContainsPredicate class to NameFacultyRoleContainsPredicate * implement automated testing NameFacultyRoleContainsPredicate class and FindCommand class
…role-field-branch # Conflicts: # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/model/person/Person.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/JsonAdaptedPerson.java # src/test/java/seedu/address/logic/commands/CommandTestUtil.java # src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java # src/test/java/seedu/address/testutil/PersonBuilder.java # src/test/java/seedu/address/testutil/TypicalPersons.java
Add role field branch, Incorporate faculty and role under Find feature
Update Eugene's Project Portfolio Page
update simjm & eugenechiaay ppp
Add Project Portfolio Page
fix minor typo errors
* Update width of images added
Update UserGuide.md
fix typo error
Add page breaks
revert
update DG 40%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUSearch helps students and faculty members connect with each other professionally. It is optimized for users that prioritise ease of use, speed and unambiguity.