[See Toh Jin Wei] iP #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made Task class abstract
Change "true" while loop to check for scanner input instead.
Add error handling and tests for deleting tasks. Improve error handling for mark and unmark operations.
Abstracted out commonly used exceptions.
Navigate with up and down arrow keys
TanPingZhi
reviewed
Aug 30, 2022
Comment on lines
13
to
18
| public static final String COMMAND_WORD = "find"; | ||
| private static final String TASK_FORMAT = "%d: %s"; | ||
| private static final String USER_MESSAGE_FORMAT = "Here are the matching tasks in your list!\n%s"; | ||
| private static final DukeException WRONG_FORMAT = | ||
| new DukeException("Wrong format for Find!\nShould be 'find <keyword>'."); | ||
| private final String keyword; |
There was a problem hiding this comment.
Thanks for taking the time to provide your feedback!
laxus2308
reviewed
Aug 31, 2022
There was a problem hiding this comment.
I like how u provide additional comments for your variables and code to help me understand better. I like the naming of methods, especially the boolean methods which are really clear what the method is for. The imports are also grouped together for related imports, which is something I like as well. Great use of constants to reduce duplicate code. Very consistent format of code. I like the comprehensive test cases as well. Could not spot any coding standard violations throughout. Well Done!
Code lacks assertions. Add assertions to ensure that certain conditions are met. Let's ensure that tasks are set before executing command.
Some code is too complex. Reduce code complexity, mainly through abstracting long or heavily nested methods. Let's ensure that code quality is kept up.
Find command's execution is confusing. Use streams to improve readability of the code. Let's ensure that streams are used to simplify code.
Add assertions
Improve code quality
There is no way to undo commands. Add undo command to undo commands. Let's support undoing actions.
Charles1026
reviewed
Sep 4, 2022
| public class DeleteCommand extends Command { | ||
| /** Command word of the delete command. */ | ||
| public static final String COMMAND_WORD = "delete"; | ||
| private static final String USER_MESSAGE_FORMAT = "Removing this task!\n %s\nNow you have %d tasks left."; |
| * Represents an exception in the Duke application. | ||
| */ | ||
| public class DukeException extends Exception { | ||
| /** Exception due to an invalid index. */ |
There was a problem hiding this comment.
Can extend these into individual exception classes
| tasks.addTask(task); | ||
| } | ||
| } catch (FileNotFoundException e) { | ||
| // Should not happen because file is created beforehand. |
- Add welcome message - Add personality - Add bye message with delay before exit - Ignore empty command - Add application title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke Application
Duke is great for anyone who keeps a list of tasks! It's
FASTSUPER FAST to runAll you need to do is,
And it is FREE!
Features:
This application is built in Java! Run
Duketoday!SECRET 😉
Please pretend this is a cool secret area!Requirements: