[Brandon Thio] iP #19

beetee17 · 2022-08-19T08:12:10Z

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
FAST SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)
If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

…, simply echos commands entered by the user, and exits when the user types 'bye'

…y them back to the user when requested.

… change the status back to not done.

…ng of Duke.

…changes. Load the data from the hard disk when Duke starts up.

… dates in a format such as yyyy-mm-dd format (e.g., 2019-10-15) and print in a different format such as MMM dd yyyy e.g., (Oct 15 2019).

# Conflicts: # src/main/java/Deadline.java # src/main/java/Task.java

Ui: deals with interactions with the user Storage: deals with loading tasks from the file and saving tasks in the file Parser: deals with making sense of the user command TaskList: contains the task list e.g., it has operations to add/delete tasks in the list Command classes (i.e., AddCommand, DeleteCommand, ExitCommand etc.) that inherit from an abstract Command class,

…ed easily.

# Conflicts: # src/main/java/duke/commands/ListTasksCommand.java

jeromepui

LGTM. 👍 Just some minor fixes to be made.

jeromepui · 2022-08-31T08:38:26Z

src/main/java/duke/task/Todo.java

@@ -0,0 +1,40 @@
+package duke.task;
+import duke.exceptions.*;


Imported classes should always be listed explicitly.

Suggested change

import duke.exceptions.*;

import duke.exceptions.ParsingTaskException;

jeromepui · 2022-08-31T08:42:20Z

src/main/java/duke/task/Task.java

+public class Task {
+    private static final String DATA_PATH = new File("").getAbsolutePath() + "/data/duke.txt";
+    private String title;
+    private boolean completed;


I can tell from your code that the boolean tracks whether the task is completed. Perhaps you should rename it to sound more like a boolean.

Suggested change

private boolean completed;

private boolean isCompleted;

jeromepui · 2022-08-31T08:45:32Z

src/main/java/duke/task/Deadline.java

+ * Deadlines are tasks that need to be done before a specific date/time e.g., submit report by 11/10/2019 5pm
+ */
+public class Deadline extends Task {
+    protected LocalDate by;


by seems vague for a variable name. Perhaps you could rename it to make it clearer.

jeromepui · 2022-09-01T02:07:46Z

src/main/java/duke/commands/FindCommand.java

+
+    @Override
+    public void execute(TaskList taskList, Ui ui, Storage storage) {
+        List<Task> tasks = taskList.getAll().stream()


Good use of Java pipelines to find tasks! 👍

adeearyaa

Great code!

adeearyaa · 2022-09-03T05:29:22Z

src/main/java/duke/commands/ExitCommand.java

+public class ExitCommand extends Command {
+    @Override
+    public void execute(TaskList taskList, Ui ui, Storage storage) {
+        ui.showGoodByeMessage();


good descriptive method names

adeearyaa · 2022-09-03T05:29:50Z

src/main/java/duke/commands/FindCommand.java

+    }
+
+    @Override
+    public void execute(TaskList taskList, Ui ui, Storage storage) {


Great use of streams!

adeearyaa · 2022-09-03T05:31:05Z

src/main/java/duke/exceptions/InvalidDeadlineException.java

+public class InvalidDeadlineException extends InvalidCommandException {
+    public InvalidDeadlineException() {
+        super("Could not parse deadline. To create a deadline, "
+                + "please use the format in this example: "


nice exception message

adeearyaa · 2022-09-03T05:32:50Z

src/main/java/duke/parser/Parser.java

+
+import duke.commands.*;
+import duke.enums.Action;
+import duke.exceptions.*;


could have specified which file to import instead of all maybe?

# Conflicts: # src/main/java/duke/commands/FindCommand.java # src/main/java/duke/commands/ListTasksCommand.java # src/main/java/duke/ui/Ui.java

…ptions that should hold at various points in the code

…for readability.

Replace if-else branching with switch statement for readability

Use assert feature (not JUnit assertions) to document important assumptions

For example, users can now tag a task as "fun" via the command "tag <index> #fun". Current limitation is that the feature does not allow users to add multiple tags at once. For example, it does not allow the command "tag <index> #urgent, #important, #school".

beetee17 added 27 commits August 18, 2022 17:27

Implement a skeletal version of Duke that starts by greeting the user…

0c3da27

…, simply echos commands entered by the user, and exits when the user types 'bye'

Add the ability to store whatever text entered by the user and displa…

2ad4f4f

…y them back to the user when requested.

Add the ability to mark tasks as done. Optionally, add the ability to…

924f7a6

… change the status back to not done.

Add support for tracking three types of tasks: todo, deadline and event

1b0d220

Handle various errors such as incorrect inputs entered by the user.

5c79a7a

Add support for deleting tasks from the list.

0a380b6

Use the input/output redirection technique to semi-automate the testi…

76ba80d

…ng of Duke.

Save the tasks in the hard disk automatically whenever the task list …

a8dd5e0

…changes. Load the data from the hard disk when Duke starts up.

Store deadline dates as a java.time.LocalDate in task objects. Accept…

2095cd0

… dates in a format such as yyyy-mm-dd format (e.g., 2019-10-15) and print in a different format such as MMM dd yyyy e.g., (Oct 15 2019).

Merge branch 'branch-Level-8'

450f9f1

# Conflicts: # src/main/java/Deadline.java # src/main/java/Task.java

Fix unable to parse date when it has surrounding whitespace

d262c93

Organise the classes into suitable java packages.

bbd1cef

Rename delete function

f9b64ff

Use Gradle to automate some of the build tasks of the project.

780f4eb

Package the app as an executable JAR file so that it can be distribut…

ce5ee12

…ed easily.

Setup dummy JUnit tests

6deaeb9

Organise commands, parser, storage, ui into their own packages

569cd0b

Add JavaDoc comments to the code.

aea5945

Tweak the code to comply with a coding standard

c4284fe

Give users a way to find a task by searching for a keyword.

a326853

Merge branch 'branch-A-CodingStandard'

a400c98

Merge branch 'branch-Level-9'

b001e9e

# Conflicts: # src/main/java/duke/commands/ListTasksCommand.java

Add JUnit tests to test the behavior of the code.

ba264ca

Use checkStyle to detect coding style violations.

46c36e2

Got javaFX minimal example working

c5236d6

Add minimal GUI using JavaFX

b610b49

jeromepui reviewed Sep 1, 2022

View reviewed changes

adeearyaa reviewed Sep 3, 2022

View reviewed changes

Merge branch 'branch-A-Checkstyle'

21c6238

# Conflicts: # src/main/java/duke/commands/FindCommand.java # src/main/java/duke/commands/ListTasksCommand.java # src/main/java/duke/ui/Ui.java

beetee17 and others added 9 commits September 6, 2022 00:02

Use assert feature (not JUnit assertions) to document important assum…

49c9a18

…ptions that should hold at various points in the code

Remove dead code and replace if-else branching with switch statement …

3d97211

…for readability.

Merge pull request #1 from beetee17/branch-A-CodeQuality

e7aa1b0

Replace if-else branching with switch statement for readability

Merge pull request #2 from beetee17/branch-A-Assertions

47fc51e

Use assert feature (not JUnit assertions) to document important assumptions

Provide a way to tag items

c01b089

For example, users can now tag a task as "fun" via the command "tag <index> #fun". Current limitation is that the feature does not allow users to add multiple tags at once. For example, it does not allow the command "tag <index> #urgent, #important, #school".

Add a User Guide to the project

b00c6c3

Move Readme to docs folder

923c068

Update the main Readme page

b6b8713

Release the product to be used by potential users

7ce06ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Brandon Thio] iP #19

[Brandon Thio] iP #19

beetee17 commented Aug 19, 2022 •

edited

Loading

jeromepui left a comment

jeromepui Aug 31, 2022

jeromepui Aug 31, 2022

jeromepui Aug 31, 2022

jeromepui Sep 1, 2022

adeearyaa left a comment

adeearyaa Sep 3, 2022

adeearyaa Sep 3, 2022

adeearyaa Sep 3, 2022

adeearyaa Sep 3, 2022

	import duke.exceptions.*;
	import duke.exceptions.ParsingTaskException;

[Brandon Thio] iP #19

Are you sure you want to change the base?

[Brandon Thio] iP #19

Conversation

beetee17 commented Aug 19, 2022 • edited Loading

DukePro

jeromepui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adeearyaa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beetee17 commented Aug 19, 2022 •

edited

Loading