[Sun Yu Ting] iP #22
[Sun Yu Ting] iP #22
Conversation
…do tasks for now.
# Conflicts: # src/main/java/Deadline.java # src/main/java/Event.java # src/main/java/TaskList.java Merge Level-8 branch with main branch
# Conflicts: # src/main/java/duke/parser/Parser.java
| public class Storage { | ||
|
|
||
| private static String filePath; | ||
| private File f; |
There was a problem hiding this comment.
Maybe you could name this variable more specifically. As said in the textbook, a name is not just for differentiation; it should explain the named entity to the reader accurately and at a sufficient level of detail.
There was a problem hiding this comment.
Okay thanks for your recommendation!
| String[] splitCommand = s.split(" ", 2); | ||
| String command = splitCommand[0]; | ||
| switch (command) { | ||
| case "bye": |
There was a problem hiding this comment.
This method is quite long. Maybe you could split it into some small methods for each case.
There was a problem hiding this comment.
I agree with your criticism here. I will try to reduce the method length when I do have the time to look at this again.
| */ | ||
| public class Parser { | ||
|
|
||
| private static TaskList taskList; |
There was a problem hiding this comment.
Should we extract out tasklist storage and UI? Could consider using Duke.java to control the logic flow instead of exposing storage, UI and tasklist all to parser?
There was a problem hiding this comment.
This is true since I am indeed exposing these classes to parser. I will try to address this issue when I have the time.
| * Reads the tasks from the file and loads them into an <code>ArrayList</code> | ||
| * @return An <code>ArrayList</code> containing the tasks from the file. | ||
| */ | ||
| public ArrayList<String> load() { |
There was a problem hiding this comment.
Could consider renaming this loadFromFile to standardise with appendToFile
There was a problem hiding this comment.
Thank you for the suggestion. I will change it soon.
The "bye" case in readInputString method was not adhering to SLAP. Thus, I added in two methods into taskList so that I could abstract out what I was doing before so as to SLAP hard. This would make it easier to understand the code. Also, since I had not fully implemented changing of the date format, I practiced KISSing. I made the code simple to change the date format. I also added in new methods in the UI to show related messages when the user want to change the date format.
This reverts commit 8f15150.
to fit naming conventions. Assertions were placed in the readInputString method in Parser so that the first element in splitCommand will never be null. This is important to check since the rest of the code depends on what is contained in the first element of splitCommand. Also, comments made by my peers about the naming of certain variables and methods were heeded. I changed the name of load() to loadFromFile() and I changed the name of File f to File taskFile.
…ventions." This reverts commit aeb0929.
…into branch-A-Assertions
…into branch-A-CodeQuality
Add Assertions
Improve Code Quality
Users now have the ability to tag the tasks that they add. They can also choose not to tag the task as well. All tags will be prefixed by a hash symbol, i.e. #. This will allow users to customize their tasks to a greater extent.
reading and writing to the external file. Add a findtag command for the user to find a tag in their task list.
No description provided.