-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pontakorn Prasertsuk] iP #25
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, code standard is high. There could be more consistency as to whether there is an empty line before return statement. The ones in tasklist class do not while most in other classes do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great code, clean and elegant!
Some return statements have no blank line before them. Having blank line before return statements increases consistency in code quality.
Increase consistency with blank line before return
There are missing blank lines in TaskList and Duke. To increase code quality consistency.
File should be created when interacting with Storage. Assertion helps with verifying assumption that should be true. Java assertion is for verifying assumption during runtime and can be turned off.
Add assertion for file creation
Currently no workflow when pushing or merging commits. CI helps verify commits if they are compilable. GitHub CI is easy to setup.
Bob Chatbot
Bob Chatbot helps you remember your tasks. It's,
To use, simply following these steps
and it's FREE
Features: