-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Eugene Ong Wei Xiang] iP #29
Open
Eugene-Ong-W-X
wants to merge
43
commits into
nus-cs2103-AY2223S1:master
Choose a base branch
from
Eugene-Ong-W-X:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
556af3f
Add Gradle support
f6fd68b
Level-1 Done
Eugene-Ong-W-X 7378eb9
Level-2 Done
Eugene-Ong-W-X a044c10
Level-3 Done
Eugene-Ong-W-X 5fe495d
Level-4 Done
Eugene-Ong-W-X 91f2fff
A-TextUiTesting Done
Eugene-Ong-W-X 9658653
Level-5 Done
Eugene-Ong-W-X 6f8dc32
Level-6 Done
Eugene-Ong-W-X 30f5bb8
A-Enums Done
Eugene-Ong-W-X 6d379a7
CheckStyle Done
Eugene-Ong-W-X 2013e87
Add Level-7 | Read from & Write to File
Eugene-Ong-W-X 84d0c49
Add Level-8 | Timestamps properly implemented
Eugene-Ong-W-X 75f3d53
Merge branch 'branch-Level-7'
Eugene-Ong-W-X 8209332
Merge branch 'branch-Level-8' into HEAD
Eugene-Ong-W-X b8119d6
More OOP | Add Ui, Parser, TaskList classes
Eugene-Ong-W-X 7823c9c
Rename Duke/Alfred to Ren and Add 2 packages
Eugene-Ong-W-X 422ded7
Merge branch 'add-gradle-support' of https://github.com/nus-cs2103-AY…
Eugene-Ong-W-X 1f4739e
Add Gradle Support
Eugene-Ong-W-X f6491cf
Add JUnit Tests
Eugene-Ong-W-X 6605c20
Release v0.2 (Packaging as JAR file)
Eugene-Ong-W-X 2e039ea
Add JavaDoc
Eugene-Ong-W-X 176828a
Java Standards: Fixed test codes
Eugene-Ong-W-X c7fc8d2
Add Find Feature
Eugene-Ong-W-X aa2133f
Merge branch 'branch-A-JavaDoc'
Eugene-Ong-W-X dc89a4b
Merge branch 'branch-A-CodingStandard'
Eugene-Ong-W-X 1f496d9
Merge branch 'branch-Level-9'
Eugene-Ong-W-X 443b11a
Use CheckStyle
Eugene-Ong-W-X 7f9d8b9
Merge branch 'branch-A-CheckStyle'
Eugene-Ong-W-X 3b647fc
Upgrade to GUI from Text UI
Eugene-Ong-W-X 8562c90
Merge branch 'branch-Level-10'
Eugene-Ong-W-X 730da76
Add and enable Assertions
Eugene-Ong-W-X 5b3b597
Improve Code Quality
Eugene-Ong-W-X c925dde
Merge pull request #2 from Eugene-Ong-W-X/branch-A-CodeQuality
Eugene-Ong-W-X 9122d13
Merge branch 'master' into branch-A-Assertions
Eugene-Ong-W-X 64423eb
Merge pull request #1 from Eugene-Ong-W-X/branch-A-Assertions
Eugene-Ong-W-X 1ee5cba
Set up Java CI using Github Actions
Eugene-Ong-W-X f2757f6
Fix for Java CI implementation
Eugene-Ong-W-X 232a235
Fix 2 for Java CI implementation
Eugene-Ong-W-X 1ec902d
Add Sort Feature
Eugene-Ong-W-X 141d85e
Merge branch 'branch-BCD-Extension'
Eugene-Ong-W-X ebd82ba
Set up Ren Website
Eugene-Ong-W-X 2683455
Update README.md
Eugene-Ong-W-X faad80a
Fix Code Quality
Eugene-Ong-W-X File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is completely up to you but I felt the method name for this factory method is a little short? Perhaps something like
public static TimeStamp **generateTimestamp**(String dateTime) throws RenException
could be something a bit more descriptive? I do understand that "of" is used for the grammar to flow in another context, so feel free to ignore this!