[Ryan Guai] iP #34
Open
[Ryan Guai] iP #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/Duke.java
# Conflicts: # src/main/java/duke/parser/Parser.java
# Conflicts: # src/main/java/Duke.java # src/main/java/duke/task/Event.java
maryjess
reviewed
Aug 31, 2022
| taskList.add(task); | ||
| } | ||
|
|
||
| public ArrayList<Task> searchMatches(String keyword) { |
There was a problem hiding this comment.
Perhaps method name of searchTasks or searchMatchingKeyword is better?
|
|
||
| public ArrayList<Task> searchMatches(String keyword) { | ||
| ArrayList<Task> matchingList = new ArrayList<>(); | ||
| for (Task task: taskList) { |
There was a problem hiding this comment.
Should we add a spacebar here, after task?
src/main/java/duke/main/Duke.java
Outdated
| String dukeResponse = ""; | ||
| try { | ||
| switch (response) { | ||
| case "find": { |
There was a problem hiding this comment.
Perhaps this line should have one less indent?
https://se-education.org/guides/conventions/java/intermediate.html#:~:text=Note%20there%20is%20no%20indentation%20for%20case%20clauses.
| FileWriter myWriter = new FileWriter(this.filePath); | ||
| StringBuilder output = new StringBuilder(); | ||
| ArrayList<Task> tasks = taskList.getTasks(); | ||
| for (Task task:tasks) { |
There was a problem hiding this comment.
Perhaps can add spacebar here as well?
| */ | ||
| public class Deadline extends Task { | ||
|
|
||
| protected LocalDate by; |
There was a problem hiding this comment.
Perhaps the instance variable name can be more descriptive, e.g. deadlineDate or date?
|
|
||
| /** | ||
| * Marks task as done and prints message. | ||
| */ |
There was a problem hiding this comment.
Perhaps can add @return here, as part of the Javadoc?
The previous mainClassName was incorrectly used as the default example given in the tutorial. Let's change it so that the JAR file generated is correct.
Let's enable assertions to check that important assumptions hold throughout the code.
Let's refactor code to remove unnecessary import statements, avoid magic literals and complicated expressions.
Use assertions
Let's provide a way to attach priorities to items. When the task list is printed, it would be useful to sort by priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DukePro
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you are a Java programmer, you can use it to practice Java too. Here's the
mainmethod: