[Tan Hong Liang] iP #501

tanhl2000 · 2022-08-29T04:06:34Z

Duke iP

I'm hungry -me

This Duke chatbot is an interactive task scheduler that allows users to:

create and add various tasks
save and load these tasks to a log file
track progress of tasks by marking tasks done and not done
and much more!

All you need to do is to:

download it from here
double-click it
add your tasks
let it manage your tasks for you 🤩

and it's FREE!

Features:

Managing tasks
Managing reminders (coming soon)
Managing deadlines (coming soon)

Here's a code snippet to get you excited!

public static void main(String[] args) {
        Duke bot = new Duke();
        bot.run();
}

YH-15

Overall, the code was nicely designed, the code style follows coding standards most of the time, other than a few white space and JavaDoc issues. Looks good!

YH-15 · 2022-09-01T08:45:41Z

src/main/java/Duke.java

@@ -10,13 +10,15 @@ public class Duke {
    private static final String COMMAND_LIST = "list";
    private static final String COMMAND_BYE = "bye";
    private static final String COMMAND_TODO = "todo";
+    private static final String COMMAND_DEADLINE = "deadline";
+    private static final String COMMAND_EVENT = "event";
    private static final String COMMAND_MARK = "mark";
    private static final String COMMAND_UNMARK = "unmark";

    public static void main(String[] args) {


I love the design of code, but it would be great if the main "command execution" part could be extracted out to another class (which is required in Week 3 ip task [A-MoreOOP], so it might be easier if we change the code earlier)

YH-15 · 2022-09-01T08:51:22Z

src/main/java/Duke.java

@@ -77,8 +107,8 @@ public static String outputNumOfTasks() {
        return String.format("Now you have %d tasks in the list \n", tasks.size());
    }

-    public static String chat(String message) {
-        return UI_LINE_SPACING + message + UI_LINE_SPACING;
+    public static void chat(String message) {


It would be great if JavaDoc could be added (but I highly understand that you might want to add comments once for all when the variables/func names are confirmed.

YH-15 · 2022-09-01T08:55:33Z

src/main/java/Event.java

@@ -0,0 +1,14 @@
+public class Event extends Task{


I think you might need a white space before the curly brace according to the code standard.

YH-15 · 2022-09-01T08:58:09Z

src/main/java/Task.java

@@ -0,0 +1,36 @@
+public class Task {
+    protected String description;
+    protected   boolean isDone;


Seems that there is an extra white space followed by "protected" according to coding standard.

Yes this violates the coding standard

YH-15 · 2022-09-01T08:59:27Z

src/main/java/Deadline.java

@@ -0,0 +1,14 @@
+public class Deadline extends Task{


Similar to Event class, I think you might need a white space before the curly brace according to the code standard.

Gavzzz · 2022-09-04T11:04:17Z

src/main/java/Duke.java

@@ -1,6 +1,5 @@
 import java.util.Scanner;
 import java.util.ArrayList;
-
 public class Duke {
    private static ArrayList<Task> tasks = new ArrayList<Task>();


can consider making this a private static final variable

Gavzzz · 2022-09-04T11:10:17Z

src/main/java/Duke.java

+    public static void error(String message) {
+        System.out.println(UI_LINE_SPACING + ":( OOPS: " + message + "\n" + UI_LINE_SPACING);
+    }
+
    public static void end() {
        System.out.println(UI_LINE_SPACING + "Bye! Hope to see you again!" + UI_LINE_SPACING);
        isEnd = true;


Overall code is clear and the logic flows and should have no problem completing the IP

Gavzzz · 2022-09-04T11:11:55Z

src/main/java/Task.java

@@ -0,0 +1,36 @@
+public class Task {
+    protected String description;
+    protected   boolean isDone;


Yes this violates the coding standard

Level-7 requirements done, saving and loading finished, merged with master

Level-8 done, date time changed to LocalDate, merged with master

…starting to make the individual classes work

… from, start incorporating in some classes.

…ing the Command classes which will return tasks, also fixed all errors such that chatbot works now. Package splitting finished as well.

… classes

…ursory check for coding standards will continue to check

Level-Javadoc: Added documentation to all classes except tasks classes, documentation is surface level for now will add more

…verything

…ress to save to and load from

…n with GUI

… code quality as I believe it also falls under this category

Level-A-CodeQuality PR merge commit

…s can only do so by exiting the programme, which would save it in the log This makes it very difficult for them to have multiple save states of their tasks, which may be necessary for users who want to use the scheduler for repetitive tasks, or for trying out different planned schedules and seeing which fit As such, I have decided to add the archive functionality which lets users save their current configuration within a archive file. The archive is a collection of text files that saves logs of the tasklist and is stored in the Resources/archive directory I decided to use archiving as it makes it more customisable and flexible for the users new commands from the archive addition: - archive [archive name] - loadA [archive name] - listA

Currently there is no user guide on the github New users would not have a user guide to refer to when just starting to use the program Thus I added a user guide that would be able to tell users about the features and usage of the program This user guide will be the first thing shown when a user enters the github repo, thus allowing them easy access to it

Added in the clear command which was just updated

tanhl2000 added 3 commits August 28, 2022 16:11

Added Week 2 Level-1 Level-2 and Level-3

0d13617

finished ToDo of Level-4 and cleaned up code

e176f21

Finished up Level-4, Event and Deadline task types added

ff600bd

YH-15 reviewed Sep 1, 2022

View reviewed changes

tanhl2000 added 2 commits September 2, 2022 16:01

Level-5, did more cleanup of code

04c50e0

Level-6 done, ArrayList used from start, delete command implemented

cf80052

Gavzzz reviewed Sep 4, 2022

View reviewed changes

tanhl2000 added 23 commits September 8, 2022 08:42

Did small part of Level-9

14fbfe9

Finished Level-7 with saving and loading done

5442e79

Level-8 done in parallel branch

de18707

Merge tag 'Level-7'

bd191ca

Level-7 requirements done, saving and loading finished, merged with master

Merge tag 'Level-8'

32a4edb

Level-8 done, date time changed to LocalDate, merged with master

fix conflicts from merge

812a5f8

fixed merge errors and updated enums with strings

d42fd1f

Level-A-MoreOOP, split into packages

cc19d6b

Level-A-MoreOOP, fully split out the different packages and classes, …

a3a39b8

…starting to make the individual classes work

Level-A-MoreOOP, fixed functionalities for non task producing commands

7408a38

Level-5, made a main exception class where all exceptions will extend…

c1cb522

… from, start incorporating in some classes.

Level-A-MoreOOP and Level-Packages: Finished abtracting and implement…

7718dc5

…ing the Command classes which will return tasks, also fixed all errors such that chatbot works now. Package splitting finished as well.

Level-A-Gradle: Added gradle support and converted to Gradle project

ba58ab6

Level-A-Gradle, fixed package and import declarations in all files.

c85360a

Level-A-JUnit: set up Junit, created 1 test file to test it out

9e9dcd7

Level-A-JUnitv2: Added Testing for TaskList

b248eee

Level-A-Jar

1d8b29d

Level-A-Javadoc: Added documentation for all classes except the tasks…

bde3039

… classes

Level-A-CodingStandardsv1: Added comments for logical blocks, did a c…

174ec22

…ursory check for coding standards will continue to check

Merge commit Level-9: Added find command

92b2745

Merge tag 'Level-A-JavaDoc'

76b923c

Level-Javadoc: Added documentation to all classes except tasks classes, documentation is surface level for now will add more

Merge commit: commit some untracked files, to ensure merge commited e…

632ab49

…verything

Merge branch 'Level-A-CodingStandards'

fc92a48

tanhl2000 added 4 commits September 19, 2022 17:46

Level-7: updated saving and loading such that user may specify an add…

fd15136

…ress to save to and load from

Level-10: Added JavaFX support and GUI, changed program flow to fit i…

c49356d

…n with GUI

Level-10: Added personalisation and cursory editing with FXML builder

53c523e

Level-10 and Level-Assertion: Finished Level-10 and added assertions

e2959fd

tanhl2000 force-pushed the master branch from 6f856c9 to c49356d Compare September 19, 2022 15:18

tanhl2000 added 23 commits September 19, 2022 23:21

Merge commit Level-10: Merged Level-10 and Level-A-Assertions

13377a1

Level-10: fixed errors from previous merge deconflicting

f48f75f

Level-A-Jar: Created jar file

1ff9775

Level-10: added personalisation

41ea42d

Level-A-CodeQuality: added more comprehensive javadocs, putting under…

0957668

… code quality as I believe it also falls under this category

Level-A-CodeQuality: changed most magic literals to constants

7c80298

Level-A-CodingQuality: added more comments in to improve readability

0d7c9c1

Merge pull request #2 from tanhl2000/Branch-Level-A-CodeQuality

21f3c2f

Level-A-CodeQuality PR merge commit

Level-C-Archive: Adding archive functionality, saving progress

52c8f42

General bug fixes and adding the Ui.png

636d061

Merge the User guide

909bc1c

Bug fixes and improvements to code quality

c59219f

Removed UI from storage as its never used

7d75648

Final touches and adding clear archive functionality

0356d41

Update with clear command

3a7811c

Added in the clear command which was just updated

Delete Ui.PNG

fe7c2af

Add Ui.png

ebf81e5

Delete Ui.png.png

b696e2a

Add files via upload

02e1d24

Updated the UI background graphics opacity to be less distracting

63a9b27

Merge branch 'master' of https://github.com/tanhl2000/ip

a01d243

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tan Hong Liang] iP #501

[Tan Hong Liang] iP #501

tanhl2000 commented Aug 29, 2022 •

edited

Loading

YH-15 left a comment

YH-15 Sep 1, 2022

YH-15 Sep 1, 2022

YH-15 Sep 1, 2022

YH-15 Sep 1, 2022

Gavzzz Sep 4, 2022

YH-15 Sep 1, 2022

Gavzzz Sep 4, 2022

Gavzzz Sep 4, 2022

Gavzzz Sep 4, 2022

[Tan Hong Liang] iP #501

Are you sure you want to change the base?

[Tan Hong Liang] iP #501

Conversation

tanhl2000 commented Aug 29, 2022 • edited Loading

Duke iP

YH-15 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tanhl2000 commented Aug 29, 2022 •

edited

Loading