-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Singh Abdullah Alexander] iP #519
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately, good job on the code!
src/main/java/Deadline.java
Outdated
public class Deadline extends Task { | ||
private String description; | ||
private LocalDate date; | ||
private boolean isDone; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good naming of booleans:)
src/main/java/Chacha.java
Outdated
public static void main(String[] args) { | ||
System.out.println("Hello! I'm Chacha\n" + "What can I do for you?"); | ||
Scanner input = new Scanner(System.in); | ||
String s = input.nextLine(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe can name s differently? To a clearer variable
src/main/java/Chacha.java
Outdated
System.out.println("Hello! I'm Chacha\n" + "What can I do for you?"); | ||
Scanner input = new Scanner(System.in); | ||
String s = input.nextLine(); | ||
ArrayList<Task> taskList = new ArrayList<Task>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that the variable names are in camel case
add storage logic fix parser
@@ -0,0 +1,102 @@ | |||
package chacha; | |||
|
|||
import java.io.BufferedWriter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should consider adding spaces in between import statements from different packages to improve readability.
dateTime = LocalDateTime.parse(date, formatter); | ||
} | ||
Task task = new Task(); | ||
switch (type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/main/java/Chacha.java
Outdated
//load task objects into array | ||
System.out.println(s.nextLine()); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall code looks clean and should have no problem finishing up the ip
src/main/java/Chacha.java
Outdated
@@ -6,15 +6,43 @@ public static void main(String[] args) { | |||
System.out.println("Hello! I'm Chacha\n" + "What can I do for you?"); | |||
Scanner input = new Scanner(System.in); | |||
String s = input.nextLine(); | |||
ArrayList<String> list = new ArrayList<String>(); | |||
ArrayList<Task> taskList = new ArrayList<Task>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can consider making taskList a private static final field in the class
src/main/java/Chacha.java
Outdated
} | ||
|
||
} else if (s.contains("unmark")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can consider using s.startsWith function to check if the task type is indeed the first input
# Conflicts: # src/main/java/chacha/TaskList.java # src/main/java/chacha/commands/ExitCommand.java # src/main/java/chacha/commands/ListCommand.java # src/main/java/chacha/tasks/Deadline.java # src/main/java/chacha/tasks/Todo.java
# Conflicts: # src/main/java/chacha/Ui.java
add assert statements
fix code quality
Sort command is null safe to handle todo tasks. A sort is necessary for users to sort tasks chronologically. Using a custom comparator class for tasks is preferable because other sorting parameters such as description can be added later. Refer to this S/O discussion on dealing with multiple comparators as a chain https://codereview.stackexchange.com/questions/229497/handle-null-in-comparator-class
Add sort command
Find command finds returns all tasks with any of the keywords. A find command which accepts multiple arguments is more user-friendly for users who wish to search for multiple types of tasks at once.
Find command: add varargs to pass multiple keywords
Edit the fxml view files to update styling for GUI. Styling the GUI makes the chatbot more user friendly.
Modify UI responses and error responses to create personality for Chacha. Adding a personality improves user-friendliness of Chacha's interactions with users.
Github page as documentation for user. By adding a website, users can easily refer to usage of the product.
-Fix arrowhead in Chacha getResponse
-Fix Parser SLAP
Chacha
Chacha helps you plan an track upcoming tasks. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you are familiar with Java, you can use it to practice too. Here's the
main
method: