Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T11-1] Contactmation #138

Open
wants to merge 581 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
581 commits
Select commit Hold shift + click to select a range
141a2df
Merge branch 'master' of https://github.com/mohamedsaf1/tp
mohamedsaf1 Oct 30, 2022
729d49c
Update User Guide
jasonchristopher21 Oct 30, 2022
aeeede6
Merge pull request #148 from Eclipse-Dominator/branch-ug-updates
jasonchristopher21 Oct 30, 2022
5652e6b
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Oct 30, 2022
2ce9783
Merge pull request #149 from jasonchristopher21/branch-user-guide-draft
Eclipse-Dominator Oct 30, 2022
ecd24a0
Merge branch 'master' into branch-bug-fixes
Eclipse-Dominator Oct 30, 2022
9a098e5
Edit the UG to rename groups to teams, and improve style
mohamedsaf1 Oct 30, 2022
0318faf
Fix missing find command
Eclipse-Dominator Oct 31, 2022
d676c37
Fix null handle behavior
Eclipse-Dominator Oct 31, 2022
dc1c9fc
Fix bugs for UG
mohamedsaf1 Oct 31, 2022
d7bff2d
Fix unit test case
Eclipse-Dominator Oct 31, 2022
23d2dbd
Fix bugs for UG
mohamedsaf1 Oct 31, 2022
956b369
Merge branch 'master' of https://github.com/mohamedsaf1/tp
mohamedsaf1 Oct 31, 2022
f9a9398
Changes set input to return command
Eclipse-Dominator Oct 31, 2022
86fa394
Refactor some code
Eclipse-Dominator Oct 31, 2022
3f92371
Fixes incoherent error messages related to indexes
Eclipse-Dominator Oct 31, 2022
54a9aec
Fix checkstyle and trailing whitespaces.
Eclipse-Dominator Oct 31, 2022
07905fc
Fixes checkstyle for Tests
Eclipse-Dominator Oct 31, 2022
08fc79a
Fix unit tests
Eclipse-Dominator Oct 31, 2022
ecec078
Fixes 'static' modifier out of order
Eclipse-Dominator Oct 31, 2022
afce9bd
Removes unused imports
Eclipse-Dominator Oct 31, 2022
680a0fc
Merge pull request #151 from Eclipse-Dominator/branch-bug-fixes
autumn-sonata Oct 31, 2022
782c782
Refactors delete, select, foreach commands.
Eclipse-Dominator Oct 31, 2022
5f33026
Fix foreach loop's not copied
Eclipse-Dominator Oct 31, 2022
51c189a
Refactored find command
Eclipse-Dominator Oct 31, 2022
b5826c7
Adds new test case for delete commands
Eclipse-Dominator Oct 31, 2022
fb58995
Fixes checkstyle for main code
Eclipse-Dominator Oct 31, 2022
94cd624
- improves junit test version
Eclipse-Dominator Nov 1, 2022
8e04dcd
Fix checkstyle
Eclipse-Dominator Nov 1, 2022
5ed81f8
Fix unit test checkstyle
Eclipse-Dominator Nov 1, 2022
0c5b943
Merge pull request #153 from Eclipse-Dominator/branch-code-refactor
connlim Nov 1, 2022
8c4e6df
Add workflow to export UG to PDF
connlim Nov 1, 2022
9c66e0b
Merge pull request #154 from connlim/branch-ug-pdf-export
Eclipse-Dominator Nov 1, 2022
b53f34b
Add builder classes for testing
autumn-sonata Nov 1, 2022
ed5e6ad
Make checkstyle amendments
autumn-sonata Nov 1, 2022
7358c67
Merge branch 'master' of https://github.com/autumn-sonata/tp into bra…
autumn-sonata Nov 1, 2022
59cc32d
Correct misnaming of method in AddressBookBuilder
autumn-sonata Nov 1, 2022
2420114
Merge pull request #155 from autumn-sonata/branch-testing
Eclipse-Dominator Nov 1, 2022
460f924
Fix jar file name
jasonchristopher21 Nov 2, 2022
5a8aa4d
Fix misleading link in HelpWindow.java
jasonchristopher21 Nov 2, 2022
08b1bcf
Remove duplicate team remove instruction
jasonchristopher21 Nov 2, 2022
7ea9b0d
Add sample data for addressbook
autumn-sonata Nov 2, 2022
766a61d
Fix bugs related to pe dry run
autumn-sonata Nov 2, 2022
6287a26
Fix formatting bugs found in pe dry run
autumn-sonata Nov 2, 2022
febe021
Fix checkstyle errors
autumn-sonata Nov 2, 2022
da5ab63
Merge pull request #157 from autumn-sonata/branch-testing
connlim Nov 2, 2022
a4b380a
Add storage components for aliases and macros
autumn-sonata Nov 2, 2022
8041f60
Fix checkstyle errors
autumn-sonata Nov 2, 2022
d275746
Fix crashing issue on SampleDataUtil
autumn-sonata Nov 2, 2022
7cd8e29
Merge branch 'master' of https://github.com/autumn-sonata/tp into bug…
autumn-sonata Nov 2, 2022
98dd86a
Merge pull request #158 from autumn-sonata/bug-fixes
connlim Nov 3, 2022
17a3f70
Update UG
mohamedsaf1 Nov 3, 2022
00cdd79
Merge branch 'master' of https://github.com/mohamedsaf1/tp
mohamedsaf1 Nov 3, 2022
6ea9a88
Add test cases for AttributeList
jasonchristopher21 Nov 3, 2022
fb47848
Fix alias not working for custom command bug
Eclipse-Dominator Nov 3, 2022
9de780b
Fix phone being read as address when loading
Eclipse-Dominator Nov 3, 2022
e722e62
Add AbstractAttributeTest
jasonchristopher21 Nov 3, 2022
80fb933
Fixes random display order
Eclipse-Dominator Nov 3, 2022
a6f189e
Fix error message
Eclipse-Dominator Nov 3, 2022
5cf361c
Add test case for jsonAdaptedPerson
autumn-sonata Nov 4, 2022
572fa9f
Merge pull request #161 from Eclipse-Dominator/master
autumn-sonata Nov 4, 2022
7628663
Add draft PPP for Connor
connlim Nov 4, 2022
687d1cd
Fix bug on Duplicate Person detection
jasonchristopher21 Nov 4, 2022
5281704
Merge pull request #162 from connlim/branch-ppp-draft
jasonchristopher21 Nov 4, 2022
0b941ab
Update Project Portfolio Page for Jason
jasonchristopher21 Nov 4, 2022
1467289
Updated PPP
Eclipse-Dominator Nov 4, 2022
9942cde
Edit PPP for mohamedsaf1
mohamedsaf1 Nov 4, 2022
b94f4df
Merge pull request #163 from jasonchristopher21/branch-update-project…
mohamedsaf1 Nov 4, 2022
b7b040e
Merge pull request #160 from mohamedsaf1/master
jasonchristopher21 Nov 4, 2022
a2a8e51
Removes trailing whitespaces
Eclipse-Dominator Nov 4, 2022
cbf6005
Merge branch 'master' of https://github.com/mohamedsaf1/tp
mohamedsaf1 Nov 4, 2022
f0e791d
Merge pull request #164 from AY2223S1-CS2103T-T11-1/branch-ppp
jasonchristopher21 Nov 4, 2022
93367bb
Add ppp for autumn-sonata
autumn-sonata Nov 4, 2022
553ec69
Merge pull request #165 from autumn-sonata/master
jasonchristopher21 Nov 4, 2022
339d2e6
Add testing for JsonAdaptedCustomCommandBuilder
autumn-sonata Nov 4, 2022
2adb1d9
Edit builder for person, group and task for storage testing
autumn-sonata Nov 4, 2022
a99244e
Add typical persons, groups and tasks for easier testing
autumn-sonata Nov 4, 2022
bb76788
Edit typical tasks and groups to match with json files
autumn-sonata Nov 4, 2022
9373d76
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 4, 2022
60f10f0
Fix checkstyle errors
autumn-sonata Nov 5, 2022
cad00b4
Merge branch 'master' of https://github.com/autumn-sonata/tp into sto…
autumn-sonata Nov 5, 2022
3d3d6ff
Resolve eof errors
autumn-sonata Nov 5, 2022
cbea21c
Add test cases for jsonadapted abstractAttribute and Tag
autumn-sonata Nov 5, 2022
2630b8c
More tests
mohamedsaf1 Nov 5, 2022
3d380fd
Merge pull request #166 from autumn-sonata/storage-test
mohamedsaf1 Nov 5, 2022
dc5d98c
Add testing to json adapted task, group, person, book storage, and st…
autumn-sonata Nov 5, 2022
c3a986d
Fix Checkstyle Bugs
jasonchristopher21 Nov 5, 2022
d6d00cf
Edit test cases for jsonSerializableAddressBook
autumn-sonata Nov 6, 2022
fb23c36
Complete storage testing
autumn-sonata Nov 6, 2022
d26f0a7
Add newline to eof for checkstyle
autumn-sonata Nov 6, 2022
06b902a
Add additional newline at eof for json files
autumn-sonata Nov 6, 2022
a293b64
Checkstyle fix
mohamedsaf1 Nov 6, 2022
d170ae5
Checkstyle fix
mohamedsaf1 Nov 6, 2022
bbae355
More checkstyle fix
mohamedsaf1 Nov 6, 2022
ec85e54
Merge pull request #168 from autumn-sonata/storage-test-update
mohamedsaf1 Nov 6, 2022
b4f44a2
no message
mohamedsaf1 Nov 6, 2022
5f32138
Test case fix
mohamedsaf1 Nov 6, 2022
4e7b19d
Checkstyle fix
mohamedsaf1 Nov 6, 2022
9a978c7
Test case bug fix
mohamedsaf1 Nov 6, 2022
2ebf97d
no message
mohamedsaf1 Nov 6, 2022
c081a86
Refactor of code
mohamedsaf1 Nov 6, 2022
4d9be75
Merge pull request #167 from mohamedsaf1/master
autumn-sonata Nov 6, 2022
a7a217a
Merge branch 'master' of https://github.com/mohamedsaf1/tp
mohamedsaf1 Nov 6, 2022
6c5118c
Draft Test Cases for AbstractDisplayItem
jasonchristopher21 Nov 6, 2022
c9038c4
Update AbstractDisplayItemTest
jasonchristopher21 Nov 6, 2022
3c77f67
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 6, 2022
e6a63b2
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 6, 2022
04e6621
Fix Bugs on Parsing of Attributes
jasonchristopher21 Nov 6, 2022
af83536
Fix Checkstyle issues
jasonchristopher21 Nov 6, 2022
6c8a3a4
Update Test Cases
jasonchristopher21 Nov 6, 2022
93c32f5
Fix Checkstyle Issue
jasonchristopher21 Nov 6, 2022
3f080d8
Add Author Tag for parseAttribute logic
jasonchristopher21 Nov 6, 2022
8bdf2d9
Update Test Cases
jasonchristopher21 Nov 6, 2022
c2187f2
Update AbstractAttributeTest
jasonchristopher21 Nov 6, 2022
884f643
Fix Checkstyle issues
jasonchristopher21 Nov 6, 2022
d40b55d
Fix Checkstyle Issue
jasonchristopher21 Nov 6, 2022
570d616
Update test cases for AbstractDisplayItemTest
jasonchristopher21 Nov 6, 2022
4150e2d
Update test cases for AbstractDisplayItemTest
jasonchristopher21 Nov 6, 2022
385d24a
Fix Checkstyle Issue
jasonchristopher21 Nov 6, 2022
9afb1b5
Update test cases
jasonchristopher21 Nov 6, 2022
b1aed2b
Update AttributeListTest
jasonchristopher21 Nov 7, 2022
1736896
Revert equals to original
jasonchristopher21 Nov 7, 2022
3b52eec
Fix empty Task names not throwing an error
connlim Nov 7, 2022
1ccb438
Fix case sensitivity of prefix
jasonchristopher21 Nov 7, 2022
b22eeed
Remove print statements
connlim Nov 7, 2022
ab3a3d8
Fix test cases pertaining to Person::isSamePerson
jasonchristopher21 Nov 7, 2022
59b9eb8
Fix Checkstyle Issue
jasonchristopher21 Nov 7, 2022
dc982dd
Improve error message when adding user to group they are already in
connlim Nov 7, 2022
8757ea7
Add stricter phone number validation
connlim Nov 7, 2022
5d659c1
Update phone number restrictions
Eclipse-Dominator Nov 7, 2022
6c3d669
Update Test Cases for AbstractAttributeTest
jasonchristopher21 Nov 7, 2022
d6f6777
Add to faq, about and quick start of user guide
autumn-sonata Nov 7, 2022
c17238a
Update tests for new phone number restrictions
connlim Nov 7, 2022
528c4ae
Remove unused import
connlim Nov 7, 2022
a8c1d5f
Move existing relevant test files to seedu.address.model.attribute
jasonchristopher21 Nov 7, 2022
76dc948
Fix Checkstyle Issues
jasonchristopher21 Nov 7, 2022
c6feca3
Add AbstractSingleItemTest
jasonchristopher21 Nov 7, 2022
192f037
Country code '+' sign now optional
Eclipse-Dominator Nov 7, 2022
48eb30f
Update warning message when access is denied.
Eclipse-Dominator Nov 7, 2022
50b6d9f
Merge pull request #171 from connlim/branch-fix-bugs
Eclipse-Dominator Nov 7, 2022
32ee6c1
Add more MSS
connlim Nov 7, 2022
84b4f56
Merge pull request #173 from connlim/branch-dg-mss
Eclipse-Dominator Nov 7, 2022
ae2d4ea
Merge branch 'master' of https://github.com/AY2223S1-CS2103T-T11-1/tp…
Eclipse-Dominator Nov 7, 2022
f8cb234
Update constraints for phone
Eclipse-Dominator Nov 7, 2022
9f1203b
Edit user guide to make it more user centric
autumn-sonata Nov 7, 2022
161fd17
Update test cases for phone
Eclipse-Dominator Nov 7, 2022
158fa11
Fix missing checking for valid macro code
Eclipse-Dominator Nov 7, 2022
9b7389f
Update PPP for Connor
connlim Nov 7, 2022
1a170b1
Fix project name in Connor PPP
connlim Nov 7, 2022
24cd25b
Rename all instances of ContactMation to Contactmation
connlim Nov 7, 2022
4623abe
Update restriction on person
Eclipse-Dominator Nov 7, 2022
19014b6
Fixes checkstyle
Eclipse-Dominator Nov 7, 2022
d5190b3
Add field command usage in user guide
autumn-sonata Nov 7, 2022
bc58659
Update field related exceptions mesages
Eclipse-Dominator Nov 7, 2022
211235a
Add suggestions to user guide
autumn-sonata Nov 7, 2022
e5bc012
Merge branch 'master' of https://github.com/autumn-sonata/tp into use…
autumn-sonata Nov 7, 2022
ca3b41b
Fixes edit, add field command bug for tasks
Eclipse-Dominator Nov 7, 2022
1dcb651
Fix error messages
Eclipse-Dominator Nov 7, 2022
8ffa041
Merge pull request #175 from connlim/branch-dg-fix-name
Eclipse-Dominator Nov 7, 2022
b9b59a6
Merge pull request #174 from connlim/branch-ppp-connor
Eclipse-Dominator Nov 7, 2022
bc49858
Merge pull request #172 from autumn-sonata/user-guide-update
connlim Nov 7, 2022
96bbc35
More Tests
mohamedsaf1 Nov 7, 2022
701b8d1
Checkstlye fix in classes
mohamedsaf1 Nov 7, 2022
674f50f
Fix UG formatting issues
connlim Nov 7, 2022
7d16c5f
Checkstyle fix for tests
mohamedsaf1 Nov 7, 2022
faded82
More checkstyle fix
mohamedsaf1 Nov 7, 2022
60219f3
Fix bug on equals
jasonchristopher21 Nov 7, 2022
f6d0d6a
Merge remote-tracking branch 'upstream/master'
mohamedsaf1 Nov 7, 2022
ec72b9f
Update UG screenshots
connlim Nov 7, 2022
92cac2a
Fix Connor PPP wrong link
connlim Nov 7, 2022
fec74bf
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 7, 2022
d3d2c47
Update Connor PPP with new details
connlim Nov 7, 2022
5f538e9
no message
mohamedsaf1 Nov 7, 2022
2505864
Merge remote-tracking branch 'upstream/master'
mohamedsaf1 Nov 7, 2022
5654c01
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 7, 2022
1bacecd
Merge pull request #170 from Eclipse-Dominator/branch-minor-bug-fiix
autumn-sonata Nov 7, 2022
4adb5e1
Test bugs fix
mohamedsaf1 Nov 7, 2022
09ae460
Merge branch 'master' of https://github.com/autumn-sonata/tp into ppp…
autumn-sonata Nov 7, 2022
9f7ec5e
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 7, 2022
b16a6f8
Merge pull request #177 from connlim/branch-update-ug
jasonchristopher21 Nov 7, 2022
8937b87
Update Sequence Diagram for Attributes
jasonchristopher21 Nov 7, 2022
be8fb40
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 7, 2022
f8a7ceb
Updated ppp for autumn-sonata
autumn-sonata Nov 7, 2022
0c3c640
Merge pull request #178 from connlim/branch-ppp-connor
autumn-sonata Nov 7, 2022
62f6c36
Merge branch 'master' of https://github.com/autumn-sonata/tp into ppp…
autumn-sonata Nov 7, 2022
8f52ae0
Edit ppp for autumn-sonata for slight formatting errors
autumn-sonata Nov 7, 2022
2ca8096
Update User Guide
jasonchristopher21 Nov 7, 2022
5073dc8
Merge branch 'master' into branch-bug-fixes
jasonchristopher21 Nov 7, 2022
6250857
Update PPP for zhaoqi
Eclipse-Dominator Nov 7, 2022
e9954d1
Fix ParserUtil missing method
jasonchristopher21 Nov 7, 2022
4eec93e
Update model dg
Eclipse-Dominator Nov 7, 2022
676b668
Edit UG
mohamedsaf1 Nov 7, 2022
71040f9
Fix Checkstyle Issue
jasonchristopher21 Nov 7, 2022
9440887
Removes accidental changes to eric's ppp
Eclipse-Dominator Nov 7, 2022
9639958
Merge branch 'branch-ppp-zhaoqi' of https://github.com/Eclipse-Domina…
Eclipse-Dominator Nov 7, 2022
8cc1774
Merge pull request #169 from jasonchristopher21/branch-improve-test
mohamedsaf1 Nov 7, 2022
85264dd
Merge remote-tracking branch 'upstream/master'
mohamedsaf1 Nov 7, 2022
b25a657
Resolve conflict
mohamedsaf1 Nov 7, 2022
6be97d5
Merge pull request #180 from Eclipse-Dominator/branch-ppp-zhaoqi
connlim Nov 7, 2022
bb77f00
Merge branch 'master' of https://github.com/mohamedsaf1/tp
mohamedsaf1 Nov 7, 2022
5083e32
Update User Guide
jasonchristopher21 Nov 7, 2022
4bdd14a
Merge branch 'branch-ppp-zhaoqi' of https://github.com/Eclipse-Domina…
Eclipse-Dominator Nov 7, 2022
f633684
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 7, 2022
db43a6d
Checkstyle fix
mohamedsaf1 Nov 7, 2022
2262b5b
Move EntryType and Fields to Unused
jasonchristopher21 Nov 7, 2022
b89a554
Updates logic and model uml diagram
Eclipse-Dominator Nov 7, 2022
ff40707
Merge pull request #176 from mohamedsaf1/master
mohamedsaf1 Nov 7, 2022
be5831c
Make changes to storage description in developer guide
autumn-sonata Nov 7, 2022
f9ce8ea
Update Ui.png on website home page
connlim Nov 7, 2022
5dcf536
Use full names on About Us page
connlim Nov 7, 2022
fa1c084
Update responsibilities on About Us page
connlim Nov 7, 2022
d7529dc
Update PPP of mohamedsaf1
mohamedsaf1 Nov 7, 2022
052b1b9
Update ppp of autumn-sonata
autumn-sonata Nov 7, 2022
2492d23
Merge pull request #185 from mohamedsaf1/master
mohamedsaf1 Nov 7, 2022
9f2d84f
Add additional work in ppp autumn-sonata
autumn-sonata Nov 7, 2022
7bab958
Merge pull request #184 from connlim/branch-update-about-us
autumn-sonata Nov 7, 2022
997547a
Merge pull request #182 from autumn-sonata/developer-guide
connlim Nov 7, 2022
eb6fa5f
Merge branch 'master' into ppp-update
autumn-sonata Nov 7, 2022
72292bf
Updates dg with delete and pipe sequence diagrams
Eclipse-Dominator Nov 7, 2022
d6c588d
Merge pull request #179 from autumn-sonata/ppp-update
connlim Nov 7, 2022
0683b72
Merge pull request #156 from jasonchristopher21/branch-bug-fixes
Eclipse-Dominator Nov 7, 2022
6f32e84
Merge pull request #181 from Eclipse-Dominator/branch-dg-update
connlim Nov 7, 2022
28f14b1
Update Developer Guide
jasonchristopher21 Nov 7, 2022
0c4b4f4
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 7, 2022
d6f775b
Merge branch 'master' of https://github.com/jasonchristopher21/tp int…
jasonchristopher21 Nov 7, 2022
a9d7d99
Updated ppp
Eclipse-Dominator Nov 7, 2022
9b797f7
Merge pull request #183 from connlim/branch-update-ui-image
mohamedsaf1 Nov 7, 2022
ef3491e
Merge pull request #186 from Eclipse-Dominator/branch-ppp-update-2
connlim Nov 7, 2022
3959fa6
Update Checkstyle
jasonchristopher21 Nov 7, 2022
cadf97e
Update ppp link to pull requests
autumn-sonata Nov 7, 2022
de66e8a
Fix user guide title
connlim Nov 7, 2022
6121f11
Merge branch 'master' of https://github.com/autumn-sonata/tp into ppp…
autumn-sonata Nov 7, 2022
9340fd7
Merge pull request #187 from jasonchristopher21/branch-ug-dg
mohamedsaf1 Nov 7, 2022
1cd7a52
Assign user to code
Eclipse-Dominator Nov 7, 2022
5a24d21
Merge pull request #189 from autumn-sonata/ppp-update
mohamedsaf1 Nov 7, 2022
7b2bb45
Merge pull request #190 from Eclipse-Dominator/branch-author-tags
mohamedsaf1 Nov 7, 2022
303cdfb
Merge pull request #188 from connlim/branch-fix-ug-title
mohamedsaf1 Nov 7, 2022
84d88a3
Add page break in ppp autumn-sonata
autumn-sonata Nov 7, 2022
5f557b1
Merge pull request #191 from autumn-sonata/ppp-update
Eclipse-Dominator Nov 7, 2022
e8ab789
Edit user guide
autumn-sonata Nov 10, 2022
b46558d
Merge pull request #192 from autumn-sonata/user-guide-update
Eclipse-Dominator Nov 10, 2022
37f96f5
Update User Guide for CS2101
jasonchristopher21 Nov 11, 2022
7dcf2b2
Merge branch 'master' of https://github.com/AY2223S1-CS2103T-T11-1/tp…
jasonchristopher21 Nov 11, 2022
1994e0b
Clean up user guide
jasonchristopher21 Nov 11, 2022
9e76f08
Merge pull request #193 from jasonchristopher21/branch-cs2101-ug
Eclipse-Dominator Nov 11, 2022
900578a
Added more examples
Eclipse-Dominator Nov 11, 2022
1b7c319
fix broken links
Eclipse-Dominator Nov 11, 2022
ba9055d
Adds missing images
Eclipse-Dominator Nov 11, 2022
c8ebf62
Fix image pathing
Eclipse-Dominator Nov 11, 2022
e88cd0a
Merge pull request #194 from Eclipse-Dominator/branch-cs2101-ug
autumn-sonata Nov 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Sequence Diagram for Attributes
jasonchristopher21 committed Nov 7, 2022
commit 8937b8777ca8bbb234b5f94c31a4d12239bac6af
97 changes: 22 additions & 75 deletions docs/diagrams/AddFieldSequenceDiagram.puml
Original file line number Diff line number Diff line change
@@ -7,98 +7,37 @@ participant ":AddressBookParser" as AddressBookParser LOGIC_COLOR
participant ":AddFieldCommandParser" as AddFieldCommandParser LOGIC_COLOR
participant ":AddFieldCommand" as AddFieldCommand LOGIC_COLOR
participant ":CommandResult" as CommandResult LOGIC_COLOR
participant "prefix:Prefix" as Prefix LOGIC_COLOR
participant "//FIELD_PREFIX//:FieldPrefixes" as FIELD_PREFIX LOGIC_COLOR
end box

box Model MODEL_COLOR_T1
participant ":Model" as Model MODEL_COLOR
participant "persons:UniquePersonList" as UniquePersonList MODEL_COLOR
participant "person:Person" as Person MODEL_COLOR
participant "fields:Fields" as Fields MODEL_COLOR
participant ":Field" as Field MODEL_COLOR
participant ":DisplayItem" as DisplayItem MODEL_COLOR
end box

[-> LogicManager : execute("fields g/ github")
[-> LogicManager : execute()
activate LogicManager

LogicManager -> AddressBookParser : parseCommand("fields g/ github")
LogicManager -> AddressBookParser : parseCommand()
activate AddressBookParser

create AddFieldCommandParser
AddressBookParser -> AddFieldCommandParser
activate AddFieldCommandParser

AddFieldCommandParser --> AddressBookParser
deactivate AddFieldCommandParser

AddressBookParser -> AddFieldCommandParser : parse("g/ github")
activate AddFieldCommandParser

create Prefix
AddFieldCommandParser -> Prefix : Prefix("g/")
activate Prefix

Prefix --> AddFieldCommandParser
deactivate Prefix

create AddFieldCommand
AddFieldCommandParser -> AddFieldCommand : AddFieldCommand()
activate AddFieldCommand

AddFieldCommand --> AddFieldCommandParser
deactivate AddFieldCommand

AddFieldCommandParser --> AddressBookParser
deactivate AddFieldCommandParser
'Hidden arrow to position the destroy marker below the end of the activation bar.
AddFieldCommandParser -[hidden]-> AddressBookParser
destroy AddFieldCommandParser

AddressBookParser --> LogicManager :
deactivate AddressBookParser

LogicManager -> AddFieldCommand : execute()
AddFieldCommandParser -> AddFieldCommand
activate AddFieldCommand

AddFieldCommand -> FIELD_PREFIX : addPrefix(prefix, "github")
activate FIELD_PREFIX
AddFieldCommand -> DisplayItem : selectFromRightModel()
activate DisplayItem

FIELD_PREFIX -> Model : addField("github")
activate Model
DisplayItem --> AddFieldCommand
deactivate DisplayItem

Model -> UniquePersonList : addField("github")
activate UniquePersonList
AddFieldCommand -> DisplayItem : addAttribute()
activate DisplayItem

loop until each Person in persons has been iterated
UniquePersonList -> Person : addField("github")
activate Person

Person -> Fields : addField("github")
activate Fields

create Field
Fields -> Field : Field("github")
activate Field

Field --> Fields
deactivate Field

Fields --> Person
deactivate Fields

Person --> UniquePersonList
deactivate Person
end

UniquePersonList --> Model
deactivate UniquePersonList

Model --> FIELD_PREFIX
deactivate Model

FIELD_PREFIX --> AddFieldCommand
deactivate FIELD_PREFIX
DisplayItem --> AddFieldCommand
deactivate DisplayItem

create CommandResult
AddFieldCommand -> CommandResult
@@ -107,9 +46,17 @@ activate CommandResult
CommandResult --> AddFieldCommand
deactivate CommandResult

AddFieldCommand --> LogicManager : result
AddFieldCommand --> AddFieldCommandParser
deactivate AddFieldCommand

[<--LogicManager
AddFieldCommandParser --> AddressBookParser
deactivate AddFieldCommandParser

AddressBookParser --> LogicManager
deactivate AddressBookParser

[<-- LogicManager
deactivate LogicManager


@enduml
43 changes: 43 additions & 0 deletions docs/diagrams/AddFieldSequenceDiagramModel.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
@startuml
'https://plantuml.com/sequence-diagram
!include style.puml

box Model MODEL_COLOR_T1
participant ":Model" as Model MODEL_COLOR
participant "persons:UniquePersonList" as UniquePersonList MODEL_COLOR
participant "person:Person" as Person MODEL_COLOR
participant "fields:Fields" as Fields MODEL_COLOR
participant ":Field" as Field MODEL_COLOR
end box

activate Model

Model -> UniquePersonList : addField("github")
activate UniquePersonList

loop until each Person in persons has been iterated
UniquePersonList -> Person : addField("github")
activate Person

Person -> Fields : addField("github")
activate Fields

create Field
Fields -> Field : Field("github")
activate Field

Field --> Fields
deactivate Field

Fields --> Person
deactivate Fields

Person --> UniquePersonList
deactivate Person
end

UniquePersonList --> Model
deactivate UniquePersonList

deactivate Model
@enduml
Binary file added docs/images/AddFieldSequenceDiagram1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.