-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JThh] ip #364
Open
JThh
wants to merge
65
commits into
nus-cs2103-AY2223S2:master
Choose a base branch
from
JThh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[JThh] ip #364
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
556af3f
Add Gradle support
41d3174
Init Level 1. Greet, Echo, Exit
b74f259
Init Level 2. Add, List
9926150
Finish Level 3. Mark as Done
f1781e5
Finish Level 3. Mark as Done
3272357
Finish Level 4. ToDos, Events, Deadlines
f35eeda
Finish Level 6. Delete
cef55ac
Finish Level 6. Delete
89b047b
Finish Level 6. Delete
8637026
Finish Level 6. Delete
a01b890
Finish Level 5. Exception
eb0d5db
Finish Level 5. Exception
e1aa1ec
Merge remote-tracking branch 'origin/master'
f1c11d3
Level-7 Finish
a353a03
Level-8 Finish
6300a04
Merge branch 'branch-Level-7'
0792b27
Level-8 Finish
7105732
Merge branch 'branch-Level-7'
717395e
Update Duke.java
JThh dd2153c
Merge branch 'master' into Level-8
JThh 2cc5e4a
Merge pull request #1 from JThh/Level-8
JThh 6de7960
More OOP in-progress
e6212c5
More OOP
c221412
resolved conflicts
28ed102
Merge pull request #3 from JThh/branch-Level-7
JThh b3a0071
removed unused files
7a694e6
added gradle support
b966dc8
Merge branch 'master' into add-gradle-support
2d9ca5e
Modified tests
2fe004b
add workflow script and modify test files
c99555e
add date parsing function and fix unit tests
a605b0d
finish jar file creation
88a162a
omit data
b7554d5
Create gradle.yml
JThh 6d29b0c
add gui init
b20bdf1
fixed ci tests
0e2d481
fix gradle
8c7b0c8
add java doc
b36e5a0
refactor codes and add command class
26d5c27
fixes merging conflicts
0bc35eb
finishes adding find function
3dc32ba
Merge branch 'master' into branch-A-JavaDoc
8baab87
Add gui
1261027
Merge branch 'master' into branch-A-JavaDoc
b9be6ca
Fix GUI
962a618
Add Ui png
f58e500
Fix gui
8ab92df
Merge branch 'master' into branch-A-JavaDoc
d36f2ce
Make command class attributes private and methods non-static
ee750ad
Finish comments
a3f3019
Add assertions for input sanity check
51ad510
Refactor codes
5533235
Refactor codes
9497575
Fix CI
aa88a18
Fix CI
d7ecdad
Add check duplicate functionality
033f3ee
Fix CI
503fbb9
Fix CI
083b67d
Fix CI: another trial
46b8178
Replace ui png
9749f0a
Fix CI
3df55f8
Add streaming behaviors
4899d04
Add streaming behaviors
5a6e8fe
Add README.md
fb6b17f
Merge pull request #4 from JThh/branch-A-CodeQuality
JThh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,6 +96,7 @@ public DukeEmptyTaskException (String msg) { | |
public static String parse_date(String s) { | ||
DateTimeFormatter read_fmt = DateTimeFormatter.ofPattern("yyyy-MM-dd HHmm"); | ||
DateTimeFormatter print_fmt = DateTimeFormatter.ofPattern("MMM dd yyyy"); | ||
|
||
try { | ||
LocalDate lt = LocalDate.parse(s, read_fmt); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it possible to make the argument more expressive? |
||
return lt.format(print_fmt); | ||
|
@@ -234,4 +235,4 @@ public static void main(String[] args) { | |
} | ||
} | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "parse_date", perhaps you could rename it to "parseDate", which conforms to the coding standard?