Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iapetusbob] iP #385

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

Conversation

iapetusbob
Copy link

@iapetusbob iapetusbob commented Feb 2, 2023

DOOK

“My unmatched perspicacity, coupled with sheer indefatigability, makes me a feared opponent in any realm of human endeavor.” – Andrew Tate (source)

DOOK frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
FAST SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class DOOK{
    public static void main(String[] args) {
        new DOOK(<filePath>).run();
    }
}

Copy link

@seriouslia0 seriouslia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addTodo(new Todo(taskName));
System.out.println(askForCmd);
takeCmd();
} else if (cmd[0].equals("deadline")){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to split commands into seperate functions

}
}

public class TaskNotInListException extends Exception {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering putting the exceptions into different class files


public void mark(String markCmd, int i) throws TaskNotInListException, TaskAlrMarkException {
/**
* Marks the i-1 th index Task as done if not done and vice versa.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful comments! Really helps improve the readability of your code!

Copy link

@elvern18 elvern18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic of code LGTM. However, much can be done to make the code cleaner and increase readability. ATB!

@@ -1,10 +1,188 @@
import java.util.Scanner;
import java.util.Arrays;
import DukeHelpfulCode.*;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can ensure import classes are stated explicitly to meet coding standards.
Eg. import DukeHelpfulCode.Task;

}

private static void takeCmd() {
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detailed JavaDoc comment that tells others what each command does. However, JavaDoc comment should be outside and above the function to meet coding standards.

Is it possible to separate the code into smaller functions that will be called? This makes that code looks cleaner.

@@ -1,10 +1,188 @@
import java.util.Scanner;
import java.util.Arrays;
import DukeHelpfulCode.*;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package name should also be in all lower case to meet coding standards.

@@ -0,0 +1,59 @@
package DukeHelpfulCode;

public class Task {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaDoc for classes should also be outside and above the class itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants