Skip to content

Commit

Permalink
Merge pull request #193 from elhy1999/branch-ppp
Browse files Browse the repository at this point in the history
Update PPP - Ernest
  • Loading branch information
elhy1999 authored Nov 10, 2023
2 parents 4a4639b + e3f65b3 commit 8b70d95
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 19 deletions.
2 changes: 1 addition & 1 deletion docs/AboutUs.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ You can reach us at the email `seer[at]comp.nus.edu.sg`
[[portfolio](team/elhy1999.md)]

* Role: Developer
* Responsibilities: Documentations
* Responsibilities: Documentation, Testing

### Rubesh Suresh

Expand Down
43 changes: 25 additions & 18 deletions docs/team/elhy1999.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,40 @@ title: Ernest's Project Portfolio Page

### Project: UniCa$h

UniCa$h is a desktop application used for university students who want to be more financially conscious.
The user interacts with it using a CLI, and it has a GUI created with JavaFX.
UniCa$h is a finance tracking application for university students who want to be more financially conscious.
The user interacts with it using a CLI, and it has a GUI created with JavaFX. It is written in Java, and has about 19 kLoC.

Given below are my contributions to the project.

* **New Feature**: *to be added*
* What it does: *to be added*
* Justification: *to be added*
* Highlights: *to be added*
* Credits: *{mention here if you reused any code/ideas from elsewhere or if a third-party library is heavily used in the feature so that a reader can make a more accurate judgement of how much effort went into the feature}*
* **New Feature**: *Edit transaction command* [[PR #64](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/64)]
* What it does: *Edits an existing transaction in UniCa$h.*
* Justification: *The `edit` command was refactored from AB3's implementation to make modifications on `Transaction` objects and its fields*
* Credits: *AddressBook - Level 3, which UniCa$h's edit feature was refactored from*

* **Code contributed**: [RepoSense link]()

* **Project management**:
* *to be added*
* **New Feature**: *Expense Summary Plots*
* What it does: *Generates a pop-up window which contains summary plots (pie chart [[PR #100](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/100)] and line chart [[PR #124](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/124)]) for the user's expenses. The plots provide a high-level overview of the user's expenses broken down per category and per month.*
* Justification: *It might be difficult for users to understand their spending habits. This feature provides some simple analytics tools to aid in this regard, which can be further improved in future iterations.*
* Highlights: *Fixing the assigned colours to each pie of the pie chart as JavaFX repeats the assigned colours after 8 pies are added to the chart.*

* **Enhancements to existing features**:
* *to be added*
* Added and improved tests written for add, find, and delete transaction commands [[PR #88](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/88)]

* **Code contributed**: [RepoSense link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=t16-3&sort=groupTitle&sortWithin=title&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code&since=2023-09-22&tabOpen=true&tabType=authorship&tabAuthor=elhy1999&tabRepo=AY2324S1-CS2103-T16-3%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=docs~functional-code~test-code&authorshipIsBinaryFileTypeChecked=false&authorshipIsIgnoredFilesChecked=false)

* **Project management**:
* Managed releases `v1.2b` (1 release) on GitHub

* **Documentation**:
* User Guide:
* *to be added*
* Developer Guide:
* *to be added*
* User Guide:
* Added documentation for **Edit Transaction feature** and **Summary feature** to the UG [[PR #136](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/136)]
* Fixed documentation bugs found during the PE Dry Run [[PR #188](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/188)]
* Developer Guide:
* Added implementation details for **Edit Transaction feature** and **Summary feature** to the DG [[PR #106](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/106)]


* **Community**:
* *to be added*
* PRs reviewed (with non-trivial review comments): [[PR #56](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/56)], [[PR #87](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/87)], [[PR #141](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/141)]
* Non-trivial bugs found in other team's projects: [[Issue #131](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/131)], [[Issue #142](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/142)], [[Issue #149](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/149)], [[Issue #163](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/163)], [[Issue #125](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/125)]

* **Tools**:
* *to be added*
* PlantUML for drawing UML diagrams for the DG

0 comments on commit 8b70d95

Please sign in to comment.