Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-W12-4] TimetaBRO #204

Open
wants to merge 644 commits into
base: master
Choose a base branch
from

Conversation

andrefoo
Copy link

@andrefoo andrefoo commented Oct 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (517b785) 75.26% compared to head (cf48443) 75.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
+ Coverage     75.26%   75.42%   +0.16%     
- Complexity      419      970     +551     
============================================
  Files            71      110      +39     
  Lines          1338     3052    +1714     
  Branches        126      367     +241     
============================================
+ Hits           1007     2302    +1295     
- Misses          301      660     +359     
- Partials         30       90      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kristayeo and others added 29 commits November 7, 2023 20:54
Previously, if there was a duplicate prefix, users would just get error
Now, the error will tell users which prefix is duplicated

Similarly, users would just get an error for a missing prefix
Now, error will tell users which prefix is missing
Fix bug with add/remove event/schedule commands
Previously, there were bugs with error messages from addevent, rmevent,
addschedule, and rmschedule.

These bugs were mainly due to differences in command output
and User Guide documentation.

There was also an issue where event names automatically change to lower case
even when they were keyed in upper case.

These issues have been fixed and updated accordingly in the User Guide
UG has been updated to inform users that they can click on their
friends to display their timetable
Previously, if there was 1 friend with no common free time,
cft command would only display an error saying that user and friend
have no common free times, and not proceed to show the friends that
have common free times.

This issue has been fixed. Expected output should now be:
You and Friend have no common free time!
You and John Doe have common free times at:
...
Krista Yeo and others added 30 commits November 14, 2023 04:22
ReadMe was outdated with wrong info about TimetaBRO. Outdated
methods that were not used were present as well.

Fix README.md to reflect changes, and delete redundant methods.
Resolve grammatical errors
Add help pop-up image
Add use cases for each command
Improve consistency of tone and language used
Add FAQ about 2400 timing.
Add 1 Known Issue (Future birthdays)
Add guidance for hyperlinks and table of contents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants