-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103T-W12-4] TimetaBRO #204
Open
andrefoo
wants to merge
644
commits into
nus-cs2103-AY2324S1:master
Choose a base branch
from
AY2324S1-CS2103T-W12-4:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103T-W12-4] TimetaBRO #204
andrefoo
wants to merge
644
commits into
nus-cs2103-AY2324S1:master
from
AY2324S1-CS2103T-W12-4:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
============================================
+ Coverage 75.26% 75.42% +0.16%
- Complexity 419 970 +551
============================================
Files 71 110 +39
Lines 1338 3052 +1714
Branches 126 367 +241
============================================
+ Hits 1007 2302 +1295
- Misses 301 660 +359
- Partials 30 90 +60 ☔ View full report in Codecov by Sentry. |
Changes to the help pop-up
Previously, if there was a duplicate prefix, users would just get error Now, the error will tell users which prefix is duplicated Similarly, users would just get an error for a missing prefix Now, error will tell users which prefix is missing
Fix bugs in logic classes
Fix bug with add/remove event/schedule commands
Previously, there were bugs with error messages from addevent, rmevent, addschedule, and rmschedule. These bugs were mainly due to differences in command output and User Guide documentation. There was also an issue where event names automatically change to lower case even when they were keyed in upper case. These issues have been fixed and updated accordingly in the User Guide
Previously, if there was 1 friend with no common free time, cft command would only display an error saying that user and friend have no common free times, and not proceed to show the friends that have common free times. This issue has been fixed. Expected output should now be: You and Friend have no common free time! You and John Doe have common free times at: ...
Update lululwtv.md
Update owenyeo.md
Update UserGuide.md
Update UserGuide
UserGuide.md update
ReadMe was outdated with wrong info about TimetaBRO. Outdated methods that were not used were present as well. Fix README.md to reflect changes, and delete redundant methods.
Update PPP
Resolve grammatical errors
Fix DeveloperGuide.md
Update UG
Fix use cases
Update PPP
Add 1 Known Issue (Future birthdays) Add guidance for hyperlinks and table of contents.
Update UserGuide.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.