Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-W10-1] Teacher's Pet #48

Open
wants to merge 324 commits into
base: master
Choose a base branch
from

Conversation

NicholasT1
Copy link

Teacher’s Pet helps Teaching Assistants (TAs) in the management of student information by consolidating contact details, grades, and additional pertinent data into one accessible platform.

This efficient tool simplifies tracking student performance and communication, enhancing organisational efficiency for teaching assistants.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 29.31034% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/main/java/seedu/address/model/person/Person.java 0.00% 9 Missing ⚠️
...ain/java/seedu/address/model/person/StudentId.java 57.14% 4 Missing and 2 partials ⚠️
.../java/seedu/address/storage/JsonAdaptedPerson.java 33.33% 5 Missing and 1 partial ⚠️
...a/seedu/address/logic/parser/AddCommandParser.java 0.00% 5 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 5 Missing ⚠️
.../seedu/address/logic/parser/EditCommandParser.java 0.00% 4 Missing ⚠️
...java/seedu/address/logic/commands/EditCommand.java 62.50% 3 Missing ⚠️
src/main/java/seedu/address/logic/Messages.java 0.00% 2 Missing ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 0.00% <ø> (-100.00%) 0.00 <0.00> (-8.00)
...ain/java/seedu/address/logic/parser/CliSyntax.java 83.33% <100.00%> (ø) 1.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% <ø> (-20.00%) 0.00 <0.00> (-1.00)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/logic/Messages.java 0.00% <0.00%> (-87.50%) 0.00 <0.00> (-3.00)
...java/seedu/address/logic/commands/EditCommand.java 48.71% <62.50%> (-48.72%) 0.00 <0.00> (-13.00)
.../seedu/address/logic/parser/EditCommandParser.java 0.00% <0.00%> (-92.60%) 0.00 <0.00> (-11.00)
...a/seedu/address/logic/parser/AddCommandParser.java 0.00% <0.00%> (-100.00%) 0.00 <0.00> (-5.00)
...in/java/seedu/address/logic/parser/ParserUtil.java 11.11% <0.00%> (-86.12%) 2.00 <0.00> (-12.00)
...ain/java/seedu/address/model/person/StudentId.java 57.14% <57.14%> (ø) 3.00 <3.00> (?)
... and 2 more

... and 26 files with indirect coverage changes

gabriellegtw and others added 7 commits October 3, 2024 16:49
Reopen milestone because gabriellegtw's progress not captured on cs2103t website/dashboard
When we use the list command AND there is no one in the list, it will return the message "Listed all persons"

Let's change it such that it returns "There is.. no one?" so that the user knows that there is really no one in the list and is not facing a bug
Add message when list is empty
Add message when list is empty
juliantayyc pushed a commit to juliantayyc/tp that referenced this pull request Oct 9, 2024
NicholasT1 and others added 21 commits October 10, 2024 16:11
Add auto formatting for StudentId and NetId
Adds specific feedback to user for wrong delete inputs
Implement find feature with name and student ID search
Fix Find command tests by disabling. Clean up code
Some students may have special characters in their names such as
"s/o".
Make Year, Major and NUS Net ID optional Fields
Add test coverage report to .gitignore
Add new Test cases for the new fields in Person Class
Adds delete test case and stub model
NicholasT1 and others added 30 commits November 7, 2024 20:23
Change from maximum of 50 characters to 100 characters
Show command is currently case sensitive.

Let's tweak it so that the keywords are found regardless of case
* Update the phrasing of 1 message
* Update the Developer Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants